From: Ivan Shmakov <ivan@siamics.net>
To: 19226@debbugs.gnu.org
Subject: bug#19226: eww.el desktop support fixes: autoload eww-mode, use inhibit-read-only
Date: Sun, 30 Nov 2014 20:15:49 +0000 [thread overview]
Message-ID: <87mw78molm.fsf@violet.siamics.net> (raw)
In-Reply-To: <wcvblw797s.fsf@fencepost.gnu.org> (Glenn Morris's message of "Sun, 30 Nov 2014 14:57:11 -0500")
>>>>> Glenn Morris <rgm@gnu.org> writes:
>>>>> Ivan Shmakov wrote:
>> * eww.el (eww-mode): Autoload, as expected by desktop.el.
> Then IMO desktop.el should autoload it, rather than adding a general
> autoload cookie.
That’s the point: as currently implemented, desktop.el uses a
general autoload cookie to map major modes (as preserved in the
desktop file) to Emacs features to load before handling any
given buffer. Consider, for instance:
514 Modules that define a major mode that needs a special handler should contain
515 code like
516
517 (defun foo-restore-desktop-buffer
518 ...
519 (add-to-list 'desktop-buffer-mode-handlers
520 '(foo-mode . foo-restore-desktop-buffer))
521
522 Furthermore the major mode function must be autoloaded.")
…
1319 (defun desktop-load-file (function)
1320 "Load the file where auto loaded FUNCTION is defined."
1321 (when (fboundp function)
1322 (autoload-do-load (symbol-function function) function)))
…
(See also the uses of desktop-load-file in desktop.el.)
> (Yes, this may be inconsistent with some existing cases.)
As for the existing cases, the change suggested exactly matches
info.el:
4222 ;; Autoload cookie needed by desktop.el
4223 ;;;###autoload
4224 (define-derived-mode Info-mode nil "Info" ;FIXME: Derive from special-mode?
…
4312 (setq-local bookmark-make-record-function #'Info-bookmark-make-record))
--
FSF associate member #7257 http://boycottsystemd.org/ … 3013 B6A0 230E 334A
next prev parent reply other threads:[~2014-11-30 20:15 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-13 12:17 bug#18010: eww: desktop support Ivan Shmakov
2014-11-04 16:36 ` Ted Zlatanov
2014-11-10 21:24 ` Lars Magne Ingebrigtsen
2014-11-10 21:32 ` Glenn Morris
2014-11-10 21:36 ` Lars Magne Ingebrigtsen
2014-11-19 10:24 ` Ivan Shmakov
2014-11-19 17:23 ` Lars Magne Ingebrigtsen
2014-11-19 20:17 ` Ivan Shmakov
2014-11-23 15:10 ` Ivan Shmakov
2014-11-23 15:44 ` Lars Magne Ingebrigtsen
2014-11-30 11:04 ` bug#19226: eww.el desktop support fixes: autoload eww-mode, use inhibit-read-only Ivan Shmakov
2014-11-30 19:57 ` Glenn Morris
2014-11-30 20:15 ` Ivan Shmakov [this message]
2014-12-01 2:22 ` Glenn Morris
2014-12-01 5:59 ` Ivan Shmakov
2014-12-01 13:52 ` Stefan Monnier
2014-12-07 18:56 ` Ivan Shmakov
2014-12-08 2:54 ` Stefan Monnier
2014-12-09 19:45 ` Ivan Shmakov
2014-12-10 0:35 ` Stefan Monnier
2015-02-14 20:50 ` Ivan Shmakov
2015-02-16 19:12 ` Ivan Shmakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mw78molm.fsf@violet.siamics.net \
--to=ivan@siamics.net \
--cc=19226@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.