From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dima Kogan Newsgroups: gmane.emacs.bugs Subject: bug#19363: Acknowledgement (24.4.1; Notifications can make ERC unusable) Date: Sun, 04 Jan 2015 13:26:15 -0800 Message-ID: <87mw5ykyl8.fsf@secretsauce.net> References: <87r3w4njp1.fsf@secretsauce.net> <87egrgmd29.fsf@secretsauce.net> <87bnmkmbx8.fsf@secretsauce.net> <878uhnn3ub.fsf@secretsauce.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1420408102 31009 80.91.229.3 (4 Jan 2015 21:48:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 4 Jan 2015 21:48:22 +0000 (UTC) Cc: 19363@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jan 04 22:48:15 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Y7t1w-0004KD-Cc for geb-bug-gnu-emacs@m.gmane.org; Sun, 04 Jan 2015 22:48:12 +0100 Original-Received: from localhost ([::1]:58214 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y7t1v-0007mN-T8 for geb-bug-gnu-emacs@m.gmane.org; Sun, 04 Jan 2015 16:48:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43878) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y7t1r-0007lO-8G for bug-gnu-emacs@gnu.org; Sun, 04 Jan 2015 16:48:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y7t1n-0007DI-1B for bug-gnu-emacs@gnu.org; Sun, 04 Jan 2015 16:48:07 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:55551) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y7t1m-0007Cc-M2 for bug-gnu-emacs@gnu.org; Sun, 04 Jan 2015 16:48:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Y7t1m-00018c-9J for bug-gnu-emacs@gnu.org; Sun, 04 Jan 2015 16:48:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dima Kogan Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 04 Jan 2015 21:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19363 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19363-submit@debbugs.gnu.org id=B19363.14204080414322 (code B ref 19363); Sun, 04 Jan 2015 21:48:02 +0000 Original-Received: (at 19363) by debbugs.gnu.org; 4 Jan 2015 21:47:21 +0000 Original-Received: from localhost ([127.0.0.1]:36684 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y7t17-00017e-5U for submit@debbugs.gnu.org; Sun, 04 Jan 2015 16:47:21 -0500 Original-Received: from out1-smtp.messagingengine.com ([66.111.4.25]:60197) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y7t13-00017R-Jo for 19363@debbugs.gnu.org; Sun, 04 Jan 2015 16:47:18 -0500 Original-Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 2ED5821C31 for <19363@debbugs.gnu.org>; Sun, 4 Jan 2015 16:47:17 -0500 (EST) Original-Received: from frontend1 ([10.202.2.160]) by compute6.internal (MEProxy); Sun, 04 Jan 2015 16:47:17 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=secretsauce.net; h=x-sasl-enc:references:from:to:cc:subject:date:in-reply-to :message-id:mime-version:content-type; s=mesmtp; bh=k1lwaq4+hzVj nSl3jeMwr8tjoPc=; b=slw50aiLEH5/Q8JDkmYmSnUWheGLnAGFSVKDAKV9trZr hdkwexq9wPSM1tNR5oU7bCDpeqwjFBPA98TWVJfLdsEKgv9ug543pD+0cCVpUi3F ThCXDal6oGOsu4ZSXMbu8RgUOZk/FXaNHMY52eKNBitZbtarhI/eGBbKDk+ZmFA= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=x-sasl-enc:references:from:to:cc:subject :date:in-reply-to:message-id:mime-version:content-type; s= smtpout; bh=k1lwaq4+hzVjnSl3jeMwr8tjoPc=; b=utgdVZw5xsWrxB9W6u3T DdwJeC1XYez8eujesHGj684OIW4xv5DrweKoirlyudWKUWwn91WzFLIHWrqqyT8I sFZZx9p+queB4ouEKGlW02P1gXyeL5L8rZmE1ucPhVlwi17+GZlXTSalCw5VnLCj 3L4KntNAJBDQiph5+ASURlk= X-Sasl-enc: 2u1O4U6ovTUB4aXC46QPfp3gXVg0fRqTuMotlSdrgIk+ 1420408036 Original-Received: from shorty.local (unknown [75.173.95.188]) by mail.messagingengine.com (Postfix) with ESMTPA id C8763C0027E; Sun, 4 Jan 2015 16:47:16 -0500 (EST) Original-Received: from dima by shorty.local with local (Exim 4.84) (envelope-from ) id 1Y7t11-0006oJ-F0; Sun, 04 Jan 2015 13:47:15 -0800 In-reply-to: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:98003 Archived-At: Stefan Monnier writes: >> If we have some (eval-after-load 'erc ...) stuff then by the time this >> (defvar) is evaluated, the list may already have a value, so the defvar >> then does NOT add its value to the list. The patch explicitly changes >> the (defvar list default) idiom to >> (defvar list nil) (add-to-list 'list default) and thus the default value >> always appears in the list. > > But I do wonder: if the function *has* to be on that hook for ERC to > work correctly, then maybe that function's place is not in the hook but > right at those places where the hook is run (i.e. hard-coded). > Could you (or someone who understands the code better than I do) take > a look to see if such a change would be even better? Hi. I suspect that hard-coding this would be a very big and unwelcome change in this case because there's some indirection here. Each ERC "response handler" has a hook such as this. The (defvar ...) (add-to-list ...) happens in the macro that defines a response handler: define-erc-response-handler, and the hooks are invoked in a general way for all server responses in erc-handle-parsed-server-response. So the bug I was seeing was due specifically to missing PRIVMSG response handlers, but the patch fixes all response handlers generically.