From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.bugs Subject: bug#19564: 24.4; eieio backward compatibility Date: Tue, 13 Jan 2015 19:06:34 +0100 Message-ID: <87mw5my2qd.fsf@gmail.com> References: <87oaq5sq0h.fsf@gmail.com> <87r3v01qwg.fsf@gmail.com> <87oaq2x3gb.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1421172441 14164 80.91.229.3 (13 Jan 2015 18:07:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 13 Jan 2015 18:07:21 +0000 (UTC) Cc: 19564@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jan 13 19:07:15 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YB5s2-00071v-6h for geb-bug-gnu-emacs@m.gmane.org; Tue, 13 Jan 2015 19:07:14 +0100 Original-Received: from localhost ([::1]:40726 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YB5s1-0000NW-Ae for geb-bug-gnu-emacs@m.gmane.org; Tue, 13 Jan 2015 13:07:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34014) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YB5ru-0000IH-P3 for bug-gnu-emacs@gnu.org; Tue, 13 Jan 2015 13:07:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YB5rq-0002FI-Ad for bug-gnu-emacs@gnu.org; Tue, 13 Jan 2015 13:07:06 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:46889) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YB5rq-0002FC-6k for bug-gnu-emacs@gnu.org; Tue, 13 Jan 2015 13:07:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YB5rp-000748-RF for bug-gnu-emacs@gnu.org; Tue, 13 Jan 2015 13:07:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Thierry Volpiatto Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Jan 2015 18:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19564 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19564-submit@debbugs.gnu.org id=B19564.142117241627148 (code B ref 19564); Tue, 13 Jan 2015 18:07:01 +0000 Original-Received: (at 19564) by debbugs.gnu.org; 13 Jan 2015 18:06:56 +0000 Original-Received: from localhost ([127.0.0.1]:55750 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YB5rj-00073n-Jf for submit@debbugs.gnu.org; Tue, 13 Jan 2015 13:06:55 -0500 Original-Received: from mail-wi0-f175.google.com ([209.85.212.175]:38968) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YB5rh-00073Y-3o for 19564@debbugs.gnu.org; Tue, 13 Jan 2015 13:06:53 -0500 Original-Received: by mail-wi0-f175.google.com with SMTP id l15so23139726wiw.2 for <19564@debbugs.gnu.org>; Tue, 13 Jan 2015 10:06:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=references:from:to:cc:subject:in-reply-to:date:message-id :mime-version:content-type; bh=h+bm5OnU8JuNkRCNTd3sTK3EZFT9tXpOzMj3lw+IvSs=; b=ss0mXkjYiNVsPaTouhHFBdvG2+Dzc4DKkUOiZEdAmS6qCBLb6OTvSvrFdko9M+yVQi a6yqlR2uqu+pbiQ7pUw+eJi/cBbkTP88SZBAXPD+yKonVtU3dhRe1MXkKW3n4IwwtNtL itqOA7ODx5SCgYCleeC3X2iGSCk+8NAzQeQEN4nM1tdP9DBACaO/ynqNIvSmsDEdKYxK X7GbA1oKYqSooUOuGoZLr77Fg8EvWi/UWM3z+at4UFq6EU02jPiSvloOvaXab2i4HNOQ uweqhD9PYAi31sVrfpiwTEV7UEQWiICIC8T99Jg2iAsE8SQ7MagzP2z7N0rk2CtU/8bx rK8w== X-Received: by 10.194.58.19 with SMTP id m19mr41577414wjq.52.1421172407517; Tue, 13 Jan 2015 10:06:47 -0800 (PST) Original-Received: from dell-14z ([37.163.165.138]) by mx.google.com with ESMTPSA id g2sm18606300wjn.11.2015.01.13.10.06.45 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Tue, 13 Jan 2015 10:06:46 -0800 (PST) In-reply-to: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:98323 Archived-At: Stefan Monnier writes: >>> That doesn't explain to me *why* it needs it. >>> Why does Helm need to know the initarg of a slot? >> Helm needs to know the value of each slot in class to convert it to >> alist. > > But the initarg is not the slot, so that doesn't explain why you need > the initargs? The confusion comes that slot-value as documented should use the quoted slot (i.e 'slot) and oref should use the keyword slot (i.e :slot). As I was using oref in first place, I was converting the quoted slot to the keyword slot (i.e 'slot => :slot) to pass it to oref, but since I use slot-value this is no more needed and I can get rid of this conversion with class-slot-initarg. Note that it seems the documentation should be updated as slot-value support both form for slot ('slot and :slot), and IIRC oref also support both forms, but correct me if I am wrong, I am not sure about this one, I will check. > As exlained in bug#19552, EIEIO's use of namespaces and > internal/external definitions was terribly messy (and it's still far > from ideal), so you were left having to guess whether you were allowed > to use something. Yes I know, fixing all namespaces is good even if it create some annoyances at first for us writing external packages. > Indeed. I can add an obsolete backward-compatible definition to handle > that, but I'd first like to better understand why it was used: maybe it > shouldn't be declared internal after all. As explained above it was just used to convert 'slot to :slot but well, as we can use slot-value... but one may want to use oref and use :slot, so it needs a way to convert this (maybe there is something else though, enlight me). > Files compiled with Emacs-25 are indeed not expected to work on > Emacs-24, Yes you already told me this long time ago. > but the other way should work Yes but it doesn't. > (tho some of the changes in EIEIO aren't backward compatible at their > core, but so far those seemed not to affect existing .elc files), so > if it doesn't please M-x report-emacs-bug, so we can see if/how we can > fix it. Ok I will in next bugreport. Thanks for working on this. -- Thierry Get my Gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 59F29997