From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.devel Subject: Re: package.el dependencies Date: Tue, 03 Feb 2015 06:45:08 +0100 Message-ID: <87mw4veefv.fsf@gmail.com> References: <87wq4dpqib.fsf@gmail.com> <87wq44su8v.fsf@gmail.com> <878ugj7ajz.fsf@gmail.com> <874mr67gjb.fsf@gmail.com> <87oapervqv.fsf@gmail.com> <877fw2kp1y.fsf@gmail.com> <87d25tps2q.fsf@gmail.com> <87egq83veh.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1422942341 1106 80.91.229.3 (3 Feb 2015 05:45:41 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 3 Feb 2015 05:45:41 +0000 (UTC) Cc: Stefan Monnier , emacs-devel To: bruce.connor.am@gmail.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Feb 03 06:45:41 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YIWIu-0006mF-LE for ged-emacs-devel@m.gmane.org; Tue, 03 Feb 2015 06:45:40 +0100 Original-Received: from localhost ([::1]:57846 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIWIt-0002br-Mg for ged-emacs-devel@m.gmane.org; Tue, 03 Feb 2015 00:45:39 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47420) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIWIZ-0002bl-KB for emacs-devel@gnu.org; Tue, 03 Feb 2015 00:45:20 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YIWIV-0001AN-O0 for emacs-devel@gnu.org; Tue, 03 Feb 2015 00:45:19 -0500 Original-Received: from mail-wg0-x229.google.com ([2a00:1450:400c:c00::229]:52968) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIWIV-0001AJ-Ga for emacs-devel@gnu.org; Tue, 03 Feb 2015 00:45:15 -0500 Original-Received: by mail-wg0-f41.google.com with SMTP id a1so42611468wgh.0 for ; Mon, 02 Feb 2015 21:45:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=references:from:to:cc:subject:in-reply-to:date:message-id :mime-version:content-type; bh=QwcjJqf5bX2NMichVn927TYuwqKZU3L3GEFiivT6FcU=; b=rvXs8yHFQQGuEAYfexWilxAaJuwlWEie3WzP5tsB5Jr08Z3322eFxtrDs3gZH9JgFY xg7yDk/FMLFjTQ4MRbDGGj9b0vf+XG/lWR6q3hFwk+G0RfFLmd+gGZqphOlKJ5Xcg4tY 67rZx3BxmpmYozaiTHL2bfWoYfpMp9ZVDglCT5AWYhbiV6AWUlD8RvgiLdZicUocW2IM o2GeJrPl1ElbXxP/mgdxXSY+YEKsChujdrPlSzFE5bFhgPJ/6YUbQ3sLz8koPrg44xbi hHOTt8UvCCV8OHYMYMhutgv7ZB2eGEnJoSU2tNKFk30aDaxHOh0+3sTumlnG/MsLfV80 k6lw== X-Received: by 10.194.110.233 with SMTP id id9mr51676357wjb.136.1422942314859; Mon, 02 Feb 2015 21:45:14 -0800 (PST) Original-Received: from dell-14z ([37.164.47.180]) by mx.google.com with ESMTPSA id qg11sm22857147wic.17.2015.02.02.21.45.12 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 02 Feb 2015 21:45:13 -0800 (PST) In-reply-to: X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c00::229 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:182309 Archived-At: The first thing we have to fix now is package--get-deps, Arthur, yes you are right we should recurse without the 'direct flag, so we should use this version: (defun package--get-deps (pkg &optional only) (let* ((pkg-desc (cadr (assq pkg package-alist))) (direct-deps (cl-loop for p in (package-desc-reqs pkg-desc) for name = (car p) when (assq name package-alist) collect name)) (indirect-deps (unless (eq only 'direct) (cl-loop for p in direct-deps append (package--get-deps p) into lst finally return (delete-dups lst))))) (cl-case only (direct direct-deps) (separate (list direct-deps indirect-deps)) (indirect indirect-deps) (t (append direct-deps indirect-deps))))) Can you push it ? -- Thierry Get my Gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 59F29997