From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Matthew Carter Newsgroups: gmane.emacs.devel Subject: Re: GNU Elpa Theme (ahungry-theme) - should I add code to auto load-theme it? Date: Thu, 05 Feb 2015 12:44:39 -0500 Organization: Ahungry (http://ahungry.com) Message-ID: <87mw4sdzi0.fsf@ahungry.com> References: <87iofo7xfo.fsf@ahungry.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1423158812 26218 80.91.229.3 (5 Feb 2015 17:53:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 5 Feb 2015 17:53:32 +0000 (UTC) Cc: emacs-devel To: Artur Malabarba Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Feb 05 18:53:31 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YJQcL-0005XT-W1 for ged-emacs-devel@m.gmane.org; Thu, 05 Feb 2015 18:53:30 +0100 Original-Received: from localhost ([::1]:43614 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJQcL-0005iX-Hu for ged-emacs-devel@m.gmane.org; Thu, 05 Feb 2015 12:53:29 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51102) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJQTw-0006Hs-I4 for emacs-devel@gnu.org; Thu, 05 Feb 2015 12:44:49 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YJQTq-0005uI-TS for emacs-devel@gnu.org; Thu, 05 Feb 2015 12:44:48 -0500 Original-Received: from li130-200.members.linode.com ([69.164.215.200]:60648 helo=mail.ahungry.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJQTq-0005tt-Qq for emacs-devel@gnu.org; Thu, 05 Feb 2015 12:44:42 -0500 Original-Received: from Prometheus (99-40-9-245.lightspeed.livnmi.sbcglobal.net [99.40.9.245]) by mail.ahungry.com (Postfix) with ESMTPSA id 59153481C; Thu, 5 Feb 2015 12:44:40 -0500 (EST) In-Reply-To: (Artur Malabarba's message of "Fri, 30 Jan 2015 23:57:25 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 69.164.215.200 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:182465 Archived-At: Artur Malabarba writes: >> 1) Add itself to the user's custom-theme-load-path > > Yes. The code is a little tricky, so look into how other themes do it. > >> 2) Load itself via load-theme > > Absolutely not. Users should be able to have multiple themes installed > without them all turning on simultaneously. > > I do agree with need a more intuitive theming experience for new users, but > that's a whole other topic. When investigating further (and testing with a fresh emacs install) I have found that the theme loads without requiring any calls to load-theme or modifying the theme load path when installed via ELPA by including a simple: (require 'ahungry-theme) In the init file, so upon reconsideration I'll probably avoid adding any further autoload functionality in the theme code. The fact that the theme becomes active upon a require isn't unintended functionality is it? Maybe I'll just update the meta description shown on list-packages from: "Ahungry color theme for Emacs." to "Ahungry color theme for Emacs - just (require 'ahungry-theme) to load." -- Matthew Carter (m@ahungry.com) http://ahungry.com