From: Matthew Carter <m@ahungry.com>
To: Artur Malabarba <bruce.connor.am@gmail.com>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: GNU Elpa Theme (ahungry-theme) - should I add code to auto load-theme it?
Date: Thu, 05 Feb 2015 12:44:39 -0500 [thread overview]
Message-ID: <87mw4sdzi0.fsf@ahungry.com> (raw)
In-Reply-To: <CAAdUY-KUybG2qbBzgemuFVf1teCXwOH=oRVdw_=ej-W-GirtNw@mail.gmail.com> (Artur Malabarba's message of "Fri, 30 Jan 2015 23:57:25 +0000")
Artur Malabarba <bruce.connor.am@gmail.com> writes:
>> 1) Add itself to the user's custom-theme-load-path
>
> Yes. The code is a little tricky, so look into how other themes do it.
>
>> 2) Load itself via load-theme
>
> Absolutely not. Users should be able to have multiple themes installed
> without them all turning on simultaneously.
>
> I do agree with need a more intuitive theming experience for new users, but
> that's a whole other topic.
When investigating further (and testing with a fresh emacs install) I
have found that the theme loads without requiring any calls to
load-theme or modifying the theme load path when installed via ELPA by
including a simple:
(require 'ahungry-theme)
In the init file, so upon reconsideration I'll probably avoid adding any
further autoload functionality in the theme code.
The fact that the theme becomes active upon a require isn't unintended
functionality is it?
Maybe I'll just update the meta description shown on list-packages from:
"Ahungry color theme for Emacs."
to
"Ahungry color theme for Emacs - just (require 'ahungry-theme) to load."
--
Matthew Carter (m@ahungry.com)
http://ahungry.com
next prev parent reply other threads:[~2015-02-05 17:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-30 21:47 GNU Elpa Theme (ahungry-theme) - should I add code to auto load-theme it? Matthew Carter
2015-01-30 21:50 ` Dmitry Gutov
2015-01-30 23:57 ` Artur Malabarba
2015-02-05 17:44 ` Matthew Carter [this message]
2015-02-05 19:13 ` Stefan Monnier
2015-02-05 19:58 ` Matthew Carter
2015-02-05 20:48 ` Stefan Monnier
2015-02-05 22:08 ` Artur Malabarba
2015-02-06 4:03 ` Matthew Carter
2015-02-06 8:59 ` Artur Malabarba
2015-02-05 19:31 ` Ivan Shmakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mw4sdzi0.fsf@ahungry.com \
--to=m@ahungry.com \
--cc=bruce.connor.am@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.