From: Juri Linkov <juri@linkov.net>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Bastien <bzg@gnu.org>, 19829@debbugs.gnu.org
Subject: bug#19829: 25.0.50; query-replace in rectangle regions do not honor boundaries
Date: Mon, 23 Feb 2015 21:19:20 +0200 [thread overview]
Message-ID: <87mw44phaf.fsf@mail.linkov.net> (raw)
In-Reply-To: <jwv8uftpp4o.fsf-monnier+emacsbugs@gnu.org> (Stefan Monnier's message of "Thu, 19 Feb 2015 16:29:52 -0500")
>> This is true generally, but query-replace is a very special command.
>> It already does many unorthodox things like putting markers on
>> region boundaries, and then deactivating the mark. What is more,
>> it needs to use rectangle boundaries in isearch-filter-predicate,
>> so lazy-highlight will match only strings it's going to replace.
>
> I don't see how that's relevant: always calling
> extract-rectangle-position should simply work (the normal region is just
> a degenerate form of a special region, which has only one span), at
> least as long as the rectangle case works correctly.
Rewriting the complex function `perform-replace' to work on several
region chunks is not needed because the most suitable way is to use
`isearch-filter-predicate' for this specific case of search/replace.
For all other region-processing commands it makes sense
to process separate chunks of rectangular regions implicitly.
This is why I suggested to do this for any other command, but
I wonder why no one asked yet about doing this for other commands.
next prev parent reply other threads:[~2015-02-23 19:19 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-10 14:58 bug#19829: 25.0.50; query-replace in rectangle regions do not honor boundaries Bastien
2015-02-10 23:40 ` Juri Linkov
2015-02-12 0:57 ` Juri Linkov
2015-02-12 14:33 ` Stefan Monnier
2015-02-13 0:54 ` Juri Linkov
2015-02-14 3:59 ` Stefan Monnier
2015-02-18 18:30 ` Juri Linkov
2015-02-18 22:56 ` Stefan Monnier
2015-02-19 19:12 ` Juri Linkov
2015-02-19 21:29 ` Stefan Monnier
2015-02-23 19:19 ` Juri Linkov [this message]
2015-03-11 20:31 ` Stefan Monnier
2015-03-12 19:19 ` Juri Linkov
2015-03-13 1:04 ` Stefan Monnier
2015-06-30 20:42 ` bug#19829: 25.0.50; Design of commands operating on rectangular regions Juri Linkov
2015-07-01 2:29 ` Stefan Monnier
2015-07-01 22:17 ` Juri Linkov
2015-07-02 3:02 ` Stefan Monnier
2015-07-02 22:40 ` Juri Linkov
2015-07-07 12:20 ` Stefan Monnier
2015-07-07 22:12 ` Juri Linkov
2015-07-07 21:27 ` Richard Stallman
2015-07-07 22:15 ` Juri Linkov
2015-02-19 14:27 ` bug#19829: 25.0.50; query-replace in rectangle regions do not honor boundaries Bastien
2015-11-13 23:32 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mw44phaf.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=19829@debbugs.gnu.org \
--cc=bzg@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.