From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Kyle Meyer <kyle@kyleam.com>
Cc: Org-mode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] org-clone-subtree-with-time-shift: Accept 0 clones
Date: Mon, 22 Jun 2015 10:12:59 +0200 [thread overview]
Message-ID: <87mvzstb3o.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87h9q08pqi.fsf@kmlap.domain.org> (Kyle Meyer's message of "Sun, 21 Jun 2015 22:02:29 -0400")
Hello,
Kyle Meyer <kyle@kyleam.com> writes:
> From 37a917e4f7e4d2c05355735ab08f1f555b9dc942 Mon Sep 17 00:00:00 2001
> From: Kyle Meyer <kyle@kyleam.com>
> Date: Sun, 21 Jun 2015 21:46:54 -0400
> Subject: [PATCH] org-clone-subtree-with-time-shift: Accept 0 clones
Thank you for the patch.
> - (if (not (and (integerp n) (> n 0)))
> + (if (not (and (integerp n) (>= n 0)))
> (user-error "Invalid number of replications %s" n))
Nitpick: (unless (wholenump n) (user-error ...))
Otherwise, looks good.
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2015-06-22 8:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-22 2:02 [PATCH] org-clone-subtree-with-time-shift: Accept 0 clones Kyle Meyer
2015-06-22 8:12 ` Nicolas Goaziou [this message]
2015-06-22 16:50 ` Kyle Meyer
2015-06-22 19:51 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mvzstb3o.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=kyle@kyleam.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.