From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#21432: 25.0.50; file-notify-rm-watch (inotify) errors if watched dir is deleted Date: Mon, 14 Sep 2015 22:23:36 +0200 Message-ID: <87mvwoycl3.fsf@gmx.de> References: <87k2s15sfd.fsf@gnu.org> <83oahc7vxr.fsf@gnu.org> <87lhcgvr1t.fsf@gmx.de> <87r3m4hrfq.fsf@gmx.de> <83fv2jbrkm.fsf@gnu.org> <87zj0rh5lb.fsf@gmx.de> <87h9myt96l.fsf@gmx.de> <87zj0pild7.fsf@gnu.org> <83oah5a35p.fsf@gnu.org> <87vbbdih3w.fsf@gnu.org> <87r3m1igdf.fsf@gnu.org> <837fnt9lup.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1442262264 22345 80.91.229.3 (14 Sep 2015 20:24:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 14 Sep 2015 20:24:24 +0000 (UTC) Cc: 21432@debbugs.gnu.org, Tassilo Horn To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Sep 14 22:24:10 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZbaIM-0007BB-6v for geb-bug-gnu-emacs@m.gmane.org; Mon, 14 Sep 2015 22:24:10 +0200 Original-Received: from localhost ([::1]:43373 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbaIL-0005x0-5f for geb-bug-gnu-emacs@m.gmane.org; Mon, 14 Sep 2015 16:24:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44284) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbaIH-0005wM-Hv for bug-gnu-emacs@gnu.org; Mon, 14 Sep 2015 16:24:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZbaIE-0002LL-Ey for bug-gnu-emacs@gnu.org; Mon, 14 Sep 2015 16:24:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:40159) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbaIE-0002LH-CT for bug-gnu-emacs@gnu.org; Mon, 14 Sep 2015 16:24:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZbaIE-0001H6-5Q for bug-gnu-emacs@gnu.org; Mon, 14 Sep 2015 16:24:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 14 Sep 2015 20:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21432 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21432-submit@debbugs.gnu.org id=B21432.14422622214869 (code B ref 21432); Mon, 14 Sep 2015 20:24:02 +0000 Original-Received: (at 21432) by debbugs.gnu.org; 14 Sep 2015 20:23:41 +0000 Original-Received: from localhost ([127.0.0.1]:60602 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZbaHs-0001GT-Up for submit@debbugs.gnu.org; Mon, 14 Sep 2015 16:23:41 -0400 Original-Received: from mout.gmx.net ([212.227.15.18]:53069) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZbaHq-0001GL-VE for 21432@debbugs.gnu.org; Mon, 14 Sep 2015 16:23:39 -0400 Original-Received: from detlef.gmx.de ([87.146.33.99]) by mail.gmx.com (mrgmx003) with ESMTPSA (Nemesis) id 0Le5XQ-1YqOVp2wai-00pvmF; Mon, 14 Sep 2015 22:23:37 +0200 In-Reply-To: <837fnt9lup.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 14 Sep 2015 16:22:38 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-Provags-ID: V03:K0:6vx+/kCw9nJQwh4y6YZcildutiAw+Mjxl8yvP0QYEpeqC8kblnr QaFrdIDoZyNpUacqfSsbj3kBtnrZtrMrD43jJXdbf0UwVAqFBQSxN9uNVIzMKTgYgNQwO/8 QaSeOnS0upt+STtkUIFyEkdrruQyNXGdg5YLItv+LDJ/rVF/0N+mvBFqUhgDRnl5Fj0A3d4 3y3EkEfOGzd3eYZYQoiXA== X-UI-Out-Filterresults: notjunk:1;V01:K0:kBJGOlI2NUg=:p1l76Gl+2JM56J0p0pVDZu fWwm7/n0/Pmjnz+VMhtkAH3E+3o3KvDTwIPry4V0/iTaonbX38g4RW/dKdEoDp4hQSOMDbIvA BcMRyS/iIBKWk2pUAkBPjdb4fxdpubKZ3UsicJXEwR/HngFxsH5BeFb8PN6Tz8AxoingBsevN pMNA2eSUDUd0mGblwY2W2wYL11G2a1rKviUC8zYhALTxJ7ve3Ju8VvFjEGa0nmKYh9y7v0Q45 LNOWnvIJWkKhCs0bX5ejJ3n7qr4go+t8HU4/0W266DbZwtlLYGOrL1sGByyfMqcbpYvXOOQCY ixe2NwWejc3FqSYr6xDk0WhQRN5GyKUePh7a2uPUcX22uXElm5F6xDfmP/637rJlylJPnGw4t yV5LUhB60QKRxEQreheQKgl7bti0mIl3H9cxyU0gwozagAT7fjPGUhu5j9GWToq245VXSLFZD qOBZ4yGVS9eOUcuDI7C4v4BjGGNJJL/vnPd9Obh3q/cSnkOiz60OxPA6PojmXRZv21AAevLUX GxxbSy/lCSw/odApMB/H3K2i9fpoMhpCDqaEIHbPjvMeXWrQIEaTxVNHmU3EL7HXJIgH30Pxm /2PJcs4cnOun17BNMFAWHYwye2ecRpirepltPl/lsVkSF8/ncw4LIl+rp2sl/4KaaGDNj/Hqb dL9Osiyw9Iu9GaiZjIop/Di0m2z1XYNBI5wnS3ySBsf5rTN/asPZ+2oZwvPGWRMUBfyjl+DDq ruyWj7YpSYqjdbqkoqAjq/KoVAEaGXI5q/hiXQ== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:106553 Archived-At: Eli Zaretskii writes: > No, I think it's a problem with our mental model of what happens. The > file notifications use the Emacs event loop, and Emacs won't check for > events until it's idle. So calling file-notify-valid-p as part of the > test ends up doing that _before_ the directory deletion notification > is read by Emacs and invalidates the watch. I actually see the > message saying the watch is valid before the notification comes in and > its message is inserted into *Messages*. > > Try something similar with inotify and see if you see the same basic > issue. If you do, I trust you will think of a way to modify the tests > so that validation does do its thing. I've adapted `file-notify-test04-file-validity' and `file-notify-test05-dir-validity', and they pass the tests now for the inotify case. Hopefully, it is the same for w32notify. Implementation for gfilenotify and Tramp will follow. While being there, I have made also `file-notify-rm-watch' more robust by ignoring all `file-notify-error's. This was the initial trigger for bug#21432. Best regards, Michael.