From: Michael Albinus <michael.albinus@gmx.de>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 21432@debbugs.gnu.org, Tassilo Horn <tsdh@gnu.org>
Subject: bug#21432: 25.0.50; file-notify-rm-watch (inotify) errors if watched dir is deleted
Date: Mon, 14 Sep 2015 22:23:36 +0200 [thread overview]
Message-ID: <87mvwoycl3.fsf@gmx.de> (raw)
In-Reply-To: <837fnt9lup.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 14 Sep 2015 16:22:38 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
> No, I think it's a problem with our mental model of what happens. The
> file notifications use the Emacs event loop, and Emacs won't check for
> events until it's idle. So calling file-notify-valid-p as part of the
> test ends up doing that _before_ the directory deletion notification
> is read by Emacs and invalidates the watch. I actually see the
> message saying the watch is valid before the notification comes in and
> its message is inserted into *Messages*.
>
> Try something similar with inotify and see if you see the same basic
> issue. If you do, I trust you will think of a way to modify the tests
> so that validation does do its thing.
I've adapted `file-notify-test04-file-validity' and
`file-notify-test05-dir-validity', and they pass the tests now for the
inotify case. Hopefully, it is the same for w32notify.
Implementation for gfilenotify and Tramp will follow.
While being there, I have made also `file-notify-rm-watch' more robust
by ignoring all `file-notify-error's. This was the initial trigger for
bug#21432.
Best regards, Michael.
next prev parent reply other threads:[~2015-09-14 20:23 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-08 6:36 bug#21432: 25.0.50; file-notify-rm-watch (inotify) errors if watched dir is deleted Tassilo Horn
2015-09-08 7:47 ` Michael Albinus
2015-09-08 8:11 ` Tassilo Horn
2015-09-08 15:51 ` Eli Zaretskii
2015-09-08 15:49 ` Eli Zaretskii
2015-09-08 16:01 ` Michael Albinus
2015-09-12 10:18 ` Michael Albinus
2015-09-12 15:11 ` Eli Zaretskii
2015-09-12 18:09 ` Michael Albinus
2015-09-13 19:23 ` Michael Albinus
2015-09-14 6:08 ` Tassilo Horn
2015-09-14 7:08 ` Eli Zaretskii
2015-09-14 7:40 ` Tassilo Horn
2015-09-14 7:56 ` Tassilo Horn
2015-09-14 13:22 ` Eli Zaretskii
2015-09-14 20:23 ` Michael Albinus [this message]
2015-09-15 7:38 ` Eli Zaretskii
2015-09-15 8:00 ` Michael Albinus
2015-09-15 8:22 ` Eli Zaretskii
2015-09-15 11:54 ` Michael Albinus
2015-09-15 12:51 ` Eli Zaretskii
2015-09-15 12:56 ` Michael Albinus
2015-09-16 14:45 ` Michael Albinus
2015-09-16 17:08 ` Eli Zaretskii
2015-09-16 17:26 ` Michael Albinus
2015-09-16 17:55 ` Eli Zaretskii
2015-09-16 18:28 ` Michael Albinus
2015-09-15 5:53 ` Tassilo Horn
2015-09-14 7:35 ` Eli Zaretskii
2015-09-14 7:37 ` Michael Albinus
2015-09-15 13:02 ` Michael Albinus
2015-09-15 13:56 ` Eli Zaretskii
2015-09-16 13:54 ` Michael Albinus
2015-09-20 17:23 ` Michael Albinus
2015-09-20 19:19 ` Eli Zaretskii
2015-09-21 13:40 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mvwoycl3.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=21432@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=tsdh@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.