From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#21435: 25.0.50; file-notify has problems after renames Date: Mon, 21 Sep 2015 08:25:58 +0200 Message-ID: <87mvwge1ah.fsf@gmx.de> References: <87y4gh47sr.fsf@gnu.org> <878u81ngsi.fsf@gmx.de> <83y4g0opc2.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1442816849 11655 80.91.229.3 (21 Sep 2015 06:27:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 21 Sep 2015 06:27:29 +0000 (UTC) Cc: 21435@debbugs.gnu.org, tsdh@gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Sep 21 08:27:13 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZduZE-0001Yk-Ij for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 Sep 2015 08:27:12 +0200 Original-Received: from localhost ([::1]:55896 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZduZD-0007qE-EV for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 Sep 2015 02:27:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52663) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZduZ9-0007q7-QB for bug-gnu-emacs@gnu.org; Mon, 21 Sep 2015 02:27:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZduZ4-00060V-Nh for bug-gnu-emacs@gnu.org; Mon, 21 Sep 2015 02:27:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:47197) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZduZ4-00060P-Kc for bug-gnu-emacs@gnu.org; Mon, 21 Sep 2015 02:27:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZduZ4-00008X-2x for bug-gnu-emacs@gnu.org; Mon, 21 Sep 2015 02:27:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 Sep 2015 06:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21435 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21435-submit@debbugs.gnu.org id=B21435.1442816765457 (code B ref 21435); Mon, 21 Sep 2015 06:27:02 +0000 Original-Received: (at 21435) by debbugs.gnu.org; 21 Sep 2015 06:26:05 +0000 Original-Received: from localhost ([127.0.0.1]:39407 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZduY8-00007H-5o for submit@debbugs.gnu.org; Mon, 21 Sep 2015 02:26:04 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:54974) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZduY5-00006s-QR for 21435@debbugs.gnu.org; Mon, 21 Sep 2015 02:26:02 -0400 Original-Received: from detlef.gmx.de ([87.146.36.207]) by mail.gmx.com (mrgmx101) with ESMTPSA (Nemesis) id 0MYsEZ-1Z8L1Y1kyx-00VkQU; Mon, 21 Sep 2015 08:25:59 +0200 In-Reply-To: <83y4g0opc2.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 20 Sep 2015 22:36:29 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-Provags-ID: V03:K0:NT6+Saujvb0qffFN5l5dLvEaVfTxfxLPu0UAu4MohKTEbocYYCl h+zOvNTybXvPv5zvVh9+6zA/+jEjG+rzem1X86ZB5DK2GR0NqvMGry65X8tY3XFRca91NLV Owqf4XXW2OOKykVsPhh72EhjR5HZZLtIljbiCoRtMR0xJ+pXz/fwUGU4lqrHdsj8I/Vn6o9 qyGcDO2rKYq26qltbPA4A== X-UI-Out-Filterresults: notjunk:1;V01:K0:Lb/Xv1pag2U=:lxCP+Pq42lTIzAR8DfmO3J mGGoCiodP2JkXOHjTNUG+MAG24WSeuQT8wMXK1PUcEaqdgrCYZ5J0FY8DFw9WUmipAylGHxTn 4NFyv3AlSCLcm7s50/h6iqQK3ZMGzUB+sIwhY/Wy9Y79ai6/Hf03ERc1Wup1GXbwYfIkcNOti tE8s+lu9Bj8cse72P2mJFTQJ0sWixQRp9XzJzcU3hYRUyFwUYoBC+/usIAbgxjJbrYwEyonfe vRFBu0BzI9FMAYDaufi9fpr3/05tqNZbpW/yJ807+WH3qJyq41ElHFxU5tKCUl0p/24nqFIYo natUWoEI0T22kWcKMBI5Lgb6r/ZtOzyiQp00ZJmrh/cNlQ/8z6VcU088wWiz0KY1bPvFq0Wj7 xn4pKKPnB3J0vU320pyfmiatjFJ0/AoxI8EknOaCNMCKblz1pB1IzYUpEQvuEjqHjSqF1cb2X ThwhxPwk+NPlsHu0iLTSsCUF9K2vtioU01zegsdfBcicURhGl4b+98A5ODmqqkboyVyCeGXzQ x45KJzYa3C+18yG1E5mGQoxXyFzCwusqN9K802A9hcLYI3qO+c6buFMO9lWFjNZ057EiPxbMr 5P4iXXJGyYhRdrZL7eEbGXF2LmPFb7sBEZ7yjKuSYf9yPs7Kgv1RrSfZDxET1LWOAb62+ZhxI xt4LFsaJKuHTj++E6maFmyKaV7mzAt/UQwHe93o8Mbu/JrnI9S9tA5W54ePXADZTqhqOq/UEK Z2Pra3wkS5egKh06a1j2rrOd6M3whQ+qZFWu2w== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:106758 Archived-At: Eli Zaretskii writes: Hi Eli, > w32notify reports 2 changed events in a row: > > Test file-notify-test02-events condition: > (ert-test-failed > ((should > (equal '... > (mapcar ... events))) > :form > (equal > (created changed deleted) > (created changed changed deleted)) > :value nil :explanation > (proper-lists-of-different-length 3 4 > (created changed deleted) > (created changed changed deleted) > first-mismatch-at 2))) > > This is the "copy" part of the test. Interestingly, sometimes there > are 2 separate "changed" events and sometimes only 1. Does > filenotify.el try to conflate several consecutive events of the same > kind into one? In any case, I guess we will have to allow either one > or 2 "changed" events there. No, filenotify.el handles them as they are. The only change in the event flow is, when two consecutive deleted+created events are combined to a renamed event. However, as said I have extended the test case a little bit. There are now set-file-times and set-file-modes calls, which shall result in attribute-changed events. And those events shall be suppressed, because we start file notifications with (file-notify-add-watch ... '(change) ...) How does w32notify report attribute changes? Could you, please, call (trace-output 'file-notify-handle-event) and rerun file-notify-test02-events? Best regards, Michael.