From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#21562: 24.5; Copy dir via Tramp pscp does not work Date: Fri, 02 Oct 2015 19:59:21 +0200 Message-ID: <87mvw1rw1y.fsf@gmx.de> References: <878u7tk0bm.fsf@gmx.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1443809664 10716 80.91.229.3 (2 Oct 2015 18:14:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 2 Oct 2015 18:14:24 +0000 (UTC) Cc: 21562@debbugs.gnu.org To: Warren Lynn Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Oct 02 20:14:14 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Zi4qQ-0006KE-26 for geb-bug-gnu-emacs@m.gmane.org; Fri, 02 Oct 2015 20:14:10 +0200 Original-Received: from localhost ([::1]:34280 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zi4qP-0007ym-FR for geb-bug-gnu-emacs@m.gmane.org; Fri, 02 Oct 2015 14:14:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37669) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zi4ct-0006Gy-DK for bug-gnu-emacs@gnu.org; Fri, 02 Oct 2015 14:00:16 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zi4cp-0001LQ-6G for bug-gnu-emacs@gnu.org; Fri, 02 Oct 2015 14:00:11 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35181) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zi4co-0001K4-Uc for bug-gnu-emacs@gnu.org; Fri, 02 Oct 2015 14:00:07 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Zi4co-0004Dz-By for bug-gnu-emacs@gnu.org; Fri, 02 Oct 2015 14:00:06 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 02 Oct 2015 18:00:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21562 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 21562-submit@debbugs.gnu.org id=B21562.144380876616149 (code B ref 21562); Fri, 02 Oct 2015 18:00:05 +0000 Original-Received: (at 21562) by debbugs.gnu.org; 2 Oct 2015 17:59:26 +0000 Original-Received: from localhost ([127.0.0.1]:52382 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zi4c9-0004CO-GO for submit@debbugs.gnu.org; Fri, 02 Oct 2015 13:59:25 -0400 Original-Received: from mout.gmx.net ([212.227.15.18]:57130) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zi4c7-0004CG-Kp for 21562@debbugs.gnu.org; Fri, 02 Oct 2015 13:59:24 -0400 Original-Received: from detlef.gmx.de ([87.146.40.216]) by mail.gmx.com (mrgmx001) with ESMTPSA (Nemesis) id 0MMkDH-1Ziv9Z0P79-008YOY; Fri, 02 Oct 2015 19:59:22 +0200 In-Reply-To: (Warren Lynn's message of "Fri, 2 Oct 2015 12:16:29 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-Provags-ID: V03:K0:403gugqN+g3mGvspABhDlHAWWP1MyGLvPDj4yvZNnShTF5PO5Jf blYM2y/akOp/vNTf1RSR6NtA5aDYJ2TP79+rQdbHOIJnJglUBnCLB1FBM+mDl6FUfQbGn3N sbR2KTvPyN54dvy0gWKhbPcnBYTrH8k/ekv1hZ2xc5N3/LG4nnwho1BvoPkoimyNAaLky9Y o/C0cUVFzPPAW44ZDf+JQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:1EvHpsz5z4o=:vzy8invmZRniOPrOqg39Wp uqR8TWFUxv8NNF07dvk33CNN7JtDLZRKV5FThil9uoNQm2R26wK1EI1laruRVULdECdWGXKVY OayMgMQqVGXW1HzCgWpQKRe66wkLGVhG4i/QIfUhe4QcQJ4gMH1PjvKIlM0OUfXWshS1nxS5V BE1ZDh+34IQtSN4GGD0dVQUTXRhtjjeR26Ta4eAt+0nagFUCtS1XZDfk/YaN0KMOgEChxfjir GZX11lHjIv2SfY4mUVLc1/rAUetAJd23GDmIFSDRL8MnguS0dhtwrvlFXq4DCnuJ7F0XF4FbD PPFfQPbnf09PLMHMVeiBG9q+7yE/ymYDvg3XYc+vRiX58KcYGwbaTL/j0SMeOxzfQz94e10eC 9FklIVOee2EcA0lI5qIKLHPDQZlrkCY2vG0DHagzxD/46GPs8xBD7qJRKOFQRLyL+XhvqqTLX WDaOKfj6fxVXSj3+aHhUhZXyphnGhs0cl/lCnTo4G0z7wb+Lb+dk/sF19tZYAB+tp1Uq83C5s KdrxVA1X5P0v5wDI4e038+5Ib1pfiArlNUPmsrOQDQZeZA0gXJkT/qTnZ8hgzc0uFr1MMkdtg o/MdXf7J0DxgnrHqMSOtUVa9VwvAWfglI2fTMuNew3qgIEQKuB+JcC40m/mdOXe/k7U4y+jiM yLhRXiXadnmAILURaeFY0lHlAoZiHrF/Bs/XT+73BmvTKBF0JmQZYW7KsHMxfZiNs1tze3/1S DHgLwaKSDUTWPPDX9/FwBKv1qRR5KP4+5CK7X7z8twGmpP3DGwj7Fh0RtXP/QDmp/XPLxCo8 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:107222 Archived-At: Warren Lynn writes: Hi Warren, > Actually, things were more broken than I thought. The original code > did not handle correctly directory copy from local to remote either. > The reason is function > tramp-make-copy-program-file-name > already quotes the target, and then shell-quote-argument quotes the > target again, so we get double quotes. > > I attached a second patch to fix both copying dir from local to > remote, or remote to local. However, I am not so sure if this is a > completely correct fix as I don't know much about the "multi-hop" > thing. Anyway, hope this can serve as a starting point for the > ultimate proper fix. Thanks for your investigations. I've applied your patch to recent Tramp sources, and the Tramp test suite still passes all expected tests. That's good, but it's with a local Ubuntu stanza. Since I don't use MS Windows, I cannot check it for your case. Could you, please run the test suite, preferred with and without your patch. You could do this like this (untested): set REMOTE_TEMPORARY_FILE_DIRECTORY=/pscp:user@host:/tmp "C:\Program Files\emacs-24.5\bin\emacs.exe" -Q -batch -l "C:\Program Files\emacs-24.5\test\automated\tramp-tests.el" -f ert-run-tests-batch-and-exit Of course, you must adapt some paths in this example. Since nobody has reported such a problem yet, I suspect that your use case is not covered yet by the Tramp tests. Could you please describe exactly, what and how you have tried to copy, especially source and target paths? I would like to get this problem reproducible. Well, for this I need to hijack the laptop of my wife :-) > BTW, all the above works out of box on Emacs 23.3. > > To be honest, I am quite disappointed with Emacs recent (last 2 or 3 > years) release quality. Seems some convoluted low-quality code was > checked in the first place, and then not enough testing was done > before release. Don't know if I have any right to complain in the > first place as I am not an active developer here. But I would hate to > see my favorite editor Emacs going down this path further. I cannot speak for Emacs in general. But none of the Tramp contributors uses MS Windows locally, as far as I am aware of. If there won't be any volunteer for testing this, we cannot expect a better quality. Additionally, the Tramp tests on MS Windows require special settings (see %REMOTE_TEMPORARY_FILE_DIRECTORY% I've shown above). I have no idea how we could establish a mockup Tramp connection method for testing, as we have done it for local unixoid systems. Best regards, Michael. PS: Starting on Monday, I'll be offline for about a week.