From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Newsgroups: gmane.emacs.bugs Subject: bug#21638: 25.0.50; font-lock for CSS variables Date: Tue, 06 Oct 2015 21:24:53 +0200 Message-ID: <87mvvvkdfe.fsf@gmail.com> References: <87twq3ev7w.fsf@tromey.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1444160125 26667 80.91.229.3 (6 Oct 2015 19:35:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 6 Oct 2015 19:35:25 +0000 (UTC) Cc: 21638@debbugs.gnu.org, monnier@iro.umontreal.ca To: Tom Tromey Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 06 21:35:13 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from eggs.gnu.org ([208.118.235.92]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZjY12-0007y9-2t for geb-bug-gnu-emacs@m.gmane.org; Tue, 06 Oct 2015 21:35:12 +0200 Original-Received: from lists.gnu.org ([208.118.235.17]:32788) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjY11-0007aM-0j for geb-bug-gnu-emacs@m.gmane.org; Tue, 06 Oct 2015 15:35:11 -0400 Original-Received: from localhost ([::1]:53418 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjY10-0004Ka-Ho for geb-bug-gnu-emacs@m.gmane.org; Tue, 06 Oct 2015 15:35:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44218) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjXsE-0007qM-M2 for bug-gnu-emacs@gnu.org; Tue, 06 Oct 2015 15:26:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZjXsB-000391-81 for bug-gnu-emacs@gnu.org; Tue, 06 Oct 2015 15:26:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:40169) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjXsA-00036a-L9 for bug-gnu-emacs@gnu.org; Tue, 06 Oct 2015 15:26:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZjXsA-0002iF-E7 for bug-gnu-emacs@gnu.org; Tue, 06 Oct 2015 15:26:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Oct 2015 19:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21638 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21638-submit@debbugs.gnu.org id=B21638.144415951910315 (code B ref 21638); Tue, 06 Oct 2015 19:26:02 +0000 Original-Received: (at 21638) by debbugs.gnu.org; 6 Oct 2015 19:25:19 +0000 Original-Received: from localhost ([127.0.0.1]:57373 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZjXrS-0002gG-6C for submit@debbugs.gnu.org; Tue, 06 Oct 2015 15:25:19 -0400 Original-Received: from mail-lb0-f180.google.com ([209.85.217.180]:34890) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZjXr6-0002eL-Ex for 21638@debbugs.gnu.org; Tue, 06 Oct 2015 15:25:16 -0400 Original-Received: by lbwr8 with SMTP id r8so82198139lbw.2 for <21638@debbugs.gnu.org>; Tue, 06 Oct 2015 12:24:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=oMANvAnzoRnsjb45EdqZaMG6d+hzFTcYQHmHt4kC3KI=; b=Ga2dNn4gGwNCT63XRXjCGv8OhtL7dK5cKm0kToAqcBtNbNqHmerJV9VwXZBJ7N/OkZ qj+iFZ/6uc3Z0HHTwufDkYxqist+mfhFpTQZLt22Ekdx4cVkWBClPwjfFEYt6H5cpeU0 Ym099WzgdA/a68KlLUAlxXkK+cZfLF+GR8AgBmlEnK2Vllr8mBlFQ+PdFICEJWCc4hj9 hYd2mcjiqHVv7d6VCXMjkAbBCcd8Ne5Hgs4/cxTu3DBSZE3NADBJ0ok9BeE83/emnXAC GkdrSysVH69qcn8jH+6FQBDtL0hic4RitQ81MYFsiDVdDqQ8MjBPpSYWqcfd2B4+4Gro 3pDg== X-Received: by 10.25.212.2 with SMTP id l2mr3541679lfg.118.1444159495432; Tue, 06 Oct 2015 12:24:55 -0700 (PDT) Original-Received: from x240 (cm-84.210.143.4.getinternet.no. [84.210.143.4]) by smtp.gmail.com with ESMTPSA id b193sm5610964lfb.46.2015.10.06.12.24.53 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Oct 2015 12:24:54 -0700 (PDT) In-Reply-To: <87twq3ev7w.fsf@tromey.com> (Tom Tromey's message of "Tue, 06 Oct 2015 11:57:07 -0600") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x Xref: news.gmane.org gmane.emacs.bugs:107386 Archived-At: Tom Tromey writes: > Right now CSS mode doesn't treat CSS variable definitions as > properties. I think it should. > > Here's the patch that worked for me: > > [...] > > Tom Hi Tom! Good idea. The patch seems to do the job, but it also has the side effect that '---foo', '----foo' and so on are recognized as properties. Putting it instead at the start of 'css-nmstart-re' seems to fix that: diff --git a/lisp/textmodes/css-mode.el b/lisp/textmodes/css-mode.el index 5f4eebd..3e84b43 100644 --- a/lisp/textmodes/css-mode.el +++ b/lisp/textmodes/css-mode.el @@ -215,7 +215,7 @@ (defconst css-escapes-re "\\\\\\(?:[^\000-\037\177]\\|[0-9a-fA-F]+[ \n\t\r\f]?\\)") (defconst css-nmchar-re (concat "\\(?:[-[:alnum:]]\\|" css-escapes-re "\\)")) -(defconst css-nmstart-re (concat "\\(?:[[:alpha:]]\\|" css-escapes-re "\\)")) +(defconst css-nmstart-re (concat "\\(?:--\\)?\\(?:[[:alpha:]]\\|" css-escapes-re "\\)")) (defconst css-ident-re ;; (concat css-nmstart-re css-nmchar-re "*") ;; Apparently, "at rules" names can start with a dash, e.g. @-moz-keyframes. (concat css-nmchar-re "+")) Though I'm unsure what 'css-nmstart-re' is intended to contain, since it's missing a docstring. Maybe Stefan knows? -- Simen