From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#22591: 25.0.50; [PATCH] imagemagick orientation EXIF tag is respected Date: Wed, 10 Feb 2016 15:40:25 +1100 Message-ID: <87mvr9i3eu.fsf@gnus.org> References: <87a8nc2ksw.fsf@secretsauce.net> <8737t2lh5y.fsf@gnus.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1455079347 24337 80.91.229.3 (10 Feb 2016 04:42:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 10 Feb 2016 04:42:27 +0000 (UTC) Cc: 22591@debbugs.gnu.org To: Dima Kogan Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Feb 10 05:42:15 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aTMbV-0002SZ-VA for geb-bug-gnu-emacs@m.gmane.org; Wed, 10 Feb 2016 05:42:14 +0100 Original-Received: from localhost ([::1]:35504 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTMbV-0006IY-5X for geb-bug-gnu-emacs@m.gmane.org; Tue, 09 Feb 2016 23:42:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56355) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTMbO-0006IF-JB for bug-gnu-emacs@gnu.org; Tue, 09 Feb 2016 23:42:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aTMbK-0004rQ-Io for bug-gnu-emacs@gnu.org; Tue, 09 Feb 2016 23:42:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:53225) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTMbK-0004rM-Fa for bug-gnu-emacs@gnu.org; Tue, 09 Feb 2016 23:42:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aTMbK-0005gM-3Y for bug-gnu-emacs@gnu.org; Tue, 09 Feb 2016 23:42:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Feb 2016 04:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22591 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 22591-submit@debbugs.gnu.org id=B22591.145507926521778 (code B ref 22591); Wed, 10 Feb 2016 04:42:02 +0000 Original-Received: (at 22591) by debbugs.gnu.org; 10 Feb 2016 04:41:05 +0000 Original-Received: from localhost ([127.0.0.1]:34133 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aTMaM-0005f0-34 for submit@debbugs.gnu.org; Tue, 09 Feb 2016 23:41:05 -0500 Original-Received: from hermes.netfonds.no ([80.91.224.195]:38651) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aTMaH-0005eZ-0K for 22591@debbugs.gnu.org; Tue, 09 Feb 2016 23:41:00 -0500 Original-Received: from cpe-60-225-211-161.nsw.bigpond.net.au ([60.225.211.161] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aTMZr-0008DP-P2; Wed, 10 Feb 2016 05:40:32 +0100 In-Reply-To: <8737t2lh5y.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 09 Feb 2016 14:02:49 +1100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-MailScanner-ID: 1aTMZr-0008DP-P2 MailScanner-NULL-Check: 1455684032.585@dwRHSOGIW6Uro9Z2NAbMWQ X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:112845 Archived-At: Lars Ingebrigtsen writes: > Dima Kogan writes: > >> Hi. Here are two small patches to improve handling of images loaded with >> the imagemagick backend. They are: >> >> 1. Accept integer :rotation parameters. Previously only floating-point >> ones worked >> >> 2. If an EXIF orientation tag exists and no explicit :rotation exists, >> use the orientation. This happens early in the processing, so all the >> data (width, height, etc) that emacs sees applies to the rotated image. >> >> The motivation for this was that I was tired of seeing upside-down >> photos in my mu4e mail. > > Looks good. I wonder whether this should go in the trunk, though? It's > a new feature of sorts. But we could consider not showing images > correctly rotated a bug... I applied it to emacs-25. Not respecting EXIF rotations is kinda a bug. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no