From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: master 326fff4: Improve w32notify notifications Date: Sat, 19 Mar 2016 16:11:30 +0100 Message-ID: <87mvpu33kt.fsf@gmx.de> References: <20160319124618.27869.30424@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1458400311 19949 80.91.229.3 (19 Mar 2016 15:11:51 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 19 Mar 2016 15:11:51 +0000 (UTC) Cc: emacs-devel@gnu.org To: Fabrice Popineau Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Mar 19 16:11:42 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ahIXT-0002OY-Uo for ged-emacs-devel@m.gmane.org; Sat, 19 Mar 2016 16:11:40 +0100 Original-Received: from localhost ([::1]:49184 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ahIXT-0003gB-Em for ged-emacs-devel@m.gmane.org; Sat, 19 Mar 2016 11:11:39 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37037) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ahIXQ-0003g5-GA for emacs-devel@gnu.org; Sat, 19 Mar 2016 11:11:37 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ahIXN-0004T1-4Y for emacs-devel@gnu.org; Sat, 19 Mar 2016 11:11:36 -0400 Original-Received: from mout.gmx.net ([212.227.17.21]:59571) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ahIXM-0004SY-Ri for emacs-devel@gnu.org; Sat, 19 Mar 2016 11:11:33 -0400 Original-Received: from detlef.gmx.de ([79.195.13.135]) by mail.gmx.com (mrgmx103) with ESMTPSA (Nemesis) id 0LhwAY-1a4NDF1gTC-00n7RU; Sat, 19 Mar 2016 16:11:31 +0100 In-Reply-To: (Eli Zaretskii's message of "Sat, 19 Mar 2016 12:46:18 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-Provags-ID: V03:K0:v9AMfWVrdW0NAaGrOOfqAjM2HkGfWTSe8689opFX1m83e9KBN7e in+hBNGTYORoXrFLlJubjNQbpSOhUr+RcHS/ui6R4zlef0VimKwQ+UHVsONTqRvtc3s8U1O y55+8cQsjT0r8H10MW0Tn2Nb07Mk2W6hzNaffLu9zfic7l9yBAD6by9XKb5TZSUt/VHQc9T P202a0/ZF+24dgq2Z42rg== X-UI-Out-Filterresults: notjunk:1;V01:K0:YvE91NYbmco=:4DL4V1xbuxYWrRBb+Ftcl4 kZC4+qBDwIASXGpRtmxwa0g6+/T9z7u51/a9y9e9ShYQyywVD9AkqUYTIRvE99p78EtS4yvyy F1TleHqnmKhU0oXrLkrsYuTj9ITaHr5sswDFNmiBZGn6qFYec5m6+WQtNPZQyNMlJUYtwhqpp jNXPScR+izrV4aORtr5AT57U8Xw0zQol752AEE2thCKrEHoHE+gEChgnspq/LaELfTzskHDJu dU1u0uCigjhP/8Zy31B8ItSZQz6ZI9VpZ5eyyZDYEfS5UWj941bDhSGrTnycsVt4tBcWFmqri u+WCoAhjbAr4OkVRqjsvzj+yz45+ptFZMMJ49NjWW375GTQMmA0KfP7bAHWYRwWQr+ADT9vAP m3oN01fN0++xr4Ga2zVzjP5E+4gLnzMWQKKBLiEudlJSV8YSWpMw/ES/kuJlDLA2waUGlnF6G 8223q3pFnXsyGs8tEOSxfOpgdRQTf6XqiyPrbrHHKTIVQwXlXDl7Zn5Dji/SBcOF4oPcAgLz2 Hcqdih7h5dEqJzTdvxQfHxHE2H5B0vTu/5U3yiFFoc9/av8s1+ya3Aq8MmPnrXeILxxerhwPb LST05Nn1mOmOCZXOXIfvxOI+PvNwVc1q7rIBQbjMi63XFuMSVAgaU9rHUyYaTzySbJZ+2SSGe vZrNLA1HOS0SyziIIR0q6tc2lDU0jII6MNZC0IWIjlbitmeL++hHwl/fflpPjCwLgwpB/Fsh7 PBUtbrTbYDsqm4a6pF4x7+2sxv2TJJG8ErhQG60DZ6yQ5WSW6uW09CKcJtoq3VDPnIcl9mm+ X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.17.21 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:201866 Archived-At: Hi Fabrice, > diff --git a/test/lisp/filenotify-tests.el b/test/lisp/filenotify-tests.el > index d3610f0..3908894 100644 > --- a/test/lisp/filenotify-tests.el > +++ b/test/lisp/filenotify-tests.el > @@ -754,7 +757,9 @@ longer than timeout seconds for the events to be delivered." > (should (file-notify-valid-p file-notify--test-desc)) > ;; After removing the watch, the descriptor must not be valid > ;; anymore. > + (read-event nil nil file-notify--test-read-event-timeout) > (file-notify-rm-watch file-notify--test-desc) > + (read-event nil nil file-notify--test-read-event-timeout) > (file-notify--wait-for-events > (file-notify--test-timeout) > (not (file-notify-valid-p file-notify--test-desc))) > @@ -776,7 +781,9 @@ longer than timeout seconds for the events to be delivered." > (should (file-notify-valid-p file-notify--test-desc)) > ;; After deleting the directory, the descriptor must not be > ;; valid anymore. > + (read-event nil nil file-notify--test-read-event-timeout) > (delete-directory file-notify--test-tmpfile t) > + (read-event nil nil file-notify--test-read-event-timeout) > (file-notify--wait-for-events > (file-notify--test-timeout) > (not (file-notify-valid-p file-notify--test-desc))) I'm curious why you need the additional `read-event' calls. The following `file-notify--wait-for-events' loops until the condition is satisfied, calling `read-event' every iteration. Best regards, Michael.