From: Michael Albinus <michael.albinus@gmx.de>
To: Fabrice Popineau <fabrice.popineau@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: master 326fff4: Improve w32notify notifications
Date: Sat, 19 Mar 2016 16:11:30 +0100 [thread overview]
Message-ID: <87mvpu33kt.fsf@gmx.de> (raw)
In-Reply-To: <E1ahGGo-0007GB-7z@vcs.savannah.gnu.org> (Eli Zaretskii's message of "Sat, 19 Mar 2016 12:46:18 +0000")
Hi Fabrice,
> diff --git a/test/lisp/filenotify-tests.el b/test/lisp/filenotify-tests.el
> index d3610f0..3908894 100644
> --- a/test/lisp/filenotify-tests.el
> +++ b/test/lisp/filenotify-tests.el
> @@ -754,7 +757,9 @@ longer than timeout seconds for the events to be delivered."
> (should (file-notify-valid-p file-notify--test-desc))
> ;; After removing the watch, the descriptor must not be valid
> ;; anymore.
> + (read-event nil nil file-notify--test-read-event-timeout)
> (file-notify-rm-watch file-notify--test-desc)
> + (read-event nil nil file-notify--test-read-event-timeout)
> (file-notify--wait-for-events
> (file-notify--test-timeout)
> (not (file-notify-valid-p file-notify--test-desc)))
> @@ -776,7 +781,9 @@ longer than timeout seconds for the events to be delivered."
> (should (file-notify-valid-p file-notify--test-desc))
> ;; After deleting the directory, the descriptor must not be
> ;; valid anymore.
> + (read-event nil nil file-notify--test-read-event-timeout)
> (delete-directory file-notify--test-tmpfile t)
> + (read-event nil nil file-notify--test-read-event-timeout)
> (file-notify--wait-for-events
> (file-notify--test-timeout)
> (not (file-notify-valid-p file-notify--test-desc)))
I'm curious why you need the additional `read-event' calls. The
following `file-notify--wait-for-events' loops until the condition is
satisfied, calling `read-event' every iteration.
Best regards, Michael.
next parent reply other threads:[~2016-03-19 15:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160319124618.27869.30424@vcs.savannah.gnu.org>
[not found] ` <E1ahGGo-0007GB-7z@vcs.savannah.gnu.org>
2016-03-19 15:11 ` Michael Albinus [this message]
2016-03-21 6:03 ` master 326fff4: Improve w32notify notifications Fabrice Popineau
2016-03-22 10:15 ` Michael Albinus
[not found] ` <CAFgFV9OKWebjGRHrhysG+PCJuQH2vke8eYMbvr05ocQnscMVJg@mail.gmail.com>
[not found] ` <87shzgqbd8.fsf@gmx.de>
[not found] ` <CAFgFV9PE_zRF+ukD9X=k4pYogBEmB9cr=HRA0wig8yZXhgG8Jw@mail.gmail.com>
2016-03-24 13:16 ` Michael Albinus
2016-03-24 15:57 ` Eli Zaretskii
2016-03-24 17:36 ` Michael Albinus
2016-03-29 14:31 ` Andy Moreton
2016-04-02 9:41 ` Eli Zaretskii
2016-04-02 19:52 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mvpu33kt.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=emacs-devel@gnu.org \
--cc=fabrice.popineau@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.