From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#20637: incompatible, undocumented change to vc-working-revision Date: Tue, 29 Mar 2016 20:13:09 +0200 Message-ID: <87mvphnoei.fsf@gmx.de> References: <6ok2vyzwf9.fsf@fencepost.gnu.org> <08f70cda-44be-0657-e50a-2b2c80d2c21c@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1459275271 21053 80.91.229.3 (29 Mar 2016 18:14:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 29 Mar 2016 18:14:31 +0000 (UTC) Cc: 20637@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Mar 29 20:14:19 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aky9j-00068f-AP for geb-bug-gnu-emacs@m.gmane.org; Tue, 29 Mar 2016 20:14:19 +0200 Original-Received: from localhost ([::1]:49118 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aky9f-0007Iq-4M for geb-bug-gnu-emacs@m.gmane.org; Tue, 29 Mar 2016 14:14:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52684) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aky9V-0007I3-M2 for bug-gnu-emacs@gnu.org; Tue, 29 Mar 2016 14:14:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aky9S-0007hp-FT for bug-gnu-emacs@gnu.org; Tue, 29 Mar 2016 14:14:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:46964) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aky9S-0007hk-Bl for bug-gnu-emacs@gnu.org; Tue, 29 Mar 2016 14:14:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1aky9R-0007C3-TA; Tue, 29 Mar 2016 14:14:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, Dmitry Gutov Resent-Date: Tue, 29 Mar 2016 18:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20637 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20637-submit@debbugs.gnu.org id=B20637.145927520027596 (code B ref 20637); Tue, 29 Mar 2016 18:14:01 +0000 Original-Received: (at 20637) by debbugs.gnu.org; 29 Mar 2016 18:13:20 +0000 Original-Received: from localhost ([127.0.0.1]:44090 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aky8m-0007B2-1Z for submit@debbugs.gnu.org; Tue, 29 Mar 2016 14:13:20 -0400 Original-Received: from mout.gmx.net ([212.227.15.19]:60219) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aky8j-0007Ao-W9 for 20637@debbugs.gnu.org; Tue, 29 Mar 2016 14:13:18 -0400 Original-Received: from detlef.gmx.de ([87.146.53.26]) by mail.gmx.com (mrgmx002) with ESMTPSA (Nemesis) id 0MaIPo-1aR6uE1m2K-00JsEo; Tue, 29 Mar 2016 20:13:10 +0200 In-Reply-To: <08f70cda-44be-0657-e50a-2b2c80d2c21c@yandex.ru> (Dmitry Gutov's message of "Tue, 29 Mar 2016 02:28:22 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-Provags-ID: V03:K0:Gi3A8gM7QiUhvyCKTg8KDX19aVQG/5CxSnmtSfhdj62AwX4OMoq uorHEK7xTg3hM7f6Oq/G9gDm0cfP0rN/+QqIW4NiocfPl0rHV1ThVbw1bG+VuUgUcWnDHvL /olvWbJWR8mhOW5ZUKQWX/GXPvw2JRlkpTRJy+IDwaWS2dLnPIpVvR5ZSAcPAMP5l0Fi+m8 UGYzyO8nUoJcbfzmzVYSw== X-UI-Out-Filterresults: notjunk:1;V01:K0:zLxOKtpuN70=:iHlVm+DaGJDOojWrxveVwk S+JyBkblrMZ8Lp9OK3snj47WgbEoCJO3i4paGdODoUrJbEbP2oowftFLCjfQdCzlKgZqYkvM1 FcP9swOBUQAvCsy/Jy1ETmC+Y8eVBfYLlmizEks4Rc7Y2syvueiwUOdaL7hFnGMjKAXXUgyNA jAXXZLKnK2QCF7PiXyBksiwqUAYdzFuOUrldvfZWkqNhVCpYo5WT4RDOal9DK7yDbRi1VPSnd /LdLGiuA8Xpf9rnKISIkCEZKXUltQbncIfXk9pDmnOtsiUrO1t2ilCTu95pmEPUlyfL/c7jqj p937kuFfY++RhL3oCY6bg7S5dulTfdG5R6Inai0FCphCg92xKxACxdQw1vyrB0FnQRZEofwOi GNN4CVBjGjDzHJav6T59lJCOkAxBJ35vgy4OPwpaE1oQWGkdjNNz2VzJb4UZP/QZyNpCqC0ag njO9Lr3WDOsUz1412eit19oNAEKh2cji6VJzhpufiM/ZCkswdanU5eMEXZeIubjAgYZbXWeRh x6JdY1vdoi7Cf2uqNw/iH4YidOtQrE5ynN9nFC+BLpknOWnMiAMT1dcCCCdmabBHoC/5xsyNS dAQFcDnaizCqQ4B8Vba10+RZuTwEhLnQE9gg6h0TuoiSssiRVleR6HicpxAkrPwt45J1S64sN 4YK6afupVt8t/ZRnoitBk9oAv9Qxxp0DMlAI9MM3OdfSvunbw4r8B0COVrcf7ZbfPJMIJUppi MV6i6/aLo9PkIs/Ld2SzgZCny/Kj86BcSmpVWllR9JVY/2xXYbEDf8owjt4c8F3iMQoTd5/U X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:115733 Archived-At: Dmitry Gutov writes: Hi Dmitry > Also, reverting this commit also seems to uncover tests that shouldn't > pass anyway. Checks like > > (should (eq (vc-state default-directory) > (vc-state default-directory backend))) > > don't verify much, and in this case they seem to verify the wrong > thing. More on that in the respective threads in emacs-devel later. > > Michael, thoughts? Why is verifying such tests "the wrong thing"? It's a while ago that I wrote the tests, but IIRC I've added them exactly because I did expect that such tests should pass, and they didn't. I even fixed some trivial corner cases when writing the tests. as far as I understood the code. Best regards, Michael.