From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: phillip.lord@russet.org.uk (Phillip Lord) Newsgroups: gmane.emacs.devel Subject: Re: run tests from el files Date: Mon, 27 Jun 2016 22:47:08 +0100 Message-ID: <87mvm6s3s3.fsf@russet.org.uk> References: <871t3is6tv.fsf@russet.org.uk> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1467064129 12224 80.91.229.3 (27 Jun 2016 21:48:49 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 27 Jun 2016 21:48:49 +0000 (UTC) Cc: rswgnu@gmail.com, emacs-devel To: Robert Weiner Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 27 23:48:39 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bHeOQ-0005Oq-O9 for ged-emacs-devel@m.gmane.org; Mon, 27 Jun 2016 23:48:34 +0200 Original-Received: from localhost ([::1]:33051 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bHeOP-0001xr-FE for ged-emacs-devel@m.gmane.org; Mon, 27 Jun 2016 17:48:33 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42686) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bHeNp-0001xb-PL for emacs-devel@gnu.org; Mon, 27 Jun 2016 17:47:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bHeNo-0004OV-Py for emacs-devel@gnu.org; Mon, 27 Jun 2016 17:47:57 -0400 Original-Received: from cloud103.planethippo.com ([31.216.48.48]:41359) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bHeNj-0004H8-Gv; Mon, 27 Jun 2016 17:47:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=russet.org.uk; s=default; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Message-ID:In-Reply-To:Date:References:Subject:Cc:To:From; bh=QvHcvvn69tVI/Qj5I/MNSDCYv5oojaPaVL/KdvQ/mes=; b=U00iZ0ozvZm1stRzfOb3Pxc4jT Nl9uJiMZxl/MXS6AwtplsDlVwDKDziTbt+yQsIIQcPngjX47DY1UPhCGkXzB7UyS0hlBHUkglTVYe +0mXk6Tx4IQhP0I+NAbcM7mOx0tuVzIlTAjenjxm7tSDM6nqZeSeNX1tTgY7q4TCxX3O2OEj7kUjX U7cY7sfdnrk30Oy/HpIhYGpcD8jEE/LILKvVzzqVyFG37rHDoWhufrD/J96uDc9yfiopPBY1IHdPr s+594RDFE4dMU+rgZldI6t9JKCt05Kl+intS/634pkeSLyambV4w1od0LFtVW26PGb2LyTjZzKqkL y8OXWDqw==; Original-Received: from cpc1-benw10-2-0-cust373.gate.cable.virginm.net ([77.98.219.118]:53118 helo=russet.org.uk) by cloud103.planethippo.com with esmtpsa (TLSv1.2:DHE-RSA-AES128-SHA:128) (Exim 4.86_1) (envelope-from ) id 1bHeN3-003QPE-EK; Mon, 27 Jun 2016 22:47:09 +0100 In-Reply-To: (Robert Weiner's message of "Mon, 27 Jun 2016 17:05:59 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.95 (gnu/linux) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cloud103.planethippo.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - russet.org.uk X-Get-Message-Sender-Via: cloud103.planethippo.com: authenticated_id: phillip.lord@russet.org.uk X-Authenticated-Sender: cloud103.planethippo.com: phillip.lord@russet.org.uk X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 31.216.48.48 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:204841 Archived-At: Robert Weiner writes: > On Mon, Jun 27, 2016 at 4:41 PM, Phillip Lord > wrote: > >> >> I would like comments on this patch which I'd like to install on master. >> >> The idea is to run tests of the .el files because they give nicer >> stacktraces. I can see no downsides to this, but I don't understand >> why the .elc files were used in the first place, so wanted to ask. >> > > =E2=80=8BI would think you would want to test both .el and .elc behavior = since if > there is an issue in=E2=80=8B > > =E2=80=8Bbyte-compilation, it is possible an assertion might fail there w= hile not > failing in the source (and tests of the byte-compiler might have missed t= he > issue). Only the .elc behavior will be seen in production, so you want to > be sure that is producing correct results but it certainly would be nice = to > get easy-to-read stack traces during any first pass testing. This is only the *tests* that I am not byte-compiling (or rather not loading), and they are not there in production at all. Phil