all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: npostavs@users.sourceforge.net
To: vincent douzal <vincent.douzal@teledetection.fr>
Cc: 19773@debbugs.gnu.org
Subject: bug#19773: 23.2; kill-rectangle documentation
Date: Sun, 03 Jul 2016 22:09:37 -0400	[thread overview]
Message-ID: <87mvlyduhq.fsf@users.sourceforge.net> (raw)
In-Reply-To: <20150204150929.6f439405@pcplat50.interne-mtd> (vincent douzal's message of "Wed, 4 Feb 2015 15:09:29 +0000")

[-- Attachment #1: Type: text/plain, Size: 460 bytes --]

tags 19773 patch
quit

vincent douzal <vincent.douzal@teledetection.fr> writes:

> Hello,
>
> The documentation string for kill-rectangle erroneously speaks about the
> kill ring.  Rectangles of text are not copied to the kill ring, but in
> the variable kill-rectangle, which besides is not a ring.

Hmm yeah, looks like copy-pasto.  Should we mention the variable name
directly in the docstring (as in patch below) or is it better to just
say it's "saved"?


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: patch --]
[-- Type: text/x-diff, Size: 1333 bytes --]

From e2455dd16032f21884b39169a70386801a27392a Mon Sep 17 00:00:00 2001
From: Noam Postavsky <npostavs@gmail.com>
Date: Sun, 3 Jul 2016 21:40:26 -0400
Subject: [PATCH v1] kill-rectangle should mention kill-rectangle

* lisp/rect.el (kill-rectangle): Mention `killed-rectangle' in docstring
and warning message, rather than kill ring (Bug#19773).
---
 lisp/rect.el | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lisp/rect.el b/lisp/rect.el
index 43621d9..8fedce2 100644
--- a/lisp/rect.el
+++ b/lisp/rect.el
@@ -284,7 +284,7 @@ kill-rectangle
 deleted.
 
 If the buffer is read-only, Emacs will beep and refrain from deleting
-the rectangle, but put it in the kill ring anyway.  This means that
+the rectangle, but put it in `killed-rectangle' anyway.  This means that
 you can use this command to copy text from a read-only buffer.
 \(If the variable `kill-read-only-ok' is non-nil, then this won't
 even beep.)"
@@ -295,7 +295,7 @@ kill-rectangle
      (setq deactivate-mark t)
      (setq killed-rectangle (extract-rectangle start end))
      (if kill-read-only-ok
-	 (progn (message "Read only text copied to kill ring") nil)
+	 (progn (message "Read only text copied to `killed-rectangle'") nil)
        (barf-if-buffer-read-only)
        (signal 'text-read-only (list (current-buffer)))))))
 
-- 
2.8.0


  reply	other threads:[~2016-07-04  2:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-04 15:09 bug#19773: 23.2; kill-rectangle documentation vincent douzal
2016-07-04  2:09 ` npostavs [this message]
2016-07-17  1:18   ` npostavs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mvlyduhq.fsf@users.sourceforge.net \
    --to=npostavs@users.sourceforge.net \
    --cc=19773@debbugs.gnu.org \
    --cc=vincent.douzal@teledetection.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.