From: Andreas Politz <politza@hochschule-trier.de>
To: 24213@debbugs.gnu.org
Subject: bug#24213: 25.1.50; Fishy use of delete-window in register.el
Date: Fri, 12 Aug 2016 22:22:05 +0200 [thread overview]
Message-ID: <87mvkhivpu.fsf@hochschule-trier.de> (raw)
The register.el commands display a preview of register contents, using
display-buffer in register-preview. Later, when some register was
chosen by the user, the window showing this preview is closed via
delete-window.
It seems to me, that this call should be replaced by a call to
quit-window, because this function does the right thing: It only deletes
the window if it was previously created and otherwise shows the previous
buffer in that window.
If that analysis can be agreed upon: Grepping through lisp/*, I found 62
uses of delete-window outside window.el. I assume that most of those
applications are problematic in the same way (e.g. finder.el).
-Andreas
next reply other threads:[~2016-08-12 20:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-12 20:22 Andreas Politz [this message]
2016-08-13 2:39 ` bug#24213: 25.1.50; Fishy use of delete-window in register.el Leo Liu
2016-08-13 6:43 ` Andreas Politz
2016-08-13 8:25 ` martin rudalics
2016-08-13 12:44 ` npostavs
2016-08-13 12:51 ` Eli Zaretskii
2016-08-13 13:30 ` martin rudalics
2016-08-13 9:50 ` Leo Liu
2016-08-13 8:24 ` martin rudalics
2016-08-13 9:50 ` Leo Liu
2016-08-13 8:24 ` martin rudalics
2016-08-13 8:47 ` Andreas Politz
2016-08-13 10:03 ` martin rudalics
2016-08-31 19:04 ` Andreas Politz
2016-09-01 7:40 ` martin rudalics
2016-09-01 11:22 ` Andreas Politz
2016-09-01 12:57 ` martin rudalics
2019-09-29 14:58 ` Lars Ingebrigtsen
2019-10-13 3:09 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mvkhivpu.fsf@hochschule-trier.de \
--to=politza@hochschule-trier.de \
--cc=24213@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.