From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Andreas Politz Newsgroups: gmane.emacs.bugs Subject: bug#24240: 25.1.50; window-state-put, image-mode and window scrolling Date: Wed, 17 Aug 2016 12:33:19 +0200 Message-ID: <87mvkblm6o.fsf@hochschule-trier.de> References: <87bn0ttyzc.fsf@hochschule-trier.de> <57B2F247.9050601@gmx.at> <8737m4u8j6.fsf@hochschule-trier.de> <57B420A2.6020608@gmx.at> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: blaine.gmane.org 1471430061 32311 195.159.176.226 (17 Aug 2016 10:34:21 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 17 Aug 2016 10:34:21 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) Cc: 24240@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Aug 17 12:34:17 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bZyAq-0008D5-Vg for geb-bug-gnu-emacs@m.gmane.org; Wed, 17 Aug 2016 12:34:17 +0200 Original-Received: from localhost ([::1]:46542 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bZyAo-0001dP-68 for geb-bug-gnu-emacs@m.gmane.org; Wed, 17 Aug 2016 06:34:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39666) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bZyAh-0001cw-6o for bug-gnu-emacs@gnu.org; Wed, 17 Aug 2016 06:34:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bZyAc-0006PN-5u for bug-gnu-emacs@gnu.org; Wed, 17 Aug 2016 06:34:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:33864) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bZyAb-0006PH-Ry for bug-gnu-emacs@gnu.org; Wed, 17 Aug 2016 06:34:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bZyAb-0002v9-KP for bug-gnu-emacs@gnu.org; Wed, 17 Aug 2016 06:34:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andreas Politz Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 17 Aug 2016 10:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24240 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24240-submit@debbugs.gnu.org id=B24240.147143001711200 (code B ref 24240); Wed, 17 Aug 2016 10:34:01 +0000 Original-Received: (at 24240) by debbugs.gnu.org; 17 Aug 2016 10:33:37 +0000 Original-Received: from localhost ([127.0.0.1]:59809 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bZyAD-0002ua-LE for submit@debbugs.gnu.org; Wed, 17 Aug 2016 06:33:37 -0400 Original-Received: from gateway-a.fh-trier.de ([143.93.54.181]:33169) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bZyAB-0002uG-LG for 24240@debbugs.gnu.org; Wed, 17 Aug 2016 06:33:36 -0400 X-Virus-Scanned: by Amavisd-new + McAfee uvscan + ClamAV [Rechenzentrum Hochschule Trier (RZ/HT)] Original-Received: from localhost (ip5f5bdf4d.dynamic.kabel-deutschland.de [95.91.223.77]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: politza) by gateway-a.fh-trier.de (Postfix) with ESMTPSA id AFA76179883E; Wed, 17 Aug 2016 12:33:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha1; c=simple/simple; d=hochschule-trier.de; s=default; t=1471429999; bh=xeWWM/YO31XVHT5Aj6q3uLiHX6I=; h=From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID: MIME-Version:Content-Type; b=fUy4iyY0vU1KHWTEh959/9xrcPXEugeWMg58rOZtJR01/cYb4HNEDY5ZQYQbA5FWQ xqyD+jGlXqDkGjT4B6bWZv1qzwm1y55dUcNEkiRg8P++ZxTHQm+qZzKBsLhMHsJsXY v/WUq0/31IW5hIfsj8Sty64hlltW9LRl/8jdfi7k= In-Reply-To: <57B420A2.6020608@gmx.at> (martin rudalics's message of "Wed, 17 Aug 2016 10:30:26 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:122309 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable martin rudalics writes: > We can abuse =E2=80=98frame-after-make-frame=E2=80=99. Try the attached,= completely > untested patch. > > BTW I just noticed that we still run =E2=80=98window-configuration-change= -hook=E2=80=99 > in far too many cases. (defmacro with-inhibit-window-configuration-change-hook (frame &rest body) "Inhibit `window-configuration-change-hook' on FRAME in BODY." (declare (indent 1) (debug t)) (let ((frame-var (make-symbol "frame"))) `(let ((,frame-var (window-normalize-frame ,frame))) (unwind-protect (progn (frame-after-make-frame ,frame-var nil) ,@body) (frame-after-make-frame ,frame-var t))))) > Would my patch work around that? It seems to inhibit running the hook, but there is still the case of set-window-start in window--state-put-2. Using the NOFORCE works, but I don't know the implications of this in other cases. --=-=-= Content-Type: text/x-diff Content-Disposition: inline Content-Description: set-window-start.diff diff --git a/lisp/window.el b/lisp/window.el index 11d7a4e..d30819d 100644 --- a/lisp/window.el +++ b/lisp/window.el @@ -5497,7 +5497,7 @@ window--state-put-2 ;; Install positions (maybe we should do this after all ;; windows have been created and sized). (ignore-errors - (set-window-start window (cdr (assq 'start state))) + (set-window-start window (cdr (assq 'start state)) 'noforce) (set-window-point window (cdr (assq 'point state)))) ;; Select window if it's the selected one. (when (cdr (assq 'selected state)) --=-=-= Content-Type: text/plain -ap --=-=-=--