From: Andreas Politz <politza@hochschule-trier.de>
To: martin rudalics <rudalics@gmx.at>
Cc: 24240@debbugs.gnu.org
Subject: bug#24240: 25.1.50; window-state-put, image-mode and window scrolling
Date: Wed, 17 Aug 2016 12:33:19 +0200 [thread overview]
Message-ID: <87mvkblm6o.fsf@hochschule-trier.de> (raw)
In-Reply-To: <57B420A2.6020608@gmx.at> (martin rudalics's message of "Wed, 17 Aug 2016 10:30:26 +0200")
[-- Attachment #1: Type: text/plain, Size: 938 bytes --]
martin rudalics <rudalics@gmx.at> writes:
> We can abuse ‘frame-after-make-frame’. Try the attached, completely
> untested patch.
>
> BTW I just noticed that we still run ‘window-configuration-change-hook’
> in far too many cases.
(defmacro with-inhibit-window-configuration-change-hook (frame &rest body)
"Inhibit `window-configuration-change-hook' on FRAME in BODY."
(declare (indent 1) (debug t))
(let ((frame-var (make-symbol "frame")))
`(let ((,frame-var (window-normalize-frame ,frame)))
(unwind-protect
(progn
(frame-after-make-frame ,frame-var nil)
,@body)
(frame-after-make-frame ,frame-var t)))))
> Would my patch work around that?
It seems to inhibit running the hook, but there is still the case of
set-window-start in window--state-put-2. Using the NOFORCE works, but I
don't know the implications of this in other cases.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: set-window-start.diff --]
[-- Type: text/x-diff, Size: 545 bytes --]
diff --git a/lisp/window.el b/lisp/window.el
index 11d7a4e..d30819d 100644
--- a/lisp/window.el
+++ b/lisp/window.el
@@ -5497,7 +5497,7 @@ window--state-put-2
;; Install positions (maybe we should do this after all
;; windows have been created and sized).
(ignore-errors
- (set-window-start window (cdr (assq 'start state)))
+ (set-window-start window (cdr (assq 'start state)) 'noforce)
(set-window-point window (cdr (assq 'point state))))
;; Select window if it's the selected one.
(when (cdr (assq 'selected state))
[-- Attachment #3: Type: text/plain, Size: 5 bytes --]
-ap
next prev parent reply other threads:[~2016-08-17 10:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-15 23:05 bug#24240: 25.1.50; window-state-put, image-mode and window scrolling Andreas Politz
2016-08-16 11:00 ` martin rudalics
2016-08-16 13:51 ` Andreas Politz
2016-08-17 8:30 ` martin rudalics
2016-08-17 10:33 ` Andreas Politz [this message]
2016-08-17 15:47 ` martin rudalics
2016-08-17 16:12 ` Andreas Politz
2016-08-18 8:42 ` martin rudalics
2016-10-30 8:47 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mvkblm6o.fsf@hochschule-trier.de \
--to=politza@hochschule-trier.de \
--cc=24240@debbugs.gnu.org \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.