all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Thibault Marin <thibault.marin@gmx.com>
Cc: Dieter Schoen <dieter@schoen.or.at>,
	"emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>
Subject: Re: ob-lua
Date: Mon, 22 Aug 2016 11:28:45 +0200	[thread overview]
Message-ID: <87mvk5w3si.fsf@saiph.selenimh> (raw)
In-Reply-To: <87a8g5edep.fsf@dell-desktop.WORKGROUP> (Thibault Marin's message of "Sun, 21 Aug 2016 21:38:22 -0500")

Hello,

Thibault Marin <thibault.marin@gmx.com> writes:

> The attached patch (using git format-patch) is adding test-ob-lua.el and
> ob-lua.el.  My contribution to ob-lua.el is only a tiny patch on top of
> Dieter's ob-lua.el but it appears as a new file in the patch, since
> ob-lua.el is not currently in the repository.

That is not a problem. We can make this appear as two patches.

> I am still a bit confused about this (make test complains about a
> missing dependency for ob-lua, maybe because it is in contrib/lisp?),
> but I can run the test using the command line emacs --batch command
> described in testing/README, and it does not require any change to
> org-test.el, so I'll run tests this way from now on.

The point is to add it to core Org, not to contrib/, isn't it?

> Please let me know if some other changes are needed.  Thanks for the
> guidance.

It looks good. Thank you.

I noticed stardiviner (Cc'ed) also provides "ob-lua" on MELPA, although
Dieter's predates it.

Stardiviner, what is the status of your library wrt to the one provided
in this thread ? Is the latter a superset of yours, or are there some
features that could be merged/improved with your code?


Regards,

-- 
Nicolas Goaziou

  reply	other threads:[~2016-08-22  9:28 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-20  5:18 ob-lua Thibault Marin
2016-08-20 16:02 ` ob-lua Nicolas Goaziou
2016-08-21  4:47   ` ob-lua Thibault Marin
2016-08-21  9:30     ` ob-lua Nicolas Goaziou
2016-08-22  2:38       ` ob-lua Thibault Marin
2016-08-22  9:28         ` Nicolas Goaziou [this message]
2016-08-22 12:56           ` ob-lua Thibault Marin
2016-08-24  2:39             ` ob-lua Thibault Marin
2016-08-29  7:10               ` ob-lua Nicolas Goaziou
2016-08-31  3:36                 ` ob-lua Thibault Marin
2016-09-01 16:40                   ` ob-lua Nicolas Goaziou
2016-09-08  4:37                     ` ob-lua Thibault Marin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mvk5w3si.fsf@saiph.selenimh \
    --to=mail@nicolasgoaziou.fr \
    --cc=dieter@schoen.or.at \
    --cc=emacs-orgmode@gnu.org \
    --cc=thibault.marin@gmx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.