all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 25525@debbugs.gnu.org, Tom Tromey <tom@tromey.com>
Subject: bug#25525: 25.1.90; add color highlighting to css mode
Date: Fri, 10 Feb 2017 21:11:48 -0700	[thread overview]
Message-ID: <87mvdt5ptn.fsf@tromey.com> (raw)
In-Reply-To: <834m0l39co.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 26 Jan 2017 21:32:55 +0200")

>>>>> "Eli" == Eli Zaretskii <eliz@gnu.org> writes:

Eli> I thought about something like
Eli>   (if (> (color-distance color "black") 292485) "black" "white")
Eli> I think this is the equivalent of your test.

I tried this.  In particular with the patch applied, I did this in a
temporary (fundamental-mode) buffer:

(mapcar
 (lambda (c)
   (insert
    (propertize (car c) 'font-lock-face
		(list :background (cdr c)
		      :foreground (css--contrasty-color (cdr c))))
    " "
    (propertize (car c) 'font-lock-face
		(list :background (cdr c)
		      :foreground
		      (if (> (color-distance (cdr c) "black") 292485)
			  "black" "white")))
    "\n"))
 css--color-map)


... then I looked at all the pairs.

For the most part I think they are all ok.  Occasionally color-distance
picks a different color, sometimes a mildly worse one IMO, though at
least in one case ("grey") a mildly better one.

Anyway, I think it's good enough, and if someone trips across a
difficult case and files a bug, we can revisit it at that time.

Tom





  reply	other threads:[~2017-02-11  4:11 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-25  8:06 bug#25525: 25.1.90; add color highlighting to css mode Tom Tromey
2017-01-25 15:51 ` Eli Zaretskii
2017-01-25 17:25   ` Tom Tromey
2017-01-25 23:34     ` Tom Tromey
2017-01-26 16:05       ` Eli Zaretskii
2017-01-26 17:13         ` Tom Tromey
2017-01-26 19:32           ` Eli Zaretskii
2017-02-11  4:11             ` Tom Tromey [this message]
2017-01-26 17:17         ` Tom Tromey
2017-01-25 16:52 ` Glenn Morris
2017-01-25 20:23 ` Simen Heggestøyl
2017-01-25 20:41   ` Tom Tromey
2017-01-25 23:24   ` Tom Tromey
2017-01-26 18:25     ` Simen Heggestøyl
2017-02-11  4:16       ` Tom Tromey
2017-02-11 15:17       ` Tom Tromey
2017-02-17 19:29         ` Simen Heggestøyl
2017-03-04 17:55           ` Tom Tromey
2017-03-04 18:46             ` Simen Heggestøyl
2017-03-04 19:58               ` Tom Tromey
2017-03-05 18:28                 ` Simen Heggestøyl
     [not found]                   ` <871str3b48.fsf@tromey.com>
2017-03-20 21:28                     ` Tom Tromey
2017-03-22 22:07                     ` Tom Tromey
2017-03-29 18:27                       ` Simen Heggestøyl
2017-04-21  3:40                         ` Tom Tromey
2017-04-21  9:33                           ` Andreas Schwab
2017-04-22  0:44                             ` Tom Tromey
2017-04-22 15:07                           ` Simen Heggestøyl
2017-04-24 13:44                             ` Tom Tromey
2017-04-29  4:17                               ` Tom Tromey
2017-05-01 19:15                                 ` Simen Heggestøyl
2017-05-03 22:04                                   ` Tom Tromey
2017-05-01 21:25                                 ` Etienne Prud’homme
2017-05-03 22:03                                   ` Tom Tromey
2017-05-03 23:24                                     ` Etienne Prud’homme
2017-05-04  3:51                                       ` Tom Tromey
2017-03-05  2:42               ` Tom Tromey
2017-03-05 15:34                 ` Eli Zaretskii
2017-05-03 22:04 ` bug#25525: done Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mvdt5ptn.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=25525@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.