From: Thierry Volpiatto <thierry.volpiatto@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 25122@debbugs.gnu.org
Subject: bug#25122: 24.5; function describe-variable hangs on large variables
Date: Sat, 11 Mar 2017 20:26:56 +0100 [thread overview]
Message-ID: <87mvcrty0v.fsf@gmail.com> (raw)
In-Reply-To: <jwv4lyz3krb.fsf-monnier+bug#25122@gnu.org>
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> (cl-letf (((symbol-function 'pp)
>> (lambda (object &optional stream)
>> (let ((fn (lambda (ob &optional stream)
>> (princ (pp-to-string ob)
>> (or stream standard-output))
>> (terpri)))
>> (print-circle t))
>> (if (consp object)
>> (progn
>> (insert "\n(")
>> (mapc fn object)
>> (cl-letf (((point) (1- (point))))
>> (insert ")")))
>> (funcall fn object stream))))))
>
> Hmm... I wonder why this would be faster.
However it is fast, it is anyway better than the actual situation were e.g C-h v
load-history takes minutes in the best case to load the 1.8M help buffer.
With this code it takes around 1s.
> In the past, the implementation of `print-circle` had a poor
> complexity, but we fixed that around Emacs-24, IIRC so it now uses a
> hash-table and should have O(n) complexity, which means that pp
> shouldn't be slower than (mapc #'pp).
The code above run at the same speed with and without print-circle...
--
Thierry
prev parent reply other threads:[~2017-03-11 19:26 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-06 2:21 bug#25122: 24.5; function describe-variable hangs on large variables Boruch Baum
2016-12-06 6:41 ` Thierry Volpiatto
2016-12-07 3:50 ` npostavs
2016-12-07 8:58 ` Thierry Volpiatto
2017-03-11 5:40 ` npostavs
2017-03-11 15:33 ` Stefan Monnier
2017-03-11 19:29 ` Thierry Volpiatto
2017-03-11 21:59 ` npostavs
2017-03-11 23:55 ` Drew Adams
2017-03-12 5:57 ` Thierry Volpiatto
2017-03-12 14:07 ` Stefan Monnier
2017-03-12 14:15 ` npostavs
2017-03-12 14:59 ` Drew Adams
2017-03-12 16:29 ` Stefan Monnier
2017-03-12 16:32 ` npostavs
2017-03-13 4:47 ` npostavs
2017-03-13 14:01 ` npostavs
2017-03-16 2:54 ` npostavs
2017-04-18 3:53 ` npostavs
2017-04-22 18:25 ` npostavs
2017-04-26 3:57 ` Michael Heerdegen
2017-04-26 10:35 ` Michael Heerdegen
2017-03-11 19:34 ` Thierry Volpiatto
2017-03-12 16:07 ` npostavs
2017-03-11 15:21 ` Stefan Monnier
2017-03-11 15:35 ` npostavs
2017-03-11 19:26 ` Thierry Volpiatto [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mvcrty0v.fsf@gmail.com \
--to=thierry.volpiatto@gmail.com \
--cc=25122@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.