From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Andreas Politz Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 716b468: Extend `file-notify-test02-rm-watch' Date: Wed, 05 Apr 2017 23:02:33 +0200 Message-ID: <87mvbutvo6.fsf@luca> References: <20170322131610.22658.57119@vcs0.savannah.gnu.org> <20170322131611.5FF7D20E17@vcs0.savannah.gnu.org> <70055ee8-c1cb-30d2-8a0b-38637adad497@cornell.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: blaine.gmane.org 1491426182 18461 195.159.176.226 (5 Apr 2017 21:03:02 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 5 Apr 2017 21:03:02 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: Michael Albinus , emacs-devel@gnu.org To: Ken Brown Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Apr 05 23:02:57 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cvs4t-00046w-2G for ged-emacs-devel@m.gmane.org; Wed, 05 Apr 2017 23:02:55 +0200 Original-Received: from localhost ([::1]:42420 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cvs4z-00021U-0P for ged-emacs-devel@m.gmane.org; Wed, 05 Apr 2017 17:03:01 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49598) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cvs4t-000218-0G for emacs-devel@gnu.org; Wed, 05 Apr 2017 17:02:56 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cvs4p-0002Qu-K1 for emacs-devel@gnu.org; Wed, 05 Apr 2017 17:02:55 -0400 Original-Received: from gateway-a.fh-trier.de ([143.93.54.181]:36016) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cvs4p-0002Oo-9G for emacs-devel@gnu.org; Wed, 05 Apr 2017 17:02:51 -0400 X-Virus-Scanned: by Amavisd-new + McAfee uvscan + ClamAV [Rechenzentrum Hochschule Trier (RZ/HT)] Original-Received: from localhost (ip5f5bdecf.dynamic.kabel-deutschland.de [95.91.222.207]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: politza) by gateway-a.fh-trier.de (Postfix) with ESMTPSA id 9F0B6179BF04; Wed, 5 Apr 2017 23:02:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha1; c=simple/simple; d=hochschule-trier.de; s=default; t=1491426153; bh=6J7fYXhBZVYk+ZdJF917T9kCIjc=; h=From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID: MIME-Version:Content-Type; b=mqT1LIJsQdp7sdjFTZhzldRCSkaSTqk30AfNKHKz2G11/kvqCuiacW06L2/kOvcWu 1hrrz22a9Fzyn4p+CoY0c8nBFF7+nqmYTv37+RyBPtlqgsovh/sDDdAV8A+R+e2opz cXmta56NQ9S92yB4CtzGm/CrbCUSjLWdFog1ydT0= In-Reply-To: <70055ee8-c1cb-30d2-8a0b-38637adad497@cornell.edu> (Ken Brown's message of "Tue, 4 Apr 2017 18:36:21 -0400") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x [fuzzy] X-Received-From: 143.93.54.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:213684 Archived-At: --=-=-= Content-Type: text/plain Ken Brown writes: > This may be another of those timing issues that we've dealt with > before [...]. I think it is as well. If cygwin's file-notify back-end runs on a polling timer, we need to make sure that it has acknowledged the file's existence before we delete it. Maybe you could try out the following patch. --=-=-= Content-Type: text/plain Content-Disposition: inline diff --git a/test/lisp/filenotify-tests.el b/test/lisp/filenotify-tests.el index 54e7ebfc0e..9b5c751021 100644 --- a/test/lisp/filenotify-tests.el +++ b/test/lisp/filenotify-tests.el @@ -425,6 +425,7 @@ file-notify--test-make-temp-name '(change) #'second-callback))) ;; Remove first watch. (file-notify-rm-watch file-notify--test-desc) + (file-notify--test-read-event) ;; Only the second callback shall run. (delete-file file-notify--test-tmpfile) (file-notify--wait-for-events --=-=-= Content-Type: text/plain -ap --=-=-=--