From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Ted Zlatanov Newsgroups: gmane.emacs.devel Subject: Re: master bd60ee2 1/5: auth-source: factor out parsers and add tests Date: Fri, 28 Apr 2017 08:43:00 -0400 Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos Message-ID: <87mvb0n1nv.fsf@lifelogs.com> References: <20170427213824.12196.63777@vcs0.savannah.gnu.org> <20170427213827.B6BDC22040@vcs0.savannah.gnu.org> Reply-To: emacs-devel@gnu.org NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1493383429 32102 195.159.176.226 (28 Apr 2017 12:43:49 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 28 Apr 2017 12:43:49 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Apr 28 14:43:44 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d45FO-0008BQ-IH for ged-emacs-devel@m.gmane.org; Fri, 28 Apr 2017 14:43:42 +0200 Original-Received: from localhost ([::1]:36880 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d45FU-0007tj-4v for ged-emacs-devel@m.gmane.org; Fri, 28 Apr 2017 08:43:48 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43889) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d45Ew-0007tT-26 for emacs-devel@gnu.org; Fri, 28 Apr 2017 08:43:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d45Es-00041k-W2 for emacs-devel@gnu.org; Fri, 28 Apr 2017 08:43:14 -0400 Original-Received: from [195.159.176.226] (port=56021 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d45Es-00041H-OM for emacs-devel@gnu.org; Fri, 28 Apr 2017 08:43:10 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1d45Ej-0007Ph-Lj for emacs-devel@gnu.org; Fri, 28 Apr 2017 14:43:01 +0200 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: emacs-devel@gnu.org Original-Lines: 22 Original-X-Complaints-To: usenet@blaine.gmane.org X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never Cancel-Lock: sha1:9crb92Jv5Y1Gd4WWlTYu6tu1qSA= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:214384 Archived-At: On Fri, 28 Apr 2017 17:10:43 +0900 Katsumi Yamaoka wrote: KY> On Fri, 28 Apr 2017 16:53:35 +0900, Katsumi Yamaoka wrote: >> On Thu, 27 Apr 2017 17:38:27 -0400, Teodor Zlatanov wrote: >>> diff --git a/lisp/auth-source.el b/lisp/auth-source.el >>> index 7402ab2..5ad4277 100644 >>> --- a/lisp/auth-source.el >>> +++ b/lisp/auth-source.el >> [...] >>> + (return))) >> This is a cl runtime function. Could you replace it with something? KY> Sorry for not explaining enough. That is an alias to the macro KY> `cl-return' but not expanded in the elc file. Sorry, I don't know what's the proper fix. What breaks, and how should I have caught this problem before it was comitted? Should I just replace it with `cl-return' or is there more to do? Thanks Ted