From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#26055: 25.1; Eshell dollar expansion $var[i] not working Date: Fri, 09 Jun 2017 20:33:26 -0400 Message-ID: <87mv9gwujt.fsf@users.sourceforge.net> References: <87a88o7bet.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: blaine.gmane.org 1497054731 25849 195.159.176.226 (10 Jun 2017 00:32:11 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 10 Jun 2017 00:32:11 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) Cc: 26055@debbugs.gnu.org To: Chunyang Xu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jun 10 02:32:08 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dJUK0-0006Kx-0D for geb-bug-gnu-emacs@m.gmane.org; Sat, 10 Jun 2017 02:32:08 +0200 Original-Received: from localhost ([::1]:56785 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dJUK3-0007V0-NU for geb-bug-gnu-emacs@m.gmane.org; Fri, 09 Jun 2017 20:32:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57950) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dJUJx-0007UB-Tc for bug-gnu-emacs@gnu.org; Fri, 09 Jun 2017 20:32:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dJUJu-00052g-PN for bug-gnu-emacs@gnu.org; Fri, 09 Jun 2017 20:32:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:34900) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dJUJu-00052X-Kw for bug-gnu-emacs@gnu.org; Fri, 09 Jun 2017 20:32:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dJUJu-0005r7-98 for bug-gnu-emacs@gnu.org; Fri, 09 Jun 2017 20:32:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 10 Jun 2017 00:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26055 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 26055-submit@debbugs.gnu.org id=B26055.149705472122502 (code B ref 26055); Sat, 10 Jun 2017 00:32:02 +0000 Original-Received: (at 26055) by debbugs.gnu.org; 10 Jun 2017 00:32:01 +0000 Original-Received: from localhost ([127.0.0.1]:37577 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dJUJt-0005qn-43 for submit@debbugs.gnu.org; Fri, 09 Jun 2017 20:32:01 -0400 Original-Received: from mail-it0-f41.google.com ([209.85.214.41]:34078) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dJUJs-0005qV-67; Fri, 09 Jun 2017 20:32:00 -0400 Original-Received: by mail-it0-f41.google.com with SMTP id m47so2848576iti.1; Fri, 09 Jun 2017 17:32:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=RNKIAmDmJvXsqju02ShfO1FeUUKVmz+lLROTmo0D+iU=; b=AscSOBeh/36GGlIUt2V9PhKfkhRTK1v6fkwjAJ597+SrS69Dw59I/B897F3vnvLtfn xGrN1dVBKw+II3OOxJ1CDti+egf7cJPTCZnPA0FPwPs522+Mt1zihE0ua59hK1NzblM/ XhQDtMtUhr2qpQDsO+AVaWU0UbOeiAW/3KQ1x82u9JBf6ZcodoALoq37X3FX8bwy5f/x c+24fFI6PYJQU1M4msQNWYgTNDe19cMp8bG9+OVsfCThoiELCjAH4vyGrHq4vX77Exi2 dgwSWBbZp9IfBjju60sgvVPqKwD6PCtQVHtBouRu+lRv38yY2wFj+hx8aSwL4qpl07oS rU1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=RNKIAmDmJvXsqju02ShfO1FeUUKVmz+lLROTmo0D+iU=; b=W+/Ti/eiglNsjJkOo4mG5X2pa6hlOPCLHt2HS4FN/CKgzYi3Xeib5LbHjeKEPTXLMk adFydLVaQp0jFQMAicY/hsJBePCO6/NHgWE9BckQS7odSGx7MJa88zLoOrDidibQpjN0 ChqUb7VBrZow46W6V0if2+3R8zPrOB5YncCnL6ea9vQcKaST3PyYpxv2++rbeBrHBbzx vcDRrMDhb9OoFcYPiSwviXnKiw2EdWVfR/2b5tpSkEaPnG1FqZ9XLoDd8Zbp1CWsblXj USYqhxyhNln3Pur5yNwOcaTvA2BTdmsl+C92BwM4AIARITAASfCR+5utUr5VpgEzUrZa bO+w== X-Gm-Message-State: AODbwcCTH+5iW2PBapt9NadovqGPlqk6mDQtahrA8f1heY7EkgyUZNtv wHcX7v98WMmjvV6k X-Received: by 10.36.123.5 with SMTP id q5mr2387518itc.16.1497054714301; Fri, 09 Jun 2017 17:31:54 -0700 (PDT) Original-Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id e12sm2240916itd.0.2017.06.09.17.31.52 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 09 Jun 2017 17:31:53 -0700 (PDT) In-Reply-To: <87a88o7bet.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net's message of "Tue, 14 Mar 2017 00:03:06 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:133427 Archived-At: --=-=-= Content-Type: text/plain tags 26055 patch quit npostavs@users.sourceforge.net writes: > Since this apparently never worked it's hard to say what's supposed to > happen, but it looks like a 'number' property is added and then ignored. > Maybe something like this should be applied? Since `eshell-lisp-command' does the conversion of strings marked with 'number', I think it's correct to make eshell-index-value do so as well. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=v1-0001-Handle-integer-indices-for-eshell-variables-Bug-2.patch Content-Description: patch >From bacbb41ab4d5539d284b1a540e70779a49c00e25 Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Fri, 9 Jun 2017 19:40:38 -0400 Subject: [PATCH v1] Handle integer indices for eshell variables (Bug#26055) * lisp/eshell/esh-var.el (eshell-index-value): Convert index to number if it's been marked as one, just like `eshell-lisp-command' does. --- lisp/eshell/esh-var.el | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lisp/eshell/esh-var.el b/lisp/eshell/esh-var.el index fe1f1188c8..cdd05bd7e9 100644 --- a/lisp/eshell/esh-var.el +++ b/lisp/eshell/esh-var.el @@ -563,6 +563,8 @@ (defun eshell-apply-indices (value indices) (defun eshell-index-value (value index) "Reference VALUE using the given INDEX." + (when (and (stringp index) (get-text-property 0 'number index)) + (setq index (string-to-number index))) (if (stringp index) (cdr (assoc index value)) (cond -- 2.11.1 --=-=-=--