From: Andreas Schwab <schwab@linux-m68k.org>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: Noam Postavsky <npostavs@gmail.com>, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 644cdd1: Use grep's --null option (Bug#6843)
Date: Wed, 26 Jul 2017 20:54:45 +0200 [thread overview]
Message-ID: <87mv7rm3ka.fsf@linux-m68k.org> (raw)
In-Reply-To: <10f1ac4b-aca5-53e9-5112-b8312471df82@yandex.ru> (Dmitry Gutov's message of "Wed, 26 Jul 2017 19:58:32 +0300")
On Jul 26 2017, Dmitry Gutov <dgutov@yandex.ru> wrote:
>> +(defconst grep--regexp-alist-bin-matcher
>> + '("^Binary file \\(.+\\) matches$" 1 nil nil 0 1))
>> +(defconst grep-with-null-regexp-alist
>> + `(("^\\([^\0]+\\)\\(\0\\)\\([0-9]+\\):" 1 3 ,grep--regexp-alist-column nil nil
>
> Any reason to change 2 to 3? Why don't we use a non-capturing group for \0
> here?
Why using a group at all?
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2017-07-26 18:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170720000208.23054.66272@vcs0.savannah.gnu.org>
[not found] ` <20170720000210.0E44020A56@vcs0.savannah.gnu.org>
2017-07-26 16:58 ` [Emacs-diffs] master 644cdd1: Use grep's --null option (Bug#6843) Dmitry Gutov
2017-07-26 18:10 ` Michael Albinus
2017-07-27 12:01 ` Dmitry Gutov
2017-07-27 12:51 ` Alexis
2017-07-27 12:53 ` Herring, Davis
2017-07-27 13:09 ` Kaushal Modi
2017-07-27 13:30 ` Michael Albinus
2017-07-27 13:55 ` Dmitry Gutov
2017-07-26 18:54 ` Andreas Schwab [this message]
2017-07-26 19:01 ` Eli Zaretskii
2017-07-26 23:31 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mv7rm3ka.fsf@linux-m68k.org \
--to=schwab@linux-m68k.org \
--cc=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
--cc=npostavs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.