From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#28605: 26.0.60; Part of leftmost character hidden Date: Sun, 08 Oct 2017 11:51:11 +0200 Message-ID: <87mv523r3k.fsf@gmail.com> References: <59CE05F2.1010202@gmx.at> <59CE8E74.5010308@gmx.at> <59D35549.6030905@gmx.at> <87wp4c750c.fsf@gmail.com> <59D4A45F.5010606@gmx.at> <87tvzfjfcp.fsf@gmail.com> <59D5E8F6.8080002@gmx.at> <87efqikk0x.fsf@gmail.com> <87a815lq3w.fsf@gmail.com> <59D73C6F.3020907@gmx.at> <87o9pk65ae.fsf@gmail.com> <59D74E49.2000605@gmx.at> <87a8145wcr.fsf@gmail.com> <59D88B8B.6050205@gmx.at> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1507456335 17789 195.159.176.226 (8 Oct 2017 09:52:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 8 Oct 2017 09:52:15 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.60 (gnu/linux) Cc: Ola Nilsson , Lars Magne Ingebrigtsen , 28605@debbugs.gnu.org, Kaushal To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Oct 08 11:52:10 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e18Fh-0003Gv-UQ for geb-bug-gnu-emacs@m.gmane.org; Sun, 08 Oct 2017 11:52:06 +0200 Original-Received: from localhost ([::1]:53053 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e18Fp-0006kK-7W for geb-bug-gnu-emacs@m.gmane.org; Sun, 08 Oct 2017 05:52:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49911) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e18Fj-0006kD-JF for bug-gnu-emacs@gnu.org; Sun, 08 Oct 2017 05:52:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e18Fe-0002cg-TH for bug-gnu-emacs@gnu.org; Sun, 08 Oct 2017 05:52:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:46813) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e18Fe-0002cS-PI for bug-gnu-emacs@gnu.org; Sun, 08 Oct 2017 05:52:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e18Fe-0002wF-Cc for bug-gnu-emacs@gnu.org; Sun, 08 Oct 2017 05:52:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 Oct 2017 09:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28605 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 28605-submit@debbugs.gnu.org id=B28605.150745628211243 (code B ref 28605); Sun, 08 Oct 2017 09:52:02 +0000 Original-Received: (at 28605) by debbugs.gnu.org; 8 Oct 2017 09:51:22 +0000 Original-Received: from localhost ([127.0.0.1]:55494 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e18F0-0002vH-1d for submit@debbugs.gnu.org; Sun, 08 Oct 2017 05:51:22 -0400 Original-Received: from mail-wm0-f46.google.com ([74.125.82.46]:44917) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e18Ex-0002v2-JN for 28605@debbugs.gnu.org; Sun, 08 Oct 2017 05:51:20 -0400 Original-Received: by mail-wm0-f46.google.com with SMTP id 196so7730477wma.1 for <28605@debbugs.gnu.org>; Sun, 08 Oct 2017 02:51:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=0DGAnzOpQLBZSfj2peJJDrtl+n0erXH+yw7XBqUrgvw=; b=Gh3bf9vpqboOnaEU/lPtaDGa1Kk+MZVzsA09eKL2gPhihIJfZaINzdiIUxsDMfHWH7 M5D/JZoGfd144m8j1MA9l5hSB2Sut7VGmVi8xmmqh3UeYeRBAOJsVfO+OCl9DzgFE5fD tqmKcJrcvWRqR+D2bTJvfS0qhcEXrTRppFx6Jw37mD+iulHw2A/PQFIwteqRErIi8ULw uc4p822m7AIeHL3E0ylGlyaUuTMQBR/i5eUUn0OOlPIOBLbXyIL0IUpAV7MiugP/WYjf kI3fRrp/gOuXp3AeLK4MkgHnJADzRwAuhVdqQwZmkKCOFS7ZP40HrKv2E3U+WgfuG2yF 8izA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=0DGAnzOpQLBZSfj2peJJDrtl+n0erXH+yw7XBqUrgvw=; b=rUCQGFNe2P2ALc1d76e3ltpNBnLsDC7dGBzfNXLZadHurpD/kdlvK7G62vT2AOraFI 6JQb091DPnLAHq2zZPl7utJbCsqr/D62Rn0DnwzfzX3suGdpPeGnKfcteqBjSdFr1S7+ P3ZkImSY7VrVMKTbX9Eg+k/+60NVE5SbwsBXsx1w2Ij0LsLvLd3DfmTGjZA20wgJLeod TvgMRjlyYregKHlnp5Fk4xMhikFxaaN2QWXeKQoK0kWeaTGLYihrJ+DdhYigQP+vghkC j/WJefHCHqzvCiZEssa754SGMk/7ZBlKAVV62pqqn7sHFn9Lt1/Sd/d9JDyDCAqu3/6I lfLg== X-Gm-Message-State: AMCzsaXlFyTAInz4KBky+ybDf86IKtRjH4436/RWAeEeYayU6vQpxLU5 WOfIBy3HFBIPdYJy4AMkB68= X-Google-Smtp-Source: AOwi7QARcMc1yn7TmtdDhRAXUX3KvmpbTLXeIfGLp+yOScuzdpvO1I1r7p00t8PR+H9tct38z6CgJQ== X-Received: by 10.80.203.141 with SMTP id k13mr9830004edi.122.1507456273474; Sun, 08 Oct 2017 02:51:13 -0700 (PDT) Original-Received: from rpluim-ubuntu ([2a01:e34:ecfc:a090:fdbc:ef3:a1ca:7b91]) by smtp.gmail.com with ESMTPSA id r8sm5341653edd.96.2017.10.08.02.51.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 08 Oct 2017 02:51:12 -0700 (PDT) In-Reply-To: <59D88B8B.6050205@gmx.at> (martin rudalics's message of "Sat, 07 Oct 2017 10:08:43 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:138071 Archived-At: martin rudalics writes: >> Lars' HiDPI changes were a huge improvement over what was there >> before. > > Can you tell me what Jan's first stab at scaling did and what Lars' did > differently? Or simpler: How do the return values of xg_get_gdk_scale > and xg_get_scale differ in practice? Because IIUC that's what these > changes boil down to in the case we're discussing here. xg_get_gdk_scale and xg_get_scale differ in that the former only looked at GDK_SCALE, and the latter queries the widget for its scale factor, which will work better in environments where the scale factor is set via the GNOME configuration utility. Lars' changes also apply that scale in more places, resulting in eg scrollbars being at the correct position, rather than completely off to the side of the Emacs frame. >> I'm talking here only about leaving alone the x_clear_area >> code, but still changing the width calculation. > > You mean the width of the scroll bar as it's drawn by the toolkit? Yes. Basically: diff --git a/src/gtkutil.c b/src/gtkutil.c index 0da7039..78077d7 100644 --- a/src/gtkutil.c +++ b/src/gtkutil.c @@ -3879,7 +3879,7 @@ xg_update_scrollbar_pos (struct frame *f, top /= scale; left /= scale; height /= scale; - left -= (scale - 1) * ((width / scale) >> 1); + width /= scale; Robert