From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Gemini Lasswell Newsgroups: gmane.emacs.bugs Subject: bug#27747: 26.0.50; cl-defgeneric does not have an Edebug spec Date: Mon, 23 Oct 2017 10:52:41 -0700 Message-ID: <87mv4hsqdy.fsf@runbox.com> References: <87iniqjpun.fsf@chinook> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: blaine.gmane.org 1508781205 21511 195.159.176.226 (23 Oct 2017 17:53:25 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 23 Oct 2017 17:53:25 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) To: 27747@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Oct 23 19:53:19 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e6guQ-0003iA-Kd for geb-bug-gnu-emacs@m.gmane.org; Mon, 23 Oct 2017 19:53:06 +0200 Original-Received: from localhost ([::1]:39914 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e6guX-0001OC-UD for geb-bug-gnu-emacs@m.gmane.org; Mon, 23 Oct 2017 13:53:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37778) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e6guR-0001O7-QI for bug-gnu-emacs@gnu.org; Mon, 23 Oct 2017 13:53:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e6guM-0002Ig-R7 for bug-gnu-emacs@gnu.org; Mon, 23 Oct 2017 13:53:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:49285) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e6guM-0002Hz-EY for bug-gnu-emacs@gnu.org; Mon, 23 Oct 2017 13:53:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e6guM-0001jW-1t for bug-gnu-emacs@gnu.org; Mon, 23 Oct 2017 13:53:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gemini Lasswell Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 23 Oct 2017 17:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27747 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 27747-submit@debbugs.gnu.org id=B27747.15087811786652 (code B ref 27747); Mon, 23 Oct 2017 17:53:02 +0000 Original-Received: (at 27747) by debbugs.gnu.org; 23 Oct 2017 17:52:58 +0000 Original-Received: from localhost ([127.0.0.1]:57966 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e6guH-0001jE-Nz for submit@debbugs.gnu.org; Mon, 23 Oct 2017 13:52:57 -0400 Original-Received: from aibo.runbox.com ([91.220.196.211]:42956) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e6guE-0001j4-4M for 27747@debbugs.gnu.org; Mon, 23 Oct 2017 13:52:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=runbox.com; s=rbselector1; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:To:From; bh=siXkUHkRjqMa+8eD+ClUnCaVh3hh+7odH9fJmiGO1QI=; b=AlUxpcueUzinP2WDGfMUOBZUKipQIbc+PYUX0cDI+wt80nyt1PNb6kbsn70/JoYj4B+XiRTfcx m/XgRXgmKuv1kpm61c5y4N5Xi6Jxls0/LI5Fn6PcMQ1UUnGP2oFWzLDGvJ8fvyq3HPDgNqv6RMFcJ rlq76LRXJgyQF0Xv9u65xhs9scQ4Ej9CMK7QziPRak/RZBUaRri39Ss+/LZ0e3MGt4r3KO2dtP1VT Fu+XvTPwRD6a2aBzBpU5ouG5ksdo9zMsTSBqo1l/0/kewac3FWbPHJEN9y6zR+UCHfaie5VTD1fzD ehDxUl5WNr2Go2GIlDmtS4NaumYkulspkUxgg==; Original-Received: from [10.9.9.211] (helo=mailfront11.runbox.com) by mailtransmit02.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1e6guC-00085R-8G for 27747@debbugs.gnu.org; Mon, 23 Oct 2017 19:52:52 +0200 Original-Received: from c-24-22-244-161.hsd1.wa.comcast.net ([24.22.244.161] helo=chinook) by mailfront11.runbox.com with esmtpsa (uid:179284 ) (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) id 1e6gu9-0004hD-BT for 27747@debbugs.gnu.org; Mon, 23 Oct 2017 19:52:49 +0200 In-Reply-To: <87iniqjpun.fsf@chinook> (Gemini Lasswell's message of "Mon, 17 Jul 2017 22:06:40 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:138901 Archived-At: --=-=-= Content-Type: text/plain Here's a revision to the cl-defgeneric Edebug spec, because I missed this case: (cl-defgeneric (setf foo) (v args)) which isn't documented but lets you create a generalized variable. Also, the Edebug spec for cl-lambda-list isn't necessarily loaded and isn't correct for cl-defgeneric anyway. Since there isn't any code for Edebug to instrument inside the argument list, it can just be matched with listp. To reproduce these problems, start with emacs -Q and load test/lisp/emacs-lisp/cl-generic-tests.el, then use edebug-all-defs and eval-buffer. --=-=-= Content-Type: text/plain Content-Disposition: inline; filename=0001-Handle-generic-variables-in-cl-defgeneric-Edebug-spe.patch >From 912942457d93850b2d444cf25cf7e71e79259357 Mon Sep 17 00:00:00 2001 From: Gemini Lasswell Date: Mon, 23 Oct 2017 10:13:00 -0700 Subject: [PATCH] Handle generic variables in cl-defgeneric Edebug spec *lisp/emacs-lisp/cl-generic.el (cl-defgeneric): Match (setf name) and replace incorrect cl-lambda-args with listp in Edebug spec. --- lisp/emacs-lisp/cl-generic.el | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lisp/emacs-lisp/cl-generic.el b/lisp/emacs-lisp/cl-generic.el index 62befd4742..0027899679 100644 --- a/lisp/emacs-lisp/cl-generic.el +++ b/lisp/emacs-lisp/cl-generic.el @@ -206,7 +206,8 @@ cl-defgeneric \(fn NAME ARGS [DOC-STRING] [OPTIONS-AND-METHODS...] &rest DEFAULT-BODY)" (declare (indent 2) (doc-string 3) (debug - (&define name cl-lambda-list lambda-doc + (&define [&or name ("setf" name :name setf)] listp + lambda-doc [&rest [&or ("declare" &rest sexp) (":argument-precedence-order" &rest sexp) -- 2.14.2 --=-=-=--