From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#29116: 24.5; Parsing dates from VCAL Date: Mon, 06 Nov 2017 11:01:32 +0100 Message-ID: <87mv3z20ar.fsf@gmail.com> References: <1smv459hy3.fsf@voll.uninett.no> <87mv41vxib.fsf@gmail.com> <1sfu9r97g9.fsf@voll.uninett.no> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1509962833 17953 195.159.176.226 (6 Nov 2017 10:07:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 6 Nov 2017 10:07:13 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) Cc: 29116@debbugs.gnu.org To: Vegard Vesterheim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Nov 06 11:07:07 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBeJ6-00049c-6d for geb-bug-gnu-emacs@m.gmane.org; Mon, 06 Nov 2017 11:07:04 +0100 Original-Received: from localhost ([::1]:47265 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eBeJ8-0004cZ-3J for geb-bug-gnu-emacs@m.gmane.org; Mon, 06 Nov 2017 05:07:06 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55398) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eBeEK-0000DE-4y for bug-gnu-emacs@gnu.org; Mon, 06 Nov 2017 05:02:12 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eBeEE-0002LJ-9g for bug-gnu-emacs@gnu.org; Mon, 06 Nov 2017 05:02:08 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:44319) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eBeEE-0002LB-6R for bug-gnu-emacs@gnu.org; Mon, 06 Nov 2017 05:02:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eBeED-00060F-Qb for bug-gnu-emacs@gnu.org; Mon, 06 Nov 2017 05:02:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Nov 2017 10:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29116 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 29116-submit@debbugs.gnu.org id=B29116.150996250423050 (code B ref 29116); Mon, 06 Nov 2017 10:02:01 +0000 Original-Received: (at 29116) by debbugs.gnu.org; 6 Nov 2017 10:01:44 +0000 Original-Received: from localhost ([127.0.0.1]:53000 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBeDw-0005zh-5m for submit@debbugs.gnu.org; Mon, 06 Nov 2017 05:01:44 -0500 Original-Received: from mail-wm0-f43.google.com ([74.125.82.43]:56073) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBeDu-0005zU-53 for 29116@debbugs.gnu.org; Mon, 06 Nov 2017 05:01:42 -0500 Original-Received: by mail-wm0-f43.google.com with SMTP id y83so12822694wmc.4 for <29116@debbugs.gnu.org>; Mon, 06 Nov 2017 02:01:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:gmane-reply-to-list:date:in-reply-to :message-id:user-agent:mime-version; bh=MreJ1WHAS7Jj1R4yrFh2ksZwYqFT9c4T0WDkQ8dgZRU=; b=XNj/Nb01VaqEC/KuHsPDCEc1vdpo9PUW0Tl4FZ2eO4mPn4Uc7E0uVmpNX09KK1aPKx GuDuYljJad+o03Q+IFcS6SKyUtNwYOqBzRHQdzcbz1pe+wePFcl/DKi0RV7AubkMGeVl PA+d3KuzTrk/nh+HgwH3D/r3vRTWnoP4M1fCe/CW/MynnOkNN3KZNExxNoAvTpF/4/Qk qoFm6D5WV+tTGVhDKEoQ0vM0MN/TcGS9gKXJDd2yytoH3DtWiYN452f+8YJEn4SIzP2t 2QOqGp/amTFcN+W5zKWVbvJ1ErvNQ1+5M7I1QbdbC7AagsHMeCeXMAX/BhpKO9booNCR IM0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references :gmane-reply-to-list:date:in-reply-to:message-id:user-agent :mime-version; bh=MreJ1WHAS7Jj1R4yrFh2ksZwYqFT9c4T0WDkQ8dgZRU=; b=ZY6iLftdEAOiaq7tBUmf0ldBzOOH74l62PbTGVm92eW4z3qr37IAvPIRDlVp4jm/+V w1+sq9QZ+GXUBDvNIr6K0OJOAbmw+d1aCGxxP2UfJ7+2FgRjN5P7pEE5IAtfD9Ixec7E PlP7IIY0HPQZ43joHsrkmKPcxxqv9s3y6EKlYO6xOBsuQADLYHxC9O6b3BR2IwqSrqIZ RjJYRFLdadFk2l8xg/m1zfIwr7oFQSmVVUDRq7JUkpVtQvvhzKTM64tzhFP+3h9v/fsg FuHf/huigTo0zdz8i7uridDbdRlF3KRUqFoyDdletVeoz3BM2KEZnjcrL9f/mL13TUvz baaA== X-Gm-Message-State: AMCzsaVDezRY3NryLp/BSpmSFKA4hNcUfBMbJdCt8lPkYl4N6144fUxm bmdqmLe0B3/2xfxT+GUGbF+9myiY X-Google-Smtp-Source: ABhQp+TN9QC39WE5hz7n0CpyjU6D2y44LVKOIvFAf5LoawwucvKGZ4YDN4Lw5+5tQ8hpnANiOsenRw== X-Received: by 10.80.218.202 with SMTP id s10mr19816615edj.212.1509962495712; Mon, 06 Nov 2017 02:01:35 -0800 (PST) Original-Received: from rpluim-ubuntu ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id i6sm10659503edk.3.2017.11.06.02.01.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 Nov 2017 02:01:33 -0800 (PST) Gmane-Reply-To-List: yes In-Reply-To: <1sfu9r97g9.fsf@voll.uninett.no> (Vegard Vesterheim's message of "Mon, 06 Nov 2017 08:45:10 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:139496 Archived-At: Vegard Vesterheim writes: > On Sun, 05 Nov 2017 11:19:08 +0100 Robert Pluim wrote: > >> Vegard Vesterheim writes: >>> Looking at the backtrace it seems that the problem is related to parsing >>> the date string: "20171208". >> >> timezone-parse-date assumes that the time-of-day is present in the >> string to be parsed, which is not the case here. Looking at the code >> icalendar should set the time to "00000" in that case. Would you have >> a complete example VCAL file? > > Attached: > Thanks for that. > My naive workaraound for this bug was to modify the function > gnus-icalendar-event--decode-datafile: > > (defun gnus-icalendar-event--decode-datefield (ical field) > (let* ((date (icalendar--get-event-property ical field)) > (date-props (icalendar--get-event-property-attributes ical field)) > (tz (plist-get date-props 'TZID))) > > ;; VVWASHERE-start, fix bug in parsing DATE > (and (eq (car date-props) 'VALUE) > (string= (car (cdr date-props)) "DATE") > (setq date (concat date "T00:00"))) > ;; VVWASHERE-end, fix bug in parsing DATE > I thought the spec called for T000000, but if it's working for you, then leave well enough alone. > (cdr date-props) > (date-to-time (timezone-make-date-arpa-standard date nil tz)))) Duh, I've been looking at the wrong branch. This looks like it was fixed by 417cf67485, which is available in the 25.1 release or later. Robert