From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#29405: 27.0.50; message-faces: Doc fixes and syntax touch-ups Date: Wed, 22 Nov 2017 20:56:16 +0000 Message-ID: <87mv3ef2xb.fsf_-_@gmail.com> References: <87zi7ef3ab.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: blaine.gmane.org 1511384236 7735 195.159.176.226 (22 Nov 2017 20:57:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 22 Nov 2017 20:57:16 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: <29405@debbugs.gnu.org> Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 22 21:57:11 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eHc50-0001Uh-Fw for geb-bug-gnu-emacs@m.gmane.org; Wed, 22 Nov 2017 21:57:10 +0100 Original-Received: from localhost ([::1]:41280 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eHc56-0003TN-7J for geb-bug-gnu-emacs@m.gmane.org; Wed, 22 Nov 2017 15:57:16 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60842) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eHc4w-0003TE-BE for bug-gnu-emacs@gnu.org; Wed, 22 Nov 2017 15:57:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eHc4s-0006gw-QT for bug-gnu-emacs@gnu.org; Wed, 22 Nov 2017 15:57:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:44461) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eHc4s-0006gf-HH for bug-gnu-emacs@gnu.org; Wed, 22 Nov 2017 15:57:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eHc4r-0000Zm-RO for bug-gnu-emacs@gnu.org; Wed, 22 Nov 2017 15:57:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 22 Nov 2017 20:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29405 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 29405-submit@debbugs.gnu.org id=B29405.15113841872160 (code B ref 29405); Wed, 22 Nov 2017 20:57:01 +0000 Original-Received: (at 29405) by debbugs.gnu.org; 22 Nov 2017 20:56:27 +0000 Original-Received: from localhost ([127.0.0.1]:53142 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eHc4I-0000Ym-Gi for submit@debbugs.gnu.org; Wed, 22 Nov 2017 15:56:26 -0500 Original-Received: from mail-wm0-f51.google.com ([74.125.82.51]:42681) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eHc4H-0000YW-2I for 29405@debbugs.gnu.org; Wed, 22 Nov 2017 15:56:25 -0500 Original-Received: by mail-wm0-f51.google.com with SMTP id l188so11196751wma.1 for <29405@debbugs.gnu.org>; Wed, 22 Nov 2017 12:56:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:subject:references:date:in-reply-to:message-id:user-agent :mime-version; bh=9Yn4rQUNV8vUo9jvLJeSKZXpMDg9SSzNuGueyjmj9NY=; b=CdDL7wHeYFSzZqGU7oGb5RJ/pSQWic/Tc/ulWKheIv5NVuTbjvmwayCLyxeSNkhOUn l3TH1+UQk+UCs64NbcMWS563YU2n02pnSbxY9BmDLzODZi5cFD+AyYHja4K4ApBBI+4R zvjHpqhD+g9hOQKI6rzJaxRCxPk7gb8MD2Wa0AS2Zu7sjf/mYv+ORneQdjHDgmqu8Mu1 Ghm5E+0tfD4+F2DVq/7ayNTqKkDc/ibe/E3qlUEyr6eqIUjlDfhDIzZzhcKyUOGfnDQS M6js/7G41PkdMvxwWNDnpEdM6c/+Hku/ApfJlWJATpzfT3UyXxHqdOaSS9I56oTYdsFB zafA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=9Yn4rQUNV8vUo9jvLJeSKZXpMDg9SSzNuGueyjmj9NY=; b=nPrjOEIUduQgVd1DqsILdikE46AP/f+5p75l1ISTymkVyO+X8vdXi12RBLMl9LGfWc zYWky/xMSU5/upiPxxL7ZQHSwNoUKkCqKx4cUMpurVrHGDtt7Deh/ZIao1uHY0mQWB15 DrBGv4lErGoRqdb2A/mDEFOeqsPInkMOZsweqNcPdCiTf5QCJjVqU1cU7W8d1c9ToFtk FVM5zAZcZjERua4Y4XVrfhPx0QpPHyG9JEtw5ikt5ObSfRFFXotvdExjkuhQxmfPnxIq 6kCJ17j2tUZEv9mxJr+q3IVG+XluhUOnbvXYhyuf6aOdt5gTwAt7aRNn7kLlzB7AotL0 uzow== X-Gm-Message-State: AJaThX5GxUn1SrxMZiVjoqXlJSRjNtF8ySe2G4rsMXz9CSF3ZOUCMhaV AX5tNC8AGerDTd27oyn0V1FFS6Kq X-Google-Smtp-Source: AGs4zMaNrF01kSdo9cwEs+WM8hqqCOnO26+9MULo7aDUPRkqHhhpPlOw7R9ei0o7kwtbhJVjObJG0w== X-Received: by 10.80.201.77 with SMTP id p13mr3957533edh.33.1511384178865; Wed, 22 Nov 2017 12:56:18 -0800 (PST) Original-Received: from localhost ([134.226.214.245]) by smtp.gmail.com with ESMTPSA id z10sm1450538edm.68.2017.11.22.12.56.17 for <29405@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 22 Nov 2017 12:56:17 -0800 (PST) In-Reply-To: (GNU bug Tracking System's message of "Wed, 22 Nov 2017 20:49:02 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:140251 Archived-At: --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-lisp-gnus-message.el-Fix-message-faces-docs.patch Content-Description: Doc fixes >From 9191964406f3864ee7dc8e67b8a2d57f72247505 Mon Sep 17 00:00:00 2001 From: "Basil L. Contovounesios" Date: Wed, 22 Nov 2017 20:04:59 +0000 Subject: [PATCH 1/3] ; * lisp/gnus/message.el: Fix message-faces docs. --- lisp/gnus/message.el | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lisp/gnus/message.el b/lisp/gnus/message.el index f6777c5e88..4bca4353ab 100644 --- a/lisp/gnus/message.el +++ b/lisp/gnus/message.el @@ -1434,7 +1434,7 @@ message-header-to (:foreground "MidnightBlue" :bold t)) (t (:bold t :italic t))) - "Face used for displaying From headers." + "Face used for displaying To headers." :group 'message-faces) ;; backward-compatibility alias (put 'message-header-to-face 'face-alias 'message-header-to) @@ -1464,7 +1464,7 @@ message-header-subject (:foreground "navy blue" :bold t)) (t (:bold t))) - "Face used for displaying subject headers." + "Face used for displaying Subject headers." :group 'message-faces) ;; backward-compatibility alias (put 'message-header-subject-face 'face-alias 'message-header-subject) @@ -1479,7 +1479,7 @@ message-header-newsgroups (:foreground "blue4" :bold t :italic t)) (t (:bold t :italic t))) - "Face used for displaying newsgroups headers." + "Face used for displaying Newsgroups headers." :group 'message-faces) ;; backward-compatibility alias (put 'message-header-newsgroups-face 'face-alias 'message-header-newsgroups) @@ -1494,7 +1494,7 @@ message-header-other (:foreground "steel blue")) (t (:bold t :italic t))) - "Face used for displaying newsgroups headers." + "Face used for displaying other headers." :group 'message-faces) ;; backward-compatibility alias (put 'message-header-other-face 'face-alias 'message-header-other) -- 2.15.0 --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0002-lisp-gnus-message.el-Use-define-obsolete-face-alias.patch Content-Description: Use define-obsolete-face-alias >From 51d1d18bf6d5af97b3b0de98b00e8a0556bc7fe6 Mon Sep 17 00:00:00 2001 From: "Basil L. Contovounesios" Date: Wed, 22 Nov 2017 20:08:09 +0000 Subject: [PATCH 2/3] * lisp/gnus/message.el: Use define-obsolete-face-alias. --- lisp/gnus/message.el | 50 ++++++++++++++++++++------------------------------ 1 file changed, 20 insertions(+), 30 deletions(-) diff --git a/lisp/gnus/message.el b/lisp/gnus/message.el index 4bca4353ab..c07faea789 100644 --- a/lisp/gnus/message.el +++ b/lisp/gnus/message.el @@ -1436,9 +1436,8 @@ message-header-to (:bold t :italic t))) "Face used for displaying To headers." :group 'message-faces) -;; backward-compatibility alias -(put 'message-header-to-face 'face-alias 'message-header-to) -(put 'message-header-to-face 'obsolete-face "22.1") +(define-obsolete-face-alias 'message-header-to-face + 'message-header-to "22.1") (defface message-header-cc '((((class color) @@ -1451,9 +1450,8 @@ message-header-cc (:bold t))) "Face used for displaying Cc headers." :group 'message-faces) -;; backward-compatibility alias -(put 'message-header-cc-face 'face-alias 'message-header-cc) -(put 'message-header-cc-face 'obsolete-face "22.1") +(define-obsolete-face-alias 'message-header-cc-face + 'message-header-cc "22.1") (defface message-header-subject '((((class color) @@ -1466,9 +1464,8 @@ message-header-subject (:bold t))) "Face used for displaying Subject headers." :group 'message-faces) -;; backward-compatibility alias -(put 'message-header-subject-face 'face-alias 'message-header-subject) -(put 'message-header-subject-face 'obsolete-face "22.1") +(define-obsolete-face-alias 'message-header-subject-face + 'message-header-subject "22.1") (defface message-header-newsgroups '((((class color) @@ -1481,9 +1478,8 @@ message-header-newsgroups (:bold t :italic t))) "Face used for displaying Newsgroups headers." :group 'message-faces) -;; backward-compatibility alias -(put 'message-header-newsgroups-face 'face-alias 'message-header-newsgroups) -(put 'message-header-newsgroups-face 'obsolete-face "22.1") +(define-obsolete-face-alias 'message-header-newsgroups-face + 'message-header-newsgroups "22.1") (defface message-header-other '((((class color) @@ -1496,9 +1492,8 @@ message-header-other (:bold t :italic t))) "Face used for displaying other headers." :group 'message-faces) -;; backward-compatibility alias -(put 'message-header-other-face 'face-alias 'message-header-other) -(put 'message-header-other-face 'obsolete-face "22.1") +(define-obsolete-face-alias 'message-header-other-face + 'message-header-other "22.1") (defface message-header-name '((((class color) @@ -1511,9 +1506,8 @@ message-header-name (:bold t))) "Face used for displaying header names." :group 'message-faces) -;; backward-compatibility alias -(put 'message-header-name-face 'face-alias 'message-header-name) -(put 'message-header-name-face 'obsolete-face "22.1") +(define-obsolete-face-alias 'message-header-name-face + 'message-header-name "22.1") (defface message-header-xheader '((((class color) @@ -1526,9 +1520,8 @@ message-header-xheader (:bold t))) "Face used for displaying X-Header headers." :group 'message-faces) -;; backward-compatibility alias -(put 'message-header-xheader-face 'face-alias 'message-header-xheader) -(put 'message-header-xheader-face 'obsolete-face "22.1") +(define-obsolete-face-alias 'message-header-xheader-face + 'message-header-xheader "22.1") (defface message-separator '((((class color) @@ -1541,9 +1534,8 @@ message-separator (:bold t))) "Face used for displaying the separator." :group 'message-faces) -;; backward-compatibility alias -(put 'message-separator-face 'face-alias 'message-separator) -(put 'message-separator-face 'obsolete-face "22.1") +(define-obsolete-face-alias 'message-separator-face + 'message-separator "22.1") (defface message-cited-text '((((class color) @@ -1556,9 +1548,8 @@ message-cited-text (:bold t))) "Face used for displaying cited text names." :group 'message-faces) -;; backward-compatibility alias -(put 'message-cited-text-face 'face-alias 'message-cited-text) -(put 'message-cited-text-face 'obsolete-face "22.1") +(define-obsolete-face-alias 'message-cited-text-face + 'message-cited-text "22.1") (defface message-mml '((((class color) @@ -1571,9 +1562,8 @@ message-mml (:bold t))) "Face used for displaying MML." :group 'message-faces) -;; backward-compatibility alias -(put 'message-mml-face 'face-alias 'message-mml) -(put 'message-mml-face 'obsolete-face "22.1") +(define-obsolete-face-alias 'message-mml-face + 'message-mml "22.1") (defun message-font-lock-make-header-matcher (regexp) (let ((form -- 2.15.0 --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0003-lisp-gnus-message.el-Modernise-face-spec-syntax.patch Content-Description: Modernise face spec syntax >From d58d4244d798536dba02ce9f1e4805306d497fde Mon Sep 17 00:00:00 2001 From: "Basil L. Contovounesios" Date: Wed, 22 Nov 2017 20:10:20 +0000 Subject: [PATCH 3/3] * lisp/gnus/message.el: Modernise face spec syntax. --- lisp/gnus/message.el | 60 ++++++++++++++++++++++++++-------------------------- 1 file changed, 30 insertions(+), 30 deletions(-) diff --git a/lisp/gnus/message.el b/lisp/gnus/message.el index c07faea789..1db3f81f36 100644 --- a/lisp/gnus/message.el +++ b/lisp/gnus/message.el @@ -1428,12 +1428,12 @@ message-mode-syntax-table (defface message-header-to '((((class color) (background dark)) - (:foreground "DarkOliveGreen1" :bold t)) + :foreground "DarkOliveGreen1" :bold t) (((class color) (background light)) - (:foreground "MidnightBlue" :bold t)) + :foreground "MidnightBlue" :bold t) (t - (:bold t :italic t))) + :bold t :italic t)) "Face used for displaying To headers." :group 'message-faces) (define-obsolete-face-alias 'message-header-to-face @@ -1442,12 +1442,12 @@ 'message-header-to-face (defface message-header-cc '((((class color) (background dark)) - (:foreground "chartreuse1" :bold t)) + :foreground "chartreuse1" :bold t) (((class color) (background light)) - (:foreground "MidnightBlue")) + :foreground "MidnightBlue") (t - (:bold t))) + :bold t)) "Face used for displaying Cc headers." :group 'message-faces) (define-obsolete-face-alias 'message-header-cc-face @@ -1456,12 +1456,12 @@ 'message-header-cc-face (defface message-header-subject '((((class color) (background dark)) - (:foreground "OliveDrab1")) + :foreground "OliveDrab1") (((class color) (background light)) - (:foreground "navy blue" :bold t)) + :foreground "navy blue" :bold t) (t - (:bold t))) + :bold t)) "Face used for displaying Subject headers." :group 'message-faces) (define-obsolete-face-alias 'message-header-subject-face @@ -1470,12 +1470,12 @@ 'message-header-subject-face (defface message-header-newsgroups '((((class color) (background dark)) - (:foreground "yellow" :bold t :italic t)) + :foreground "yellow" :bold t :italic t) (((class color) (background light)) - (:foreground "blue4" :bold t :italic t)) + :foreground "blue4" :bold t :italic t) (t - (:bold t :italic t))) + :bold t :italic t)) "Face used for displaying Newsgroups headers." :group 'message-faces) (define-obsolete-face-alias 'message-header-newsgroups-face @@ -1484,12 +1484,12 @@ 'message-header-newsgroups-face (defface message-header-other '((((class color) (background dark)) - (:foreground "VioletRed1")) + :foreground "VioletRed1") (((class color) (background light)) - (:foreground "steel blue")) + :foreground "steel blue") (t - (:bold t :italic t))) + :bold t :italic t)) "Face used for displaying other headers." :group 'message-faces) (define-obsolete-face-alias 'message-header-other-face @@ -1498,12 +1498,12 @@ 'message-header-other-face (defface message-header-name '((((class color) (background dark)) - (:foreground "green")) + :foreground "green") (((class color) (background light)) - (:foreground "cornflower blue")) + :foreground "cornflower blue") (t - (:bold t))) + :bold t)) "Face used for displaying header names." :group 'message-faces) (define-obsolete-face-alias 'message-header-name-face @@ -1512,12 +1512,12 @@ 'message-header-name-face (defface message-header-xheader '((((class color) (background dark)) - (:foreground "DeepSkyBlue1")) + :foreground "DeepSkyBlue1") (((class color) (background light)) - (:foreground "blue")) + :foreground "blue") (t - (:bold t))) + :bold t)) "Face used for displaying X-Header headers." :group 'message-faces) (define-obsolete-face-alias 'message-header-xheader-face @@ -1526,12 +1526,12 @@ 'message-header-xheader-face (defface message-separator '((((class color) (background dark)) - (:foreground "LightSkyBlue1")) + :foreground "LightSkyBlue1") (((class color) (background light)) - (:foreground "brown")) + :foreground "brown") (t - (:bold t))) + :bold t)) "Face used for displaying the separator." :group 'message-faces) (define-obsolete-face-alias 'message-separator-face @@ -1540,12 +1540,12 @@ 'message-separator-face (defface message-cited-text '((((class color) (background dark)) - (:foreground "LightPink1")) + :foreground "LightPink1") (((class color) (background light)) - (:foreground "red")) + :foreground "red") (t - (:bold t))) + :bold t)) "Face used for displaying cited text names." :group 'message-faces) (define-obsolete-face-alias 'message-cited-text-face @@ -1554,12 +1554,12 @@ 'message-cited-text-face (defface message-mml '((((class color) (background dark)) - (:foreground "MediumSpringGreen")) + :foreground "MediumSpringGreen") (((class color) (background light)) - (:foreground "ForestGreen")) + :foreground "ForestGreen") (t - (:bold t))) + :bold t)) "Face used for displaying MML." :group 'message-faces) (define-obsolete-face-alias 'message-mml-face -- 2.15.0 --=-=-= Content-Type: text/plain Sorry, here are the three promised patches. -- Basil --=-=-=--