From: Alex Branham <alex.branham@gmail.com>
To: Glenn Morris <rgm@gnu.org>
Cc: 29608@debbugs.gnu.org
Subject: bug#29608: python.el movement functions
Date: Fri, 08 Dec 2017 15:37:15 -0600 [thread overview]
Message-ID: <87mv2syk8k.fsf@gmail.com> (raw)
In-Reply-To: <5refo5xfvn.fsf@fencepost.gnu.org>
On Fri 08 Dec 2017 at 17:56, Glenn Morris <rgm@gnu.org> wrote:
> Alex Branham wrote:
>
>> Python movement statements do not always result in the behavior I'd
>> expect. Consider this python file (with (|) representing point):
>>
>> (|)for i in [1, 2, 3]:
>> print(i)
>>
>> I'd expect M-x python-nav-forward-statement to result in
>>
>> for i in [1, 2, 3]:
>> print(i)
>> (|)
>>
>> but instead you wind up with
>>
>> for i in [1, 2, 3]:
>> (|)print(i)
>
> The actual result seems reasonable to me?
I'd argue that a "statement" should contain a whole logically valid statement, but I see your point.
>
>> and python-nav-forward-block (bound to M-e) is even worse. It results
>> in point not moving at all:
>>
>> (|)for i in [1, 2, 3]:
>> print(i)
>
> It seems that you disagree with python.el's definition of "statement" and
> "block". Eg the block definition seems to be:
>
> (defconst python-rx-constituents
> `((block-start . ,(rx symbol-start
> (or "def" "class" "if" "elif" "else" "try"
> "except" "finally" "for" "while" "with"
> ;; Python 3.5+ PEP492
> (and "async" (+ space)
> (or "def" "for" "with")))
> symbol-end))
Shouldn't python-nav-forward-block actually navigate forward, though?
And if we're on the last block in the buffer, just leave point at the
end?
This might be off-topic, but what I'm trying to do is to write a function that I can bind so that C-<return> acts like it does in ESS where you can continue to hit it and it will eventually evaluate everything in the buffer. Here's what I have so far:
(defun python-shell-send-region-or-statement ()
"Send the current region to the inferior python process if there is an active one, otherwise the current line."
(interactive)
(if (use-region-p)
(python-shell-send-region (region-beginning) (region-end))
(python-shell-send-statement)))
(defun python-shell-send-statement ()
"Send the current line to the inferior python process for evaluation."
(interactive)
(save-excursion
(let ((end (python-nav-end-of-statement))
(beginning (python-nav-beginning-of-statement)))
(python-shell-send-region beginning end))))
(defun python-shell-send-region-or-statement-and-step ()
"Call `python-shell-send-region-or-statement' and then `python-nav-forward-statement'."
(interactive)
(python-shell-send-region-or-statement)
(python-nav-forward-statement))
next prev parent reply other threads:[~2017-12-08 21:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-07 21:08 bug#29608: python.el movement functions Alex Branham
2017-12-08 17:56 ` Glenn Morris
2017-12-08 21:37 ` Alex Branham [this message]
2021-06-26 14:13 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mv2syk8k.fsf@gmail.com \
--to=alex.branham@gmail.com \
--cc=29608@debbugs.gnu.org \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.