From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alex Branham Newsgroups: gmane.emacs.bugs Subject: bug#30213: 26.0.91; shell buffer not displayed when not erased and async-shell-command-display-buffer is used Date: Tue, 23 Jan 2018 13:07:52 -0600 Message-ID: <87mv14tmuv.fsf@gmail.com> References: <87a7x5ejsu.fsf@gmail.com> <878tcpfmnz.fsf@tcd.ie> <87607s62zt.fsf@gmail.com> <874lnc62sj.fsf@gmail.com> <877es8xv8m.fsf@tcd.ie> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1516734452 1326 195.159.176.226 (23 Jan 2018 19:07:32 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 23 Jan 2018 19:07:32 +0000 (UTC) User-Agent: mu4e 0.9.18; emacs 26.0.91 Cc: 30213@debbugs.gnu.org To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jan 23 20:07:28 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ee3uW-0007Hx-TR for geb-bug-gnu-emacs@m.gmane.org; Tue, 23 Jan 2018 20:07:09 +0100 Original-Received: from localhost ([::1]:47009 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ee3wV-0000ZN-NT for geb-bug-gnu-emacs@m.gmane.org; Tue, 23 Jan 2018 14:09:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37542) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ee3wQ-0000ZD-0B for bug-gnu-emacs@gnu.org; Tue, 23 Jan 2018 14:09:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ee3wM-000525-0W for bug-gnu-emacs@gnu.org; Tue, 23 Jan 2018 14:09:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60241) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ee3wL-00051r-R8 for bug-gnu-emacs@gnu.org; Tue, 23 Jan 2018 14:09:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ee3wL-00060r-JF for bug-gnu-emacs@gnu.org; Tue, 23 Jan 2018 14:09:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alex Branham Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 23 Jan 2018 19:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30213 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30213-submit@debbugs.gnu.org id=B30213.151673448223040 (code B ref 30213); Tue, 23 Jan 2018 19:09:01 +0000 Original-Received: (at 30213) by debbugs.gnu.org; 23 Jan 2018 19:08:02 +0000 Original-Received: from localhost ([127.0.0.1]:39905 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ee3vO-0005zY-IX for submit@debbugs.gnu.org; Tue, 23 Jan 2018 14:08:02 -0500 Original-Received: from mail-ot0-f178.google.com ([74.125.82.178]:43792) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ee3vM-0005z3-31 for 30213@debbugs.gnu.org; Tue, 23 Jan 2018 14:08:01 -0500 Original-Received: by mail-ot0-f178.google.com with SMTP id p36so1391640otd.10 for <30213@debbugs.gnu.org>; Tue, 23 Jan 2018 11:08:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=Xs/9Fm7XdhMuhSHIdcMCZINjSqTvPyv7eDjNsbcbuXo=; b=kz4rSJ9LWVGpYipPo7bd67y4OVq+5QDC2uHU8ohZzyw2nqpTbc1uRj2mi36O7xk1dq AfiIXJTX3jtK22Dg6WvWCYs2mVEPzSFPv3HDpfpXzQyxPgJQdnTaDCjePvtDQ8tPD9pc am1cZ7PBpJIKEFJa3vqMT3eJJ8P52OzBueAx6Y/RREQsFVOJRNaAUfA1TLmaLmoDT/2v eQooyoh2RKTI4GbGt+J9K6h8GDk2w4GB1sUlwvuUhwRQdwSVWaL6+lR3Y299hgxGGwAG KYyVJJH6XFD8vkOQqV71fWF+jBUgKlHowb0ryfhBxb9VLvw9e89AAEoh+w4Yr9JuGybg V2Fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=Xs/9Fm7XdhMuhSHIdcMCZINjSqTvPyv7eDjNsbcbuXo=; b=RMDFSD1u1QGX+nQeQ3xO4qTNNUWAbRDEOgfclP1/tbcC2VZMeUA9aju7ItC2WFg9wc 1XT1HgbjNR5KHTAm8S2nN6DJf08d1I/doW2i1BklyFeeswxrH2/eVJ6sa/7+Rqxte5WQ lFwo/fLTQt+EwLEQrpX4IcNMht7kfp10F7FoYhB4hFY9jgYgc+zWYdBKI2/X3WgfYYVM y9BjK2RQML5P53mTlj+UOEqxAAZUPFPW2L/b9NtEefDc9p/CukI+WvTfhky0bCV88jCA /RKHhcgZKtTHKyoN3unNkABgZRJSt8CvpsW56+UE1Xl9bP7jPlEdsv3+w09uj8rmlgA0 SJ9g== X-Gm-Message-State: AKwxytd2zYZOTcO10veeEmAvhUlIP/pyOrT92uYCeq6mCBdwx1rKTf9O 5PL4El7A+Q6GSCSZU4SvvKmlNEZL X-Google-Smtp-Source: AH8x226iJGdBX9//9RY6PRAcwLOr5s9OLE94/vYybmZA/NpIrAaneDLiaoUJWkPqq879gd3W+/YPvQ== X-Received: by 10.157.20.243 with SMTP id r48mr7277529otr.72.1516734474344; Tue, 23 Jan 2018 11:07:54 -0800 (PST) Original-Received: from earth (cpe-70-114-192-208.austin.res.rr.com. [70.114.192.208]) by smtp.gmail.com with ESMTPSA id q33sm467296otq.49.2018.01.23.11.07.53 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 23 Jan 2018 11:07:53 -0800 (PST) In-reply-to: <877es8xv8m.fsf@tcd.ie> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:142444 Archived-At: This seems to fix it for me, thanks! On Tue 23 Jan 2018 at 12:53, Basil L. Contovounesios wrote: > From c236ef15477a7d76ee0420794f149bbcafdc8798 Mon Sep 17 00:00:00 2001 > From: "Basil L. Contovounesios" > Date: Tue, 23 Jan 2018 18:18:04 +0000 > Subject: [PATCH] Fix deferred display of async shell-command buffer > > * lisp/simple.el (shell-command): Display async command buffer on > process output for every invocation, not just the first. (bug#30213) > --- > lisp/simple.el | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/lisp/simple.el b/lisp/simple.el > index 3ac6b86381..20e22bf98f 100644 > --- a/lisp/simple.el > +++ b/lisp/simple.el > @@ -3551,9 +3551,7 @@ shell-command > (add-function :before (process-filter proc) > (lambda (process _string) > (let ((buf (process-buffer process))) > - (when (and (zerop (buffer-size buf)) > - (string= (buffer-name buf) > - bname)) > + (when (string= (buffer-name buf) bname) > (display-buffer buf)))))))) > ;; Otherwise, command is executed synchronously. > (shell-command-on-region (point) (point) command > -- > 2.15.1 > > > Alex Branham writes: > >> I'm sorry, haven't had my morning coffee yet. I can reproduce this, but there >> was an error in my initial email. From emacs -Q >> >> (setq shell-command-dont-erase-buffer 'beg-last-out >> async-shell-command-display-buffer nil) >> >> then do an async shell command, delete the window that shows the output, then >> call another async shell command. The window is never re-shown. > > Thanks, I'm able to reproduce this on both emacs-26 and master branches > and believe the attached patch fixes the issue.