From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#30215: Visiting files from zip archives should not modify directory time Date: Thu, 25 Jan 2018 23:41:10 +0200 Organization: LINKOV.NET Message-ID: <87mv114nwp.fsf@mail.linkov.net> References: <87mv157e8f.fsf@mail.linkov.net> <83h8rco7cg.fsf@gnu.org> <87tvvc8ds1.fsf@mail.linkov.net> <83zi53m6za.fsf@gnu.org> <87efmfuegl.fsf@mail.linkov.net> <83o9limx84.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1516916650 30344 195.159.176.226 (25 Jan 2018 21:44:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 25 Jan 2018 21:44:10 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: 30215-done@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jan 25 22:44:05 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eepJC-0006UK-Mh for geb-bug-gnu-emacs@m.gmane.org; Thu, 25 Jan 2018 22:43:46 +0100 Original-Received: from localhost ([::1]:38458 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eepLD-0003cj-Bt for geb-bug-gnu-emacs@m.gmane.org; Thu, 25 Jan 2018 16:45:51 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44409) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eepKT-0003Cm-JR for bug-gnu-emacs@gnu.org; Thu, 25 Jan 2018 16:45:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eepKR-0006BB-JB for bug-gnu-emacs@gnu.org; Thu, 25 Jan 2018 16:45:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35003) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eepKR-0006B5-Ff for bug-gnu-emacs@gnu.org; Thu, 25 Jan 2018 16:45:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eepKR-0002VH-8k for bug-gnu-emacs@gnu.org; Thu, 25 Jan 2018 16:45:03 -0500 Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Jan 2018 21:45:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 30215 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 30215@debbugs.gnu.org, juri@linkov.net, juri@linkov.net Original-Received: via spool by 30215-done@debbugs.gnu.org id=D30215.15169166509520 (code D ref 30215); Thu, 25 Jan 2018 21:45:03 +0000 Original-Received: (at 30215-done) by debbugs.gnu.org; 25 Jan 2018 21:44:10 +0000 Original-Received: from localhost ([127.0.0.1]:42896 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eepJZ-0002TU-OL for submit@debbugs.gnu.org; Thu, 25 Jan 2018 16:44:09 -0500 Original-Received: from sub3.mail.dreamhost.com ([69.163.253.7]:48855 helo=homiemail-a18.g.dreamhost.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eepJY-0002TK-RP for 30215-done@debbugs.gnu.org; Thu, 25 Jan 2018 16:44:09 -0500 Original-Received: from homiemail-a18.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a18.g.dreamhost.com (Postfix) with ESMTP id 5B9F8258068; Thu, 25 Jan 2018 13:44:08 -0800 (PST) Original-Received: from localhost.linkov.net (m91-129-109-224.cust.tele2.ee [91.129.109.224]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by homiemail-a18.g.dreamhost.com (Postfix) with ESMTPSA id 687CF258066; Thu, 25 Jan 2018 13:44:07 -0800 (PST) In-Reply-To: <83o9limx84.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 25 Jan 2018 05:30:19 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:142523 Archived-At: >> > If that's the problem, then I think it would be cleaner to disable >> > creation of lock files and backup files by less subtle means -- by >> > let-binding create-lockfiles and make-backup-files. Doing that by >> > leaving buffer-file-truename at nil leaves the code less clear IMO, >> > and relies on assumptions that might not hold at some future point. >> >> Thanks for the suggestion, this is better indeed: >> >> diff --git a/lisp/arc-mode.el b/lisp/arc-mode.el >> index adb3669..4fe1b03 100644 >> --- a/lisp/arc-mode.el >> +++ b/lisp/arc-mode.el >> @@ -807,7 +807,7 @@ archive-summarize >> Optional argument SHUT-UP, if non-nil, means don't print messages >> when parsing the archive." >> (widen) >> - (let ((buffer-file-truename nil) ; avoid changing dir mtime by lock_file >> + (let ((create-lockfiles nil) ; avoid changing dir mtime by lock_file > > This LGTM, Installed. > but wasn't the problem also with creation of a backup file? Creation of a backup file is not a problem, because backups are created on saving. Visiting a file from a zip archive doesn't save it, and thus doesn't create a backup. But when the user explicitly saves a file inside a zip archive, only then it should modify the time of its directory.