From: "Sebastian Reuße" <seb@wirrsal.net>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Fix alphabetic sorting for headlines, tags
Date: Mon, 12 Feb 2018 09:44:03 +0100 [thread overview]
Message-ID: <87mv0eiomk.fsf@wirrsal.net> (raw)
In-Reply-To: <87bmgvbiiq.fsf@nicolasgoaziou.fr>
Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
> Sebastian Reuße <seb@wirrsal.net> writes:
>
>> I also considered adding a regression test for non-ASCII chars to
>> «test-org/sort-entries», but for stable results, one would have to
>> enforce some canonical locale. Unfortunately, it’s not possible to
>> change the locale at Emacs run-time; Emacs only seems to call
>> «setlocale()» once during initialization, so «wcscoll()» always collates
>> according to the initial value of «LC_COLLATE». A regression test would
>> thus require changes to the Makefile, and tests might yield different
>> results when run from inside an existing Emacs process, so I left the
>> «sort-entries» test as is.
>
> It should be possible to redefine `string-collate-lessp', using
> `cl-letf' so that is uses different locales as the optional argument.
> WDYT?
That would work. Though it does tie up the test with an
implementation-detail. Still, probably better than no regression test at
all.
The test will error out if the data for the chosen locale isn’t actually
present on the system. I chose the «en_US» locale in the hopes that this
will frequently be installed. I’ll leave it up to you to decide whether
that is acceptable.
> The patch looks good. Thank you. It would be good to add an entry in
> ORG-NEWS about it, however.
Added.
> Then we can improve `org-table-sort-lines' accordingly. It can be done
> in another patch, tho.
That’s a good idea, I’ll look into it if I have some time by the end of
the week.
Kind regards,
SR
--
Insane cobra split the wood
Trader of the lowland breed
Call a jittney, drive away
In the slipstream we will stay
next prev parent reply other threads:[~2018-02-12 8:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-06 10:07 [PATCH] Fix alphabetic sorting for headlines, tags Sebastian Reuße
2018-02-10 13:02 ` Nicolas Goaziou
2018-02-11 11:11 ` Sebastian Reuße
2018-02-11 16:25 ` Nicolas Goaziou
2018-02-12 8:44 ` Sebastian Reuße [this message]
2018-02-12 14:03 ` Nicolas Goaziou
2018-02-12 14:54 ` Sebastian Reuße
2018-02-12 15:47 ` Nicolas Goaziou
2018-02-12 8:46 ` Sebastian Reuße
2018-02-12 13:59 ` Nicolas Goaziou
2018-02-11 11:13 ` Sebastian Reuße
-- strict thread matches above, loose matches on Subject: below --
2018-02-06 8:57 Sebastian Reuße
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mv0eiomk.fsf@wirrsal.net \
--to=seb@wirrsal.net \
--cc=emacs-orgmode@gnu.org \
--cc=mail@nicolasgoaziou.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.