Cherrypicking commit e08de2bae2a8e91c0245259dfcbfdca1d191a119 onto emacs-26

Cherrypicking commit e08de2bae2a8e91c0245259dfcbfdca1d191a119 onto emacs-26

[Philipp Stephani]

[-- Attachment #1: Type: text/plain, Size: 246 bytes --]

Hi,

would it be OK to cherrypick commit
e08de2bae2a8e91c0245259dfcbfdca1d191a119 onto the release branch? It fixes
a bug that makes filenotify watches essentially unusable with quoted
filenames, and is very short and localized.

Thanks,
Philipp

[-- Attachment #2: Type: text/html, Size: 326 bytes --]

Re: Cherrypicking commit e08de2bae2a8e91c0245259dfcbfdca1d191a119 onto emacs-26

[Eli Zaretskii]

> From: Philipp Stephani <p.stephani2@gmail.com>
> Date: Thu, 15 Mar 2018 18:34:27 +0000
> 
> would it be OK to cherrypick commit e08de2bae2a8e91c0245259dfcbfdca1d191a119 onto the release
> branch? It fixes a bug that makes filenotify watches essentially unusable with quoted filenames, and is very
> short and localized.

How can anything related to quoted file name be urgent to fix?

Re: Cherrypicking commit e08de2bae2a8e91c0245259dfcbfdca1d191a119 onto emacs-26

[Philipp Stephani]

[-- Attachment #1: Type: text/plain, Size: 1131 bytes --]

Eli Zaretskii <eliz@gnu.org> schrieb am Do., 15. März 2018 um 20:07 Uhr:

> > From: Philipp Stephani <p.stephani2@gmail.com>
> > Date: Thu, 15 Mar 2018 18:34:27 +0000
> >
> > would it be OK to cherrypick commit
> e08de2bae2a8e91c0245259dfcbfdca1d191a119 onto the release
> > branch? It fixes a bug that makes filenotify watches essentially
> unusable with quoted filenames, and is very
> > short and localized.
>
> How can anything related to quoted file name be urgent to fix?
>

Quoted filenames are a core Emacs function that is prominently documented,
see e.g.
https://www.gnu.org/software/emacs/manual/html_node/emacs/Quoted-File-Names.html.
They are also the only reliable method for external scripts and libraries
to ensure that Emacs doesn't mangle a local filename in unpredictable ways.
Therefore it's very important that quoted filenames are bugfree.
Perhaps even more importantly, that commit fixes a regression:
emacs -Q -batch -l filenotify --eval="(file-notify-rm-watch
(file-notify-add-watch \"/:/tmp/\" '(change) 'ignore))"
works in master and Emacs 25.2, but not with the release branch.

[-- Attachment #2: Type: text/html, Size: 1638 bytes --]

Re: Cherrypicking commit e08de2bae2a8e91c0245259dfcbfdca1d191a119 onto emacs-26

[Philipp Stephani]

Am Do., 15. März 2018 um 20:37 Uhr schrieb Philipp Stephani
<p.stephani2@gmail.com>:
>
>
>
> Eli Zaretskii <eliz@gnu.org> schrieb am Do., 15. März 2018 um 20:07 Uhr:
>>
>> > From: Philipp Stephani <p.stephani2@gmail.com>
>> > Date: Thu, 15 Mar 2018 18:34:27 +0000
>> >
>> > would it be OK to cherrypick commit e08de2bae2a8e91c0245259dfcbfdca1d191a119 onto the release
>> > branch? It fixes a bug that makes filenotify watches essentially unusable with quoted filenames, and is very
>> > short and localized.
>>
>> How can anything related to quoted file name be urgent to fix?
>
>
> Quoted filenames are a core Emacs function that is prominently documented, see e.g. https://www.gnu.org/software/emacs/manual/html_node/emacs/Quoted-File-Names.html. They are also the only reliable method for external scripts and libraries to ensure that Emacs doesn't mangle a local filename in unpredictable ways. Therefore it's very important that quoted filenames are bugfree.
> Perhaps even more importantly, that commit fixes a regression:
> emacs -Q -batch -l filenotify --eval="(file-notify-rm-watch (file-notify-add-watch \"/:/tmp/\" '(change) 'ignore))"
> works in master and Emacs 25.2, but not with the release branch.

Is it OK to cherrypick commit e08de2bae2a8e91c0245259dfcbfdca1d191a119
for Emacs 26.2? Thanks!

Re: Cherrypicking commit e08de2bae2a8e91c0245259dfcbfdca1d191a119 onto emacs-26

[Eli Zaretskii]

> From: Philipp Stephani <p.stephani2@gmail.com>
> Date: Tue, 25 Dec 2018 17:02:27 +0100
> Cc: Emacs developers <emacs-devel@gnu.org>
> 
> Is it OK to cherrypick commit e08de2bae2a8e91c0245259dfcbfdca1d191a119
> for Emacs 26.2? Thanks!

Yes, OK.

Re: Cherrypicking commit e08de2bae2a8e91c0245259dfcbfdca1d191a119 onto emacs-26

[Philipp Stephani]

Am Di., 25. Dez. 2018 um 18:24 Uhr schrieb Eli Zaretskii <eliz@gnu.org>:
>
> > From: Philipp Stephani <p.stephani2@gmail.com>
> > Date: Tue, 25 Dec 2018 17:02:27 +0100
> > Cc: Emacs developers <emacs-devel@gnu.org>
> >
> > Is it OK to cherrypick commit e08de2bae2a8e91c0245259dfcbfdca1d191a119
> > for Emacs 26.2? Thanks!
>
> Yes, OK.

Thanks, done (commit 08840f2f7b).

Re: Cherrypicking commit e08ed2bae2a8e91c0245259dfcbfdca1d191a119 onto emacs-26

[John Wiegley]

>>>>> "EZ" == Eli Zaretskii <eliz@gnu.org> writes:

EZ> How can anything related to quoted file name be urgent to fix?

If the fix is truly minor, this sounds important to fix before releasing 26.1.

-- 
John Wiegley                  GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com                          60E1 46C4 BD1A 7AC1 4BA2

Re: Cherrypicking commit e08ed2bae2a8e91c0245259dfcbfdca1d191a119 onto emacs-26

[Eli Zaretskii]

> From: "John Wiegley" <johnw@gnu.org>
> Cc: Philipp Stephani <p.stephani2@gmail.com>,  emacs-devel@gnu.org
> Date: Thu, 15 Mar 2018 12:48:29 -0700
> 
> >>>>> "EZ" == Eli Zaretskii <eliz@gnu.org> writes:
> 
> EZ> How can anything related to quoted file name be urgent to fix?
> 
> If the fix is truly minor, this sounds important to fix before releasing 26.1.

I don't think many people use quoted file names.  I'm sure Philipp can
patch his Emacs, if he needs this badly.  There's a reason why we
didn't push this to the release branch.

Re: Cherrypicking commit e08ed2bae2a8e91c0245259dfcbfdca1d191a119 onto emacs-26

[John Wiegley]

>>>>> Eli Zaretskii <eliz@gnu.org> writes:

> I don't think many people use quoted file names. I'm sure Philipp can patch
> his Emacs, if he needs this badly. There's a reason why we didn't push this
> to the release branch.

Actually, I constantly use quoted file names, because I have filenames with
spaces in them all over (for example, "~/Library/Application Support" is a
somewhat common prefix, or "~/Library/Mobile Documents").

-- 
John Wiegley                  GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com                          60E1 46C4 BD1A 7AC1 4BA2

Re: Cherrypicking commit e08ed2bae2a8e91c0245259dfcbfdca1d191a119 onto emacs-26

[Eli Zaretskii]

> From: John Wiegley <johnw@gnu.org>
> Cc: p.stephani2@gmail.com,  emacs-devel@gnu.org
> Date: Thu, 15 Mar 2018 16:54:58 -0700
> 
> >>>>> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > I don't think many people use quoted file names. I'm sure Philipp can patch
> > his Emacs, if he needs this badly. There's a reason why we didn't push this
> > to the release branch.
> 
> Actually, I constantly use quoted file names, because I have filenames with
> spaces in them all over (for example, "~/Library/Application Support" is a
> somewhat common prefix, or "~/Library/Mobile Documents").

Why do spaces require to quote file names?

You _are_ talking about quoting with prefix "/:", right?  Because this
is what this is about.

Re: Cherrypicking commit e08ed2bae2a8e91c0245259dfcbfdca1d191a119 onto emacs-26

[John Wiegley]

>>>>> Eli Zaretskii <eliz@gnu.org> writes:

> You _are_ talking about quoting with prefix "/:", right? Because this is
> what this is about.

Ah, no, I had understood something different. Never mind then, it can wait
until after the release.

-- 
John Wiegley                  GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com                          60E1 46C4 BD1A 7AC1 4BA2

Re: Cherrypicking commit e08ed2bae2a8e91c0245259dfcbfdca1d191a119 onto emacs-26

[Michael Albinus]

John Wiegley <johnw@gnu.org> writes:

> Ah, no, I had understood something different. Never mind then, it can wait
> until after the release.

This raises the question how we determine patches to be backported to
Emacs 26.2. I have no idea, but going through all closed bugs and/or all
commits to the master branch.

Best regards, Michael.

Re: Cherrypicking commit e08ed2bae2a8e91c0245259dfcbfdca1d191a119 onto emacs-26

[Eli Zaretskii]

> From: Michael Albinus <michael.albinus@gmx.de>
> Cc: p.stephani2@gmail.com,  emacs-devel@gnu.org
> Date: Fri, 16 Mar 2018 09:12:28 +0100
> 
> This raises the question how we determine patches to be backported to
> Emacs 26.2. I have no idea, but going through all closed bugs and/or all
> commits to the master branch.

Maybe we should have a file in admin that would list such commits.  Or
maybe we should have a special phrase in the commit log message.

Re: Cherrypicking commit e08ed2bae2a8e91c0245259dfcbfdca1d191a119 onto emacs-26

[Michael Albinus]

Eli Zaretskii <eliz@gnu.org> writes:

>> This raises the question how we determine patches to be backported to
>> Emacs 26.2. I have no idea, but going through all closed bugs and/or all
>> commits to the master branch.
>
> Maybe we should have a file in admin that would list such commits.  Or
> maybe we should have a special phrase in the commit log message.

The latter one is good for errors. See the Version: line we shall add
when committing something. Many people, including me, tend to forget it.

Another approach would be a staging branch, which collects such backport
candidates.

Best regards, Michael.