From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.devel Subject: Re: Heads-up: Emacs 26.1 RC1 Date: Tue, 20 Mar 2018 16:25:04 +0800 Message-ID: <87muz35f33.fsf@ericabrahamsen.net> References: <83605snjjt.fsf@gnu.org> <87605raoo9.fsf@killashandra.ballybran.fr> <83zi33n9ud.fsf@gnu.org> <87y3inalb5.fsf@killashandra.ballybran.fr> <83sh8vn7ss.fsf@gnu.org> <87r2of5las.fsf@ericabrahamsen.net> <83d0zzmd3b.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1521534350 27371 195.159.176.226 (20 Mar 2018 08:25:50 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 20 Mar 2018 08:25:50 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: johnw@gnu.org, emacs-devel@gnu.org, pierre.techoueyres@free.fr To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 20 09:25:46 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eyCaX-00070i-RN for ged-emacs-devel@m.gmane.org; Tue, 20 Mar 2018 09:25:45 +0100 Original-Received: from localhost ([::1]:46796 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyCcZ-0008RB-Gz for ged-emacs-devel@m.gmane.org; Tue, 20 Mar 2018 04:27:51 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35055) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyCcT-0008Qn-Em for emacs-devel@gnu.org; Tue, 20 Mar 2018 04:27:46 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eyCcS-0005Yj-CH for emacs-devel@gnu.org; Tue, 20 Mar 2018 04:27:45 -0400 Original-Received: from mail.ericabrahamsen.net ([50.56.99.223]:54498) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eyCcN-0005WJ-5O; Tue, 20 Mar 2018 04:27:39 -0400 Original-Received: from localhost (unknown [172.56.6.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 69389C0A0C; Tue, 20 Mar 2018 08:27:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mail.ericabrahamsen.net; s=mail; t=1521534458; bh=6ArX53UZIpGgc/vWfM7aaJu9CKdoLggK12tIOwtVL6w=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=oV6uCSUlwwDGYFwpS0rE0RKHcTnBmUISscMwcU/sXqe17YhujJPBLW/zh4UiphoB8 yEF31MgfHnFg6vS21LRNUZjv9O43QgXRr+YTm8DPlibqA9DHLcnU4pcrRo6DSZYFY6 fnYC76xa5vf5h4aH4PHrcoC+WkO5dZmF/SmPCfFM= In-Reply-To: <83d0zzmd3b.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 20 Mar 2018 09:16:08 +0200") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 50.56.99.223 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:223852 Archived-At: On 03/20/18 09:16 AM, Eli Zaretskii wrote: >> From: Eric Abrahamsen >> Cc: pierre.techoueyres@free.fr (Pierre T=C3=A9choueyres), >> johnw@gnu.org, emacs-devel@gnu.org >> Date: Tue, 20 Mar 2018 14:10:51 +0800 >>=20 >> >> Yes sorry I will do it next time. You have found the right message : >> >> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D29220#135 >> > >> > I'm okay with that if Eric agrees. >>=20 >> Yes! My apologies again for the slowness. I really wanted to get a grasp >> on CEDET and how it uses eieio-persist, to avoid causing more problems, >> but realistically I'm not going to get there anytime soon. Also, the >> fact that Pierre's tests fail exactly the same way with Emacs 25 and >> Emacs 26+fix indicate that CEDET has other issues that need resolving >> first. >>=20 >> What I would like to do is merge the fix/eieio-persistent branch. That >> has new tests from Pierre (Pierre, have you signed FSF papers?), more >> tests from me, and better error reporting for the restore process. The >> commits that actually "do something" are bf4f34ac7 and 1ea9947ca3189. >>=20 >> Is that okay? > > Ouch! Why are you waiting so long with such a large change? > > The changes in error/warning messages and in the test suite are okay > to go, but I'm worried by the 2 changes that add a condition (where > you went from (when ...) to (cond ...)). Is this really necessary, > and what problems do they solve? I know... Mostly it took so long because of testing. The test suite changes are there to test the new code, which directly models errors currently in the wild, and they can't go in by themselves. Very long story short, in Emacs 26 eieio objects went from being defined as vectors to being defined as objects. This messed up how they are serialized to disk using eieio-persistent. Two main consumers of eieio-persistent (pcache and the Gnus registry) are currently broken because of this. The `cond' statement is there to make sure that, in these two packages, the objects are written correctly to disk. >> If so, what's the proper merge strategy to use? > > It's up to you. You can either merge or rebase, we don't care (and I > don't want to get into a controversial discussion of which one is > better). I certainly don't have any opinion, I'd go with rebase, I guess. Sorry about this, Eric