From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#22649: [gmane.emacs.gnus.general] Re: M-g doesn't work with gnus-no-server Date: Thu, 12 Apr 2018 18:29:10 +0200 Message-ID: <87muy8qtgp.fsf@mouse.gnus.org> References: <87a8n5m63w.fsf-ueno@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: blaine.gmane.org 1523552283 7044 195.159.176.226 (12 Apr 2018 16:58:03 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 12 Apr 2018 16:58:03 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: 22649@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Apr 12 18:57:59 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f6fXq-0001gU-0W for geb-bug-gnu-emacs@m.gmane.org; Thu, 12 Apr 2018 18:57:58 +0200 Original-Received: from localhost ([::1]:54817 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f6fZw-000350-OK for geb-bug-gnu-emacs@m.gmane.org; Thu, 12 Apr 2018 13:00:08 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48379) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f6f6t-0006YZ-Dz for bug-gnu-emacs@gnu.org; Thu, 12 Apr 2018 12:30:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f6f6o-0006kp-EN for bug-gnu-emacs@gnu.org; Thu, 12 Apr 2018 12:30:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:40312) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f6f6o-0006ki-5x for bug-gnu-emacs@gnu.org; Thu, 12 Apr 2018 12:30:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1f6f6n-0004wi-RS for bug-gnu-emacs@gnu.org; Thu, 12 Apr 2018 12:30:01 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <87a8n5m63w.fsf-ueno@gnu.org> Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 12 Apr 2018 16:30:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22649 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 22649-submit@debbugs.gnu.org id=B22649.152355056918955 (code B ref 22649); Thu, 12 Apr 2018 16:30:01 +0000 Original-Received: (at 22649) by debbugs.gnu.org; 12 Apr 2018 16:29:29 +0000 Original-Received: from localhost ([127.0.0.1]:48209 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f6f6D-0004va-3I for submit@debbugs.gnu.org; Thu, 12 Apr 2018 12:29:28 -0400 Original-Received: from hermes.netfonds.no ([80.91.224.195]:57962) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f6f68-0004vQ-Nt for 22649@debbugs.gnu.org; Thu, 12 Apr 2018 12:29:24 -0400 Original-Received: from 46.67.12.60.tmi.telenormobil.no ([46.67.12.60] helo=corrigan) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1f6f64-0007Rt-Dy for 22649@debbugs.gnu.org; Thu, 12 Apr 2018 18:29:20 +0200 Original-Received: from larsi by corrigan with local (Exim 4.89) (envelope-from ) id 1f6f5y-0004yr-L3 for 22649@debbugs.gnu.org; Thu, 12 Apr 2018 18:29:10 +0200 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-Mailman-Approved-At: Thu, 12 Apr 2018 12:59:30 -0400 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:145171 Archived-At: --=-=-= Content-Type: message/rfc822 Content-Disposition: inline Path: news.gmane.org!not-for-mail From: Daiki Ueno Newsgroups: gmane.emacs.gnus.general Subject: Re: M-g doesn't work with gnus-no-server Date: Wed, 10 Feb 2016 13:20:58 +0900 Lines: 63 Approved: news@gmane.org Message-ID: References: <87fux5gr48.fsf@gnus.org> <877figaegr.fsf@linux-m68k.org> <87mvrcgzye.fsf-ueno@gnu.org> <87vb5zg52o.fsf@gnus.org> <87fux3eohi.fsf@gnus.org> <87a8n9790e.fsf@gnus.org> NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1455078136 8613 80.91.229.3 (10 Feb 2016 04:22:16 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 10 Feb 2016 04:22:16 +0000 (UTC) Cc: Andreas Schwab , ding@gnus.org To: Lars Ingebrigtsen Original-X-From: ding-owner+M35049@lists.math.uh.edu Wed Feb 10 05:22:04 2016 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from lists1.math.uh.edu ([129.7.128.208]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aTMI0-0007nd-1R for ding-account@gmane.org; Wed, 10 Feb 2016 05:22:04 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by lists1.math.uh.edu with smtp (Exim 4.85) (envelope-from ) id 1aTMHP-0001yK-3x; Tue, 09 Feb 2016 22:21:27 -0600 Original-Received: from mx1.math.uh.edu ([129.7.128.32]) by lists1.math.uh.edu with esmtps (TLSv1.2:AES128-GCM-SHA256:128) (Exim 4.85) (envelope-from ) id 1aTMHN-0001xk-2z for ding@lists.math.uh.edu; Tue, 09 Feb 2016 22:21:25 -0600 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx1.math.uh.edu with esmtps (TLSv1.2:DHE-RSA-AES128-SHA:128) (Exim 4.85) (envelope-from ) id 1aTMHI-00036I-UR for ding@lists.math.uh.edu; Tue, 09 Feb 2016 22:21:24 -0600 Original-Received: from eggs.gnu.org ([208.118.235.92]) by quimby.gnus.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.80) (envelope-from ) id 1aTMHF-0006ld-IU for ding@gnus.org; Wed, 10 Feb 2016 05:21:17 +0100 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aTMH4-00084T-4Z for ding@gnus.org; Tue, 09 Feb 2016 23:21:11 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54877) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTMH4-00084P-0g; Tue, 09 Feb 2016 23:21:06 -0500 Original-Received: from du-a.org ([219.94.251.20]:36541 helo=dhcp-217-92.nrt.redhat.com) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aTMH3-0001mS-7K; Tue, 09 Feb 2016 23:21:05 -0500 In-Reply-To: <87a8n9790e.fsf@gnus.org> (Lars Ingebrigtsen's message of "Wed, 10 Feb 2016 10:34:57 +1100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -8.2 (--------) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:86824 Archived-At: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="====-=-=" --====-=-= Content-Type: text/plain Content-Disposition: inline Lars Ingebrigtsen writes: >> * lisp/gnus/gnus-group.el: Don't call `gnus-request-group-scan' if >> server is not opened. > > Well, we want `M-g' to open the server if it isn't already... so > perhaps we should just call `gnus-activate-group'? I am not really sure if I get your suggestion, but how about this? Regards, -- Daiki Ueno --====-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-gnus-Make-M-g-work-with-gnus-no-server.patch >From d84b39a671f3c36634d92897205f3d812a64e9ba Mon Sep 17 00:00:00 2001 From: Daiki Ueno Date: Tue, 9 Feb 2016 17:37:59 +0900 Subject: [PATCH] gnus: Make M-g work with gnus-no-server * lisp/gnus/gnus-group.el: Divert to call `gnus-activate-group' with the SCAN argument set, if request-group-scan is not defined for the backend. Ensure that the server is open when calling `gnus-request-group-scan'. --- lisp/gnus/gnus-group.el | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/lisp/gnus/gnus-group.el b/lisp/gnus/gnus-group.el index 1cd16a4..5554569 100644 --- a/lisp/gnus/gnus-group.el +++ b/lisp/gnus/gnus-group.el @@ -4109,9 +4109,14 @@ gnus-group-get-new-news-this-group (gnus-group-remove-mark group) ;; Bypass any previous denials from the server. (gnus-remove-denial (setq method (gnus-find-method-for-group group))) - (if (or (and (not dont-scan) - (gnus-request-group-scan group (gnus-get-info group))) - (gnus-activate-group group (if dont-scan nil 'scan) nil method)) + (if (if (and (not dont-scan) + ;; Prefer request-group-scan if the backend supports it. + (gnus-check-backend-function 'request-group-scan group)) + (progn + ;; Ensure that the server is already open. + (gnus-activate-group group nil nil method) + (gnus-request-group-scan group (gnus-get-info group))) + (gnus-activate-group group (if dont-scan nil 'scan) nil method)) (let ((info (gnus-get-info group)) (active (gnus-active group))) (when info -- 2.5.0 --====-=-=-- --=-=-= Content-Type: text/plain -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no --=-=-=--