From: Noam Postavsky <npostavs@gmail.com>
To: Thomas Fitzsimmons <fitzsim@fitzsim.org>
Cc: Alex Harsanyi <alexharsanyi@gmail.com>, 31742@debbugs.gnu.org
Subject: bug#31742: 26.1.50; excorporate.elc byte-compiled in Emacs 25.x fails in Emacs 26.1
Date: Sat, 09 Jun 2018 08:13:03 -0400 [thread overview]
Message-ID: <87muw417lc.fsf@gmail.com> (raw)
In-Reply-To: <m3r2lg2qwy.fsf@fitzsim.org> (Thomas Fitzsimmons's message of "Sat, 09 Jun 2018 06:30:21 -0400")
>> The `(aref element 0)` trick is the only one that `soap-client` uses. All
>> other struct usage is via accessor functions, the rest of the code does not
>> assume they are vectors. It seems to me that `cl-old-struct-compat-mode` is
>> not needed.
> I went back and tested with cl-old-struct-compat-mode disabled, with the
> soap-type-of patch, and I get an earlier failure, via M-x excorporate:
> So at least for Excorporate, cl-old-struct-compat-mode is
> needed (in addition to the (aref ... 0) -> (soap-type-of ...)
> soap-client change).
Yeah, and for (type-of element) to properly substitute for (aref element
0) without cl-old-struct-compat-mode you would need
(defun soap-type-of (element)
"Return the type of ELEMENT."
(let ((type (type-of element)))
(unless (eq type 'vector) ; For Emacs 25 and earlier.
(setq type (aref element 0)))
(if (string-match "\\`cl-struct-" (symbol-name type)) ; Old-style struct.
(intern (substring (symbol-name type) (match-end 0)))
type)))
But since cl-old-struct-compat-mode activates automagically, may as well
take advantage of it.
prev parent reply other threads:[~2018-06-09 12:13 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-07 1:07 bug#31742: 26.1.50; excorporate.elc byte-compiled in Emacs 25.x fails in Emacs 26.1 Thomas Fitzsimmons
2018-06-07 1:14 ` Noam Postavsky
2018-06-07 2:01 ` Thomas Fitzsimmons
2018-06-07 12:21 ` Noam Postavsky
2018-06-07 14:06 ` Thomas Fitzsimmons
2018-06-07 17:36 ` Noam Postavsky
2018-06-08 1:13 ` Thomas Fitzsimmons
2018-06-08 1:57 ` Noam Postavsky
2018-06-08 2:17 ` Thomas Fitzsimmons
2018-06-08 12:19 ` Noam Postavsky
2018-06-08 14:18 ` Thomas Fitzsimmons
2018-06-09 0:01 ` Alex Harsanyi
2018-06-09 2:54 ` Thomas Fitzsimmons
2018-06-09 9:13 ` Alex Harsanyi
2018-06-09 10:32 ` Thomas Fitzsimmons
2018-06-12 1:55 ` Thomas Fitzsimmons
2018-06-12 17:11 ` Eli Zaretskii
2018-06-13 1:39 ` Thomas Fitzsimmons
2018-06-17 0:12 ` Alex Harsanyi
2018-06-17 0:36 ` Thomas Fitzsimmons
2018-06-17 1:31 ` Alex Harsanyi
2018-06-17 1:36 ` Noam Postavsky
2018-06-17 13:02 ` Thomas Fitzsimmons
2018-06-09 10:30 ` Thomas Fitzsimmons
2018-06-09 12:13 ` Noam Postavsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87muw417lc.fsf@gmail.com \
--to=npostavs@gmail.com \
--cc=31742@debbugs.gnu.org \
--cc=alexharsanyi@gmail.com \
--cc=fitzsim@fitzsim.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.