From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#31737: 26.1.50; Gnus does not use mailutils movemail Date: Thu, 14 Jun 2018 15:04:20 +0200 Message-ID: <87muvxa59n.fsf@gmail.com> References: <87sh5zk9br.fsf@gmail.com> <8736xzvgrg.fsf@yandex.com> <87o9gnk7vb.fsf@gmail.com> <831sdhuwc1.fsf@gnu.org> <87tvqdjmid.fsf@gmail.com> <83sh5xtaa5.fsf@gnu.org> <87602tjesm.fsf@gmail.com> <83muw5t78t.fsf@gnu.org> <871sddk9su.fsf@gmail.com> <83lgblqrir.fsf@gnu.org> <87sh5thu73.fsf@gmail.com> <83r2lcpwk3.fsf@gnu.org> <87o9gg7cue.fsf@yandex.com> <83lgbkoynn.fsf@gnu.org> <87efha93t6.fsf@gmail.com> <83d0wu4p0c.fsf@gnu.org> <87r2l9a7kr.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1528981397 15536 195.159.176.226 (14 Jun 2018 13:03:17 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 14 Jun 2018 13:03:17 +0000 (UTC) Cc: m43cap@yandex.com, larsi@gnus.org, 31737@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jun 14 15:03:12 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fTRuA-0003uA-88 for geb-bug-gnu-emacs@m.gmane.org; Thu, 14 Jun 2018 15:03:10 +0200 Original-Received: from localhost ([::1]:40464 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fTRwH-0006GX-5l for geb-bug-gnu-emacs@m.gmane.org; Thu, 14 Jun 2018 09:05:21 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38152) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fTRw4-0006D1-4O for bug-gnu-emacs@gnu.org; Thu, 14 Jun 2018 09:05:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fTRw0-0006Mc-6L for bug-gnu-emacs@gnu.org; Thu, 14 Jun 2018 09:05:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:39507) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fTRw0-0006MQ-2R for bug-gnu-emacs@gnu.org; Thu, 14 Jun 2018 09:05:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fTRvy-0000sn-2n for bug-gnu-emacs@gnu.org; Thu, 14 Jun 2018 09:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 Jun 2018 13:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31737 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31737-submit@debbugs.gnu.org id=B31737.15289814733356 (code B ref 31737); Thu, 14 Jun 2018 13:05:02 +0000 Original-Received: (at 31737) by debbugs.gnu.org; 14 Jun 2018 13:04:33 +0000 Original-Received: from localhost ([127.0.0.1]:47404 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fTRvT-0000s2-ON for submit@debbugs.gnu.org; Thu, 14 Jun 2018 09:04:32 -0400 Original-Received: from mail-wm0-f65.google.com ([74.125.82.65]:36097) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fTRvQ-0000rn-AJ for 31737@debbugs.gnu.org; Thu, 14 Jun 2018 09:04:30 -0400 Original-Received: by mail-wm0-f65.google.com with SMTP id v131-v6so11870794wma.1 for <31737@debbugs.gnu.org>; Thu, 14 Jun 2018 06:04:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:mail-copies-to:gmane-reply-to-list :date:in-reply-to:message-id:mime-version; bh=KHro4KhhRArhbPdPzrgx9/prEmkmlztcJT5cEVO97fM=; b=PYCbcNjWTFFQKbjfWjG4nBMjM0HF1LPE2vGtKGGbxmPMArmTUWXPhEfN2NStMkFMtV sa6tIBO8RFhhh1R9fg414+CXiONO1iKo4v4SqLFXyu1gUyd4NG8bHmypuPreo4alUeCA S9OkpEjkwKrdKf5xi8bWJGGpwi1wvQZdm228gy5Gd/ngBrLQQ7pKKlHrJSAsS0I6ZCqk JVzw+54U8HIger2zRSIXKqb7Qz+kHY+WoAZUTqHpbRu0u+AtqzW65Fx6v2Dm2Jpbc3yB wwTEVUCywsthT8wHQulyUgOtl/XaseIwsWL7x2WvyXp/MEHSOntAXuvfErgV9WLyR8Fu Dniw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:mime-version; bh=KHro4KhhRArhbPdPzrgx9/prEmkmlztcJT5cEVO97fM=; b=pShHyv5UTb3Q5gfwmUAkmr+M/4Gbofalbi7jjaeHykTpMEfYfeYGw4VRSNBdnbfr1W NR+hW9SxVATr3Rg1D0haSO1RdkndPQu5uKFtA+CfUrwDyf1g9r93Y+rOjUtBC6pf5Ked +iinzDQgO1GWI0aBehRFE+PIDmDeIYdMspDPzT4sB/aq8DO8bGhlGGlkXA4tWqEqHh2V JDmDexH5klqLBPMa3F2il4auDUo/Gk3M2+Dg7OQDOs06BDKQ/gQ4AnxAaMmvzwal24yo RqiOlhnA6NtvxV11CzptLHKjYObB4Y8fjf0FpcDo7Jt9QKuVvuIxer8TfC+NsMrV+hO9 qLvA== X-Gm-Message-State: APt69E3kSfd232H00USYEvNBG9LM66m5KdJrH3H+A/qEI4OL4KRgBZ45 R9axYF/zafcG9IEIIHxgsUUHoHiCVww= X-Google-Smtp-Source: ADUXVKKJKm7FLLZCAV8mVU9WarZiZbZqr6unu6/U/xeoTVlYuDgszpjqsDI+wopCYM4ChMO5zmSv2Q== X-Received: by 2002:a7b:c058:: with SMTP id u24-v6mr1860843wmc.136.1528981462169; Thu, 14 Jun 2018 06:04:22 -0700 (PDT) Original-Received: from rpluim ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id p38-v6sm12580581wrc.11.2018.06.14.06.04.21 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 14 Jun 2018 06:04:21 -0700 (PDT) Mail-Copies-To: never Gmane-Reply-To-List: yes In-Reply-To: <87r2l9a7kr.fsf@gmail.com> (Robert Pluim's message of "Thu, 14 Jun 2018 14:14:28 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:147401 Archived-At: Robert Pluim writes: > Eli Zaretskii writes: > >>> From: Robert Pluim >>> Cc: Eli Zaretskii , Colin Baxter , 31737@debbugs.gnu.org >>> Date: Wed, 13 Jun 2018 16:08:53 +0200 >>> >>> Eli, were you thinking that mail-source should duplicate the movemail >>> detection logic in rmail? Or should it just assume Mailutils movemail >>> and pass '--emacs'? >> >> The former. > > Something like this? Testing definitely required by someone who uses > mailutils movemail for Gnus. Not sure this is emacs-26 material > anymore. *sigh*. With the typo fixed now. diff --git i/lisp/gnus/mail-source.el w/lisp/gnus/mail-source.el index d2850f4cee..37bcb716f9 100644 --- i/lisp/gnus/mail-source.el +++ w/lisp/gnus/mail-source.el @@ -301,7 +301,7 @@ mail-source-idle-time-delay :group 'mail-source :type 'number) -(defcustom mail-source-movemail-program nil +(defcustom mail-source-movemail-program "movemail" "If non-nil, name of program for fetching new mail." :version "22.1" :group 'mail-source @@ -653,6 +653,12 @@ mail-source-delete-crash-box mail-source-delete-incoming mail-source-delete-old-incoming-confirm))))))) +(defun mail-source-movemail-variant-p (variant) + "Return t if the current movemail variant is VARIANT. +See `rmail-movemail-variant-p' for details" + (let ((rmail-movemail-program mail-source-movemail-program)) + (rmail-movemail-variant-p variant))) + (defun mail-source-movemail (from to) "Move FROM to TO using movemail." (if (not (file-writable-p to)) @@ -682,13 +688,20 @@ mail-source-movemail (setq errors (generate-new-buffer " *mail source loss*")) (let ((default-directory "/")) (setq result + ;; call-proces looks in exec-path, which + ;; contains exec-directory, so will find + ;; Mailutils movemail if it exists, else it will + ;; find "our" movemail in exec-directory. + ;; Bug#31737 (apply 'call-process (append (list - (or mail-source-movemail-program - (expand-file-name "movemail" exec-directory)) - nil errors nil from to))))) + mail-source-movemail-program + nil errors nil) + (when (mail-source-movemail-variant-p 'mailutils) + (list "--emacs")) + (list from to))))) (when (file-exists-p to) (set-file-modes to mail-source-default-file-modes)) (if (and (or (not (buffer-modified-p errors))