Re: emacs-26 19ed1e9 2/2: * lisp/net/trampver.el (customize-package-emacs-version-alist):

Re: emacs-26 19ed1e9 2/2: * lisp/net/trampver.el (customize-package-emacs-version-alist):

[Michael Albinus]

rgm@gnu.org (Glenn Morris) writes:

> branch: emacs-26
> commit 19ed1e9a5f51fc27d60062bd70432c41cd08b3c1
> Author: Glenn Morris <rgm@gnu.org>
> Commit: Glenn Morris <rgm@gnu.org>
>
>     * lisp/net/trampver.el (customize-package-emacs-version-alist):
>     Add 2.3.3.
>
> @@ -69,7 +69,7 @@
>  	 ("2.2.3-24.1" . "24.1") ("2.2.3-24.1" . "24.2") ("2.2.6-24.3" . "24.3")
>  	 ("2.2.9-24.4" . "24.4") ("2.2.11-24.5" . "24.5")
>  	 ("2.2.13.25.1" . "25.1") ("2.2.13.25.2" . "25.2")
> -	 ("2.2.13.25.2" . "25.3")
> +	 ("2.2.13.25.2" . "25.3") ("2.3.3" . "26.1")
>  	 ("2.3.3.26.1" . "26.1") ("2.3.5.26.2" . "26.2")))

???

There is already the entry ("2.3.3.26.1" . "26.1"), which is correct. Thinko?

Best regards, Michael.

Re: emacs-26 19ed1e9 2/2: * lisp/net/trampver.el (customize-package-emacs-version-alist):

[Glenn Morris]

Hi, it was to avoid this:

(customize-changed "26.1")
tramp-syntax version 2.3.3 not found in customize-package-emacs-version-alist

Re: emacs-26 19ed1e9 2/2: * lisp/net/trampver.el (customize-package-emacs-version-alist):

[Michael Albinus]

Glenn Morris <rgm@gnu.org> writes:

Hi Glenn,

> Hi, it was to avoid this:
>
> (customize-changed "26.1")
> tramp-syntax version 2.3.3 not found in customize-package-emacs-version-alist

But this information is incorrect. There exists a Tramp release 2.3.3,
and this is *not* the Tramp version integrated into Emacs 26.1. I'd like
to keep the difference.

And I don't understand the error message at all. What does it tell me?
And where does it come from? I don't get it, when evalling that form
from "emacs -Q".

Best regards, Michael.

Re: emacs-26 19ed1e9 2/2: * lisp/net/trampver.el (customize-package-emacs-version-alist):

[Glenn Morris]

Michael Albinus wrote:

>> (customize-changed "26.1")
>> tramp-syntax version 2.3.3 not found in customize-package-emacs-version-alist
>
> But this information is incorrect. There exists a Tramp release 2.3.3,
> and this is *not* the Tramp version integrated into Emacs 26.1.

That is not how I interpret that variable. I take it to mean "if you are
looking at a change which first appeared in Tramp 2.3.3, then the first
Emacs release containing it was 26.1"; not "Tramp 2.3.3 is the version
in Emacs 26.1". I think the example in the doc string, where multiple
MH-E versions map to the same Emacs version, bears this out.

> And where does it come from? I don't get it, when evalling that form
> from "emacs -Q".

I don't know how to explain that (I assume you reverted 19ed1e9 and
rebuilt before testing?).

Re: emacs-26 19ed1e9 2/2: * lisp/net/trampver.el (customize-package-emacs-version-alist):

[Michael Albinus]

Glenn Morris <rgm@gnu.org> writes:

>>> (customize-changed "26.1")
>>> tramp-syntax version 2.3.3 not found in customize-package-emacs-version-alist
>>
>> But this information is incorrect. There exists a Tramp release 2.3.3,
>> and this is *not* the Tramp version integrated into Emacs 26.1.
>
> That is not how I interpret that variable. I take it to mean "if you are
> looking at a change which first appeared in Tramp 2.3.3, then the first
> Emacs release containing it was 26.1"; not "Tramp 2.3.3 is the version
> in Emacs 26.1". I think the example in the doc string, where multiple
> MH-E versions map to the same Emacs version, bears this out.

What if I want to get something which was introduced in Tramp
2.3.3.26.1, but not contained in 2.3.3?

>> And where does it come from? I don't get it, when evalling that form
>> from "emacs -Q".
>
> I don't know how to explain that (I assume you reverted 19ed1e9 and
> rebuilt before testing?).

No revert/rebuild of the release branch. I'm using in the release branch

# git log lisp/net/trampver.el
commit 0d2bf76d3d8a9d05e3b9ff4228608aa446352e7e
Author: Michael Albinus <michael.albinus@gmx.de>
Date:   Thu Oct 11 09:39:12 2018 +0200

Best regards, Michael.

Re: emacs-26 19ed1e9 2/2: * lisp/net/trampver.el (customize-package-emacs-version-alist):

[Glenn Morris]

Michael Albinus wrote:

> What if I want to get something which was introduced in Tramp
> 2.3.3.26.1, but not contained in 2.3.3?

If by this you mean, how do you map 2.3.3.26.1 to an Emacs release, then
there is a separate entry in customize-package-emacs-version-alist
mapping that to 26.1.

(In an ideal world the customize machinery would be able to interpolate
between versions to figure out that eg if 25.3 contains 2.2.13.25.2 and
26.1 contains 2.3.3.26.1 then 26.1 must also contain all versions
between those two, but it doesn't do that.)

> No revert/rebuild of the release branch. I'm using in the release branch
>
> # git log lisp/net/trampver.el
> commit 0d2bf76d3d8a9d05e3b9ff4228608aa446352e7e

I can't explain it. (You are looking in *Messages*?)

Re: emacs-26 19ed1e9 2/2: * lisp/net/trampver.el (customize-package-emacs-version-alist):

[Michael Albinus]

Glenn Morris <rgm@gnu.org> writes:

>> No revert/rebuild of the release branch. I'm using in the release branch
>>
>> # git log lisp/net/trampver.el
>> commit 0d2bf76d3d8a9d05e3b9ff4228608aa446352e7e
>
> I can't explain it. (You are looking in *Messages*?)

Trying it again, I've seen it there. I could swear I've checked
*Messages* last time also, but who knows ...

Well, the problem is that `tramp-syntax' declares :package-version. It
isn't needed anywhere, I just thought "it couldn't hurt".

It hurts, and your patch is the best solution. I have added a comment to
the patch explaining it.

Thanks for the heads-up, and best regards, Michael.