From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#28691: [PATCH] Add file name handler support for 'make-process' (Bug#28691) Date: Sun, 23 Dec 2018 08:41:52 +0100 Message-ID: <87muowzo3j.fsf@gmx.de> References: <8336qwdixp.fsf@gnu.org> <20181217204746.53492-1-phst@google.com> <831s6aaq06.fsf@gnu.org> <87woo1j4az.fsf@gmx.de> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1545550867 22226 195.159.176.226 (23 Dec 2018 07:41:07 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 23 Dec 2018 07:41:07 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Philipp Stephani , 28691@debbugs.gnu.org To: Philipp Stephani Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Dec 23 08:41:03 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gayNi-0005eU-TV for geb-bug-gnu-emacs@m.gmane.org; Sun, 23 Dec 2018 08:41:03 +0100 Original-Received: from localhost ([::1]:41402 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gayPp-0000vw-18 for geb-bug-gnu-emacs@m.gmane.org; Sun, 23 Dec 2018 02:43:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36827) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gayPi-0000ve-Fl for bug-gnu-emacs@gnu.org; Sun, 23 Dec 2018 02:43:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gayPf-0003fK-Al for bug-gnu-emacs@gnu.org; Sun, 23 Dec 2018 02:43:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:56234) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gayPe-0003ej-ES for bug-gnu-emacs@gnu.org; Sun, 23 Dec 2018 02:43:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gayPe-0006Lw-AC for bug-gnu-emacs@gnu.org; Sun, 23 Dec 2018 02:43:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 23 Dec 2018 07:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28691 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 28691-submit@debbugs.gnu.org id=B28691.154555092724348 (code B ref 28691); Sun, 23 Dec 2018 07:43:02 +0000 Original-Received: (at 28691) by debbugs.gnu.org; 23 Dec 2018 07:42:07 +0000 Original-Received: from localhost ([127.0.0.1]:60492 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gayOk-0006Kd-Q6 for submit@debbugs.gnu.org; Sun, 23 Dec 2018 02:42:07 -0500 Original-Received: from mout.gmx.net ([212.227.17.21]:41401) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gayOi-0006K8-F4 for 28691@debbugs.gnu.org; Sun, 23 Dec 2018 02:42:04 -0500 Original-Received: from detlef.gmx.de ([212.86.57.189]) by mail.gmx.com (mrgmx101 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MUkxk-1gtfzB3LcC-00Y7YS; Sun, 23 Dec 2018 08:41:53 +0100 In-Reply-To: (Philipp Stephani's message of "Sat, 22 Dec 2018 22:08:30 +0100") X-Provags-ID: V03:K1:ybG1BpExj9bMaKpLBMunDxWdmgiX/d69yz429yjBAXYAx3xJGzJ 3w8J7pW1olDA9eT+6mY3zTckkS5ZGaiR0fvgMiNqIOdd505d96xvlDExgjHfNFZB1WXLYs6 VC9dQZqCz0TbtxJ8fLz93NrJ0VpLNWD56LDn0I0lS1UL7ioHeHnl17IHZ7bwL8DxfxYVwqY 4dw4jeuSCj5uYgqTIfAWw== X-UI-Out-Filterresults: notjunk:1;V03:K0:ioAfWeyHex0=:Phe8GV2rm6Jg9ZdjOV3Qjq xFSynU7XgmLaHl930EjIhwDibMrpYovb5E/mZnC2PXEpOLpi2gxicOaRgTJ0sSlT47ffdd8xe 2O/e59pW1GNM+e0OKUoNqjoUK1D025iORJ8E7/7KWPSLrcP6tZArRVgKZcwa54TC+AF/OTGAt Hq06E7F3pbLiPh7nhb43FGOwbKyo1Pbo/R3OKFhiYvyh5DnsEGYxPxiztLeYSx+u/UteY2dNj CTIyIowVIp3a0vzeWDfapmd76FIqQIkpHkOwMMnM3PAUdOzJ8A+nyytBQO4JDpZfZ4WaY9tgU C5MVk4LKFYV7qR5irsdwe3Als+2ROIRxIxyqhVXRlpRPj/m0Jgodr1OEMiXihevREU0q9vSZX i8+CEsSJ7abhpr9kqf5Y+1I/oEdtyLpcHtqInq+XAVwU0Ok6HnEB1vh9tRUGW+6CI5N//NOFb mWS60z1KmCqYowvXxM293UvnZZomRphBxxe4hY5XWoxJCQFQQr62AZRUz9ojS9DDg5xQb7ybs 3SAzquFdnbWrmyGpynJy8OfJvzmCf82er1wHPfXwvfWxpoo7oE1Qmh/ygdHbufqdnVFhRQifE 0WVfRw0jEThiAq9SP0Te3rMEyiPlEqUnhSmbQVFkjsIUko83aX5e+o4+bRlup3FMyQSNM2OAc zd0Cce6HYn+ldZmfJtFDJB+S8v89fsMI71LqkcW3CM3iK+te6zlJ2ymPHhiz/8AGYh9VJYFxU WFrh9GDoJdOzGhY125SeNBYFmJ7n2/B3Mol+Hd2aswbQ08IGdP8caiLcnoT+RkYV8Ur/oxEY X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:153772 Archived-At: Philipp Stephani writes: Hi Philipp, >> > this LGTM, >> >> Same here, but I still appreciate a clarification in the doc, that not >> all file name handlers will support this function, > > That isn't the case: > https://www.gnu.org/software/emacs/manual/html_node/elisp/Magic-File-Names.html > states clearly "The handler function must handle all of the above > operations, and possibly others to be added in the future." Tramp does *handle* all operations. But it does not *support* all of them. In case it is not possible to offer an implementation for `start-file-process' (as example), Tramp uses `ignore' as implementation. >> and they will return >> nil in that case. > > That is also not the case. If there's no handler, setting > :file-handler to t has no effect. That's the same as for > start-file-process, which calls start-process if no handler is found. Of course. I do not speak about this case. Tramp offers a handler, which will also supports `make-network-process'. This handler is called `tramp-file-name-handler', and you see it in `file-name-handler-alist'. But this handler could decide, that for a given connection method there's nothing to do. Remember the example I have shown already: --8<---------------cut here---------------start------------->8--- (with-temp-buffer (let ((default-directory "/ssh::")) (start-file-process "foo" (current-buffer) "/bin/true"))) => # (with-temp-buffer (let ((default-directory "/sftp::")) (start-file-process "foo" (current-buffer) "/bin/true"))) => nil --8<---------------cut here---------------end--------------->8--- "sftp" belongs to the connection methods implemented via GVFS, no external processes are possible. See `tramp-gvfs-file-name-handler-alist', many operations use `ignore' as their implementation. `make-network-process' will get a similar entry. Best regards, Michael.