From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: phillip.lord@russet.org.uk (Phillip Lord) Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 7b31de4: Add hook for all events Date: Mon, 28 Jan 2019 09:54:08 +0000 Message-ID: <87munlumyn.fsf@russet.org.uk> References: <20190122214637.25164.20429@vcs0.savannah.gnu.org> <20190122214639.B2E13203DD@vcs0.savannah.gnu.org> <40f2dac5-f342-b9f0-a792-796a6baf9a56@dancol.org> <87fttj55t8.fsf@russet.org.uk> <87k1iu2v8x.fsf@russet.org.uk> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="9360"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.90 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jan 28 11:12:01 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1go3tX-0002HX-6e for ged-emacs-devel@m.gmane.org; Mon, 28 Jan 2019 11:11:59 +0100 Original-Received: from localhost ([127.0.0.1]:57182 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1go3tW-0005j0-68 for ged-emacs-devel@m.gmane.org; Mon, 28 Jan 2019 05:11:58 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:40820) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1go3cO-00024W-C4 for emacs-devel@gnu.org; Mon, 28 Jan 2019 04:54:17 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1go3cM-0001cH-Te for emacs-devel@gnu.org; Mon, 28 Jan 2019 04:54:16 -0500 Original-Received: from cloud103.planethippo.com ([78.129.138.110]:44336) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1go3cK-0001b4-VA for emacs-devel@gnu.org; Mon, 28 Jan 2019 04:54:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=russet.org.uk; s=default; h=Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=CZgen17i6/zmF5YHtdNOKwaBmJMxNI5GysFZLneX1hw=; b=yBwlrBhcM2Kb/YcCSV/28Y0wU 83s49UDQO1KTQ/HWbOew4Ta29vveG7rVw3zmIov2cUZ9pEQ1naWfijdrNNg6mJoa9sOcFy4W2A0rB fzaKObT0VO2zDFkH1pPFJODQHhJVLzlTtXIwuY9evuM9CsnsWScxwrHQlxdSBQIG4SchVWTp8OmDv 8gA+RNXyrt2L87XGfxCQcTa3QNbpFr8IrjvLMYiqmq+x2M4Y0EDtzhEBliCR1GYDv42IbUhmU85jB 1AJy1rhwBHmzFU49MNhwOtxcu4o5wzI+juX1aOeD14yfVJWiooTPrhd6Ldvi9mr8q+hPBL19kLP5t 0aDd+pznw==; Original-Received: from cpc142652-benw12-2-0-cust953.16-2.cable.virginm.net ([82.21.43.186]:45312 helo=russet.org.uk) by cloud103.planethippo.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1go3cH-003xj3-7G; Mon, 28 Jan 2019 09:54:09 +0000 In-Reply-To: (Stefan Monnier's message of "Fri, 25 Jan 2019 19:50:33 -0500") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cloud103.planethippo.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - russet.org.uk X-Get-Message-Sender-Via: cloud103.planethippo.com: authenticated_id: phillip.lord@russet.org.uk X-Authenticated-Sender: cloud103.planethippo.com: phillip.lord@russet.org.uk X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 78.129.138.110 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:232756 Archived-At: Stefan Monnier writes: >> It also has a practical impact; it is not possible to complete when an >> input method is in the middle of the multi key press. So, for example, >> with italian-postfix you can no longer complete on a prefix ending in >> an "e" or and "i"; pressing "e" removes completion suggestions, but does >> not trigger adding them because "e" could be "e`". > > Hmm... this is a bummer (in some input methods, many/most chars are > prefixes of something else). IIUC this is not a new problem introduced > by the use of input-event-functions, tho, right? My experience is that completion doesn't work when an input method is half way through, although I only use simple input methods. Anyway, I checked (should have done this before I sent the last email, sorry). The buffer is not changed by an input method half way through (or at least "before-change-function" is not called, which I am assuming is the same thing). So, when the buffer appears to say "pizza_[`]", if it does offer a completion at all, it's going to offer one based on "pizz" because they "a" is not in the buffer. The ideal behaviour here would be to offer completions based on either "pizza" or "pizza`". Completion would then do the work of the input method also. I am guessing that this is would be non trivial to add. For sure, pabbrev and I guess company would have to work on what the user sees, not what is in the buffer; and this is likely to be wrong nearly as often as it is right. Phil