bug#34981: 27.0.50; gnus-group-select-group errors with wrong type argument

bug#34981: 27.0.50; gnus-group-select-group errors with wrong type argument

[Alex Branham]

I'm trying to start using gnus and perhaps ran into a bug. I'm trying to
view the emacs-devel mailing list through gnus, for starters.

From emacs -q, built from the latest git master (commit
03e916beb0186f3707cd238650298870bf471575):

(setq gnus-select-method
      '(nntp "gnus.user" (nntp-address "news.gmane.org")))

M-x gnus

A A (gnus-group-list-active)

C-s emacs.devel C-s

RET (gnus-group-select-group)

produces:

Debugger entered--Lisp error: (wrong-type-argument symbolp (827 . 234690))
  symbol-name((827 . 234690))
  gnus-group-group-name()
  redisplay_internal\ \(C\ function\)()
  redisplay()
  sit-for(2)
  execute-extended-command(nil "toggle-debug-on-error" "toggle-debug-on-error")
  funcall-interactively(execute-extended-command nil "toggle-debug-on-error" "toggle-debug-on-error")
  call-interactively(execute-extended-command nil nil)
  command-execute(execute-extended-command)


In GNU Emacs 27.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.5)
 of 2019-03-24 built on localhost
Windowing system distributor 'The X.Org Foundation', version 11.0.11906000
System Description: NixOS 18.09.2375.680f9d7ea90 (Jellyfish)

Configured features:
XPM JPEG TIFF GIF PNG RSVG SOUND DBUS GSETTINGS GLIB NOTIFY INOTIFY
LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB
TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS LIBSYSTEMD JSON
PDUMPER GMP

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

bug#34981: 27.0.50; gnus-group-select-group errors with wrong type argument

[Eric Abrahamsen]

Alex Branham <alex.branham@gmail.com> writes:

> I'm trying to start using gnus and perhaps ran into a bug. I'm trying to
> view the emacs-devel mailing list through gnus, for starters.
>
> From emacs -q, built from the latest git master (commit
> 03e916beb0186f3707cd238650298870bf471575):
>
> (setq gnus-select-method
>       '(nntp "gnus.user" (nntp-address "news.gmane.org")))
>
> M-x gnus
>
> A A (gnus-group-list-active)

Thanks for this report, I messed with Gnus recently and am now putting
out fires. This is a new error for me, and I'll try to fix it tonight.

bug#34981: 27.0.50; gnus-group-select-group errors with wrong type argument

[Eric Abrahamsen]

[-- Attachment #1: Type: text/plain, Size: 701 bytes --]

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

> Alex Branham <alex.branham@gmail.com> writes:
>
>> I'm trying to start using gnus and perhaps ran into a bug. I'm trying to
>> view the emacs-devel mailing list through gnus, for starters.
>>
>> From emacs -q, built from the latest git master (commit
>> 03e916beb0186f3707cd238650298870bf471575):
>>
>> (setq gnus-select-method
>>       '(nntp "gnus.user" (nntp-address "news.gmane.org")))
>>
>> M-x gnus
>>
>> A A (gnus-group-list-active)
>
> Thanks for this report, I messed with Gnus recently and am now putting
> out fires. This is a new error for me, and I'll try to fix it tonight.

Actually, here's a patch -- will you please try this out?


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: gnus-active-fix.patch --]
[-- Type: text/x-patch, Size: 1155 bytes --]

diff --git a/lisp/gnus/gnus-group.el b/lisp/gnus/gnus-group.el
index f1202e176e..8c2411f4d9 100644
--- a/lisp/gnus/gnus-group.el
+++ b/lisp/gnus/gnus-group.el
@@ -4029,7 +4029,7 @@ gnus-group-list-active
 		 (insert "       *: "
 			 (gnus-group-decoded-name group)
 			 "\n"))
-       (list 'gnus-group (gethash group gnus-active-hashtb)
+       (list 'gnus-group group
 	     'gnus-unread t
 	     'gnus-level (inline (gnus-group-level group)))))
     (goto-char (point-min))))
diff --git a/lisp/gnus/gnus-start.el b/lisp/gnus/gnus-start.el
index 82141e0221..5a78df9fe4 100644
--- a/lisp/gnus/gnus-start.el
+++ b/lisp/gnus/gnus-start.el
@@ -2145,9 +2145,12 @@ gnus-active-to-gnus-format
 	(condition-case ()
 	    (if (and (stringp (progn
 				(setq group (read cur)
-				      group (if (numberp group)
-						(number-to-string group)
-					      (symbol-name group)))))
+				      group (cond ((numberp group)
+						   (number-to-string group))
+						  ((symbolp group)
+						   (symbol-name group))
+						  ((stringp group)
+						   group)))))
 		     (numberp (setq max (read cur)))
 		     (numberp (setq min (read cur)))
 		     (null (progn

bug#34981: 27.0.50; gnus-group-select-group errors with wrong type argument

[Alex Branham]

>> Thanks for this report, I messed with Gnus recently and am now putting
>> out fires. This is a new error for me, and I'll try to fix it tonight.
>
> Actually, here's a patch -- will you please try this out?

Thanks, that seems to fix it for me. 

Alex

bug#34981: 27.0.50; gnus-group-select-group errors with wrong type argument

[Alex Branham]

On Mon 25 Mar 2019 at 12:25, Alex Branham <branham@utexas.edu> wrote:

>>> Thanks for this report, I messed with Gnus recently and am now putting
>>> out fires. This is a new error for me, and I'll try to fix it tonight.
>>
>> Actually, here's a patch -- will you please try this out?
>
> Thanks, that seems to fix it for me. 

I see the fixes were applied to master, thanks. Closing this bug report.

Alex