From: Alex <agrambot@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Renaming non-X x_* procedures in xdisp.c (and elsewhere)
Date: Sat, 30 Mar 2019 11:26:43 -0600 [thread overview]
Message-ID: <87mulcnui4.fsf@gmail.com> (raw)
In-Reply-To: <83o95sisk7.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 30 Mar 2019 13:07:36 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Alex <agrambot@gmail.com>
>> Cc: emacs-devel@gnu.org
>> Date: Mon, 25 Mar 2019 13:21:22 -0600
>>
>> There are three left in xdisp.c:
>>
>> ** x_clear_under_internal_border
>> ** x_change_tool_bar_height
>> ** x_implicitly_set_name
>>
>> Here are those called in frame.{c, h}
>>
>> ** x_set_scroll_bar_default_{width, height}
>> ** x_set_frame_alpha
>> ** x_bitmap_icon
>> ** x_new_font
>> ** x_set_offset
>> ** x_set_window_size
>> ** x_focus_frame
>> ** x_make_frame_(in)visible
>> ** x_iconify_frame
>>
>> This one is called in image.c:
>> ** x_query_color(s)
>
> So why do you prefer not to add this to redisplay_interface?
I just would be a bit confused by the association of some of those
procedures with redisplay. I would expect the procedures there to be
"closer" to the redisplay code, but I suppose I was imagining that there
was more of a difference here. There's also a (perhaps outdated) comment
in termhooks.h that says that redisplay_interface is window-based while
terminal hooks are frame-based.
I think that x_clear_under_internal_border is a good fit for the RIF in
any case.
> We could, of course, invent a new struct and a new macro, but we'd be
> reinventing the FRAME_RIF stuff anyway: the result will most probably
> look identical to FRAME_RIF, except for names. Is that worth our
> while?
Probably not. I was thinking about the rest being terminal hooks,
though. WDYT?
>> This one is called in keyboard.c:
>> ** x_get_keysym_name
>
> This one should simply be renamed without the x_ prefix, I think.
That would still leave the issue of it making the code
single-backend-only. Though, I guess it's not going anywhere.
Should I take it that you are in agreement with the gui- prefix for the
Lisp side?
next prev parent reply other threads:[~2019-03-30 17:26 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-23 15:07 Renaming non-X x_* procedures in xdisp.c (and elsewhere) Alex
2019-03-23 15:38 ` Stefan Monnier
2019-03-23 16:10 ` Eli Zaretskii
2019-03-23 16:41 ` Paul Eggert
2019-03-23 16:59 ` Eli Zaretskii
2019-03-23 17:39 ` Alex
2019-03-23 17:54 ` Alex
2019-03-23 18:16 ` Eli Zaretskii
2019-03-23 18:55 ` Alex
2019-03-23 19:32 ` Eli Zaretskii
2019-03-24 4:14 ` Alex
2019-03-24 4:50 ` Alex
2019-03-24 5:39 ` Eli Zaretskii
2019-03-24 15:05 ` Alex
2019-03-24 16:01 ` Yuri Khan
2019-03-24 16:13 ` Eli Zaretskii
2019-03-24 17:03 ` Eli Zaretskii
2019-03-24 16:27 ` Eli Zaretskii
2019-03-24 18:30 ` Alex
2019-03-24 18:48 ` Eli Zaretskii
2019-03-25 19:21 ` Alex
2019-03-30 10:07 ` Eli Zaretskii
2019-03-30 17:26 ` Alex [this message]
2019-03-30 17:40 ` Eli Zaretskii
2019-03-30 17:59 ` Alex
2019-03-30 18:55 ` Eli Zaretskii
2019-03-30 23:27 ` Alex
2019-03-31 14:52 ` Eli Zaretskii
2019-04-11 19:07 ` Alex
2019-04-12 19:03 ` Eli Zaretskii
2019-04-12 19:50 ` Alex Gramiak
2019-04-12 20:10 ` Eli Zaretskii
2019-04-13 16:26 ` Alex Gramiak
2019-04-13 17:20 ` Eli Zaretskii
2019-04-13 16:13 ` [PATCH] Renaming non-X x_* identifiers (was: Renaming non-X x_* procedures in xdisp.c (and elsewhere)) Alex Gramiak
2019-04-13 17:17 ` Eli Zaretskii
2019-04-13 18:43 ` [PATCH] Renaming non-X x_* identifiers Alex Gramiak
2019-04-13 19:00 ` Eli Zaretskii
2019-04-14 3:35 ` Alex Gramiak
2019-04-14 14:02 ` Eli Zaretskii
2019-04-14 15:57 ` Alex Gramiak
2019-04-14 16:10 ` Eli Zaretskii
2019-04-14 17:34 ` Alex Gramiak
2019-04-15 14:51 ` Eli Zaretskii
2019-04-15 17:46 ` Alex Gramiak
2019-04-15 18:43 ` Eli Zaretskii
2019-04-16 16:24 ` Alex Gramiak
2019-04-16 16:45 ` Eli Zaretskii
2019-04-16 16:59 ` Alex Gramiak
2019-04-16 17:04 ` Eli Zaretskii
2019-04-16 17:07 ` Alex Gramiak
2019-04-16 18:09 ` Eli Zaretskii
2019-04-24 19:40 ` Alex Gramiak
2019-04-25 5:25 ` Eli Zaretskii
2019-04-25 9:56 ` Eli Zaretskii
2019-04-25 14:50 ` Alex Gramiak
2019-04-25 15:04 ` Eli Zaretskii
2019-04-26 6:52 ` Robert Pluim
2019-04-26 8:07 ` Eli Zaretskii
2019-04-26 23:12 ` Alex Gramiak
2019-04-15 22:01 ` Stefan Monnier
2019-04-16 2:29 ` Eli Zaretskii
2019-04-16 12:55 ` Stefan Monnier
2019-04-16 14:58 ` Eli Zaretskii
2019-04-14 3:47 ` Stefan Monnier
2019-04-27 1:53 ` Basil L. Contovounesios
2019-04-27 3:46 ` Alex Gramiak
2019-04-27 11:37 ` Basil L. Contovounesios
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mulcnui4.fsf@gmail.com \
--to=agrambot@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.