From: Juri Linkov <juri@linkov.net>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: 35055@debbugs.gnu.org
Subject: bug#35055: 27.0.50; async-shell-command truncates output lines
Date: Mon, 08 Apr 2019 23:23:46 +0300 [thread overview]
Message-ID: <87mul0tfe5.fsf@mail.linkov.net> (raw)
In-Reply-To: <87v9zpgd3t.fsf@gmx.de> (Michael Albinus's message of "Mon, 08 Apr 2019 09:39:18 +0200")
[-- Attachment #1: Type: text/plain, Size: 968 bytes --]
>>> If you add "COLUMNS=1024" to tramp-remote-process-environment, you would
>>> get this effect already w/o any change in Tramp. Maybe I shall document
>>> it somewhere in the Tramp manual.
>>
>> It seems it's impossible to set COLUMNS to the width of the output window
>> neither in Tramp nor in async-shell-command. shell-mode can do this
>> using set-process-window-size. But Tramp can't do the same for the
>> remote process, and for async-shell-command it's too late to do this
>> because when it displays a window with the output buffer,
>> the command is already finished.
>
> Again, using tramp-remote-process-environment seems to be the
> appropriate place.
Thanks for the suggestion, I customized it to '("COLUMNS=222")
that is approximately equal to my frame's width, thus `ps`
shows enough output, and `dpkg -l '*emacs*'` is not too wide
('dpkg' tries to fill all available columns).
Should a similar option be added for async-shell-command as well?
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: async-shell-command-width.patch --]
[-- Type: text/x-diff, Size: 1430 bytes --]
diff --git a/lisp/simple.el b/lisp/simple.el
index 857e0fc001..7212686add 100644
--- a/lisp/simple.el
+++ b/lisp/simple.el
@@ -3336,6 +3336,15 @@ async-shell-command-display-buffer
:group 'shell
:version "26.1")
+(defcustom async-shell-command-width nil
+ "Number of columns available for shell command.
+If nil, use the shell default number (usually 80).
+If a positive integer, use a fixed width."
+ :type '(choice (const :tag "Use system limit" nil)
+ (integer :tag "Fixed width" :value 80))
+ :group 'shell
+ :version "27.1")
+
(defcustom shell-command-dont-erase-buffer nil
"If non-nil, output buffer is not erased between shell commands.
Also, a non-nil value sets the point in the output buffer
@@ -3599,8 +3608,13 @@ shell-command
(with-current-buffer buffer
(shell-command--save-pos-or-erase)
(setq default-directory directory)
- (setq proc
- (start-process-shell-command "Shell" buffer command))
+ (let ((process-environment
+ (if (natnump async-shell-command-width)
+ (cons (format "COLUMNS=%d" async-shell-command-width)
+ process-environment)
+ process-environment)))
+ (setq proc
+ (start-process-shell-command "Shell" buffer command)))
(setq mode-line-process '(":%s"))
(require 'shell) (shell-mode)
(set-process-sentinel proc #'shell-command-sentinel)
next prev parent reply other threads:[~2019-04-08 20:23 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-30 21:55 bug#35055: 27.0.50; async-shell-command truncates output lines Juri Linkov
2019-04-01 10:00 ` Michael Albinus
2019-04-01 20:44 ` Juri Linkov
2019-04-02 9:27 ` Michael Albinus
2019-04-03 20:36 ` Juri Linkov
2019-04-04 20:59 ` Juri Linkov
2019-04-05 12:35 ` Michael Albinus
2019-04-06 20:47 ` Juri Linkov
2019-04-07 7:32 ` Michael Albinus
2019-04-07 20:15 ` Juri Linkov
2019-04-08 7:39 ` Michael Albinus
2019-04-08 20:23 ` Juri Linkov [this message]
2019-04-13 10:45 ` Michael Albinus
2019-04-13 21:48 ` Juri Linkov
2019-04-14 17:55 ` Michael Albinus
2019-04-14 19:41 ` Juri Linkov
2019-04-15 7:47 ` Michael Albinus
2019-04-16 20:39 ` Juri Linkov
2019-04-17 7:22 ` Michael Albinus
2019-04-17 20:13 ` Juri Linkov
2019-04-18 7:40 ` Michael Albinus
2019-04-18 20:51 ` Juri Linkov
2019-04-19 7:21 ` Michael Albinus
2019-04-30 21:17 ` Michael Albinus
2019-05-01 21:07 ` Juri Linkov
2019-05-02 9:02 ` Michael Albinus
2019-05-02 20:57 ` Juri Linkov
2019-05-03 7:20 ` Michael Albinus
2019-05-05 19:27 ` Juri Linkov
2019-05-06 9:28 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mul0tfe5.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=35055@debbugs.gnu.org \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.