From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#35770: [PATCH] Broken duplicate case elimination in switch byte-compilation Date: Sat, 01 Jun 2019 09:58:42 -0400 Message-ID: <87muj15rvx.fsf@gmail.com> References: <91DFE4D0-BDB6-4365-BA51-A2A3F209177C@acm.org> <752237291204505cd6b3fb98f667c2718fa6361f.camel@acm.org> <7C514C39-A204-44F4-A806-0B7DC3F4E6B4@acm.org> <83sgt67o2x.fsf@gnu.org> <87d0kaag5z.fsf@gmail.com> <83r28q7mxo.fsf@gnu.org> <838sut2h1e.fsf@gnu.org> <93E5062E-4D87-4C36-A44E-2F17D665080B@acm.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="71337"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) Cc: Stefan Monnier , vibhavp@gmail.com, 35770@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jun 01 16:05:40 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hX4df-000IQg-3K for geb-bug-gnu-emacs@m.gmane.org; Sat, 01 Jun 2019 16:05:39 +0200 Original-Received: from localhost ([127.0.0.1]:37528 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hX4dd-000160-VP for geb-bug-gnu-emacs@m.gmane.org; Sat, 01 Jun 2019 10:05:38 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:46116) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hX4dP-0000dH-19 for bug-gnu-emacs@gnu.org; Sat, 01 Jun 2019 10:05:24 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hX4XG-0002O2-9H for bug-gnu-emacs@gnu.org; Sat, 01 Jun 2019 09:59:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53044) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hX4XG-0002Ny-5g for bug-gnu-emacs@gnu.org; Sat, 01 Jun 2019 09:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hX4XG-0000oA-3a for bug-gnu-emacs@gnu.org; Sat, 01 Jun 2019 09:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 01 Jun 2019 13:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35770 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35770-submit@debbugs.gnu.org id=B35770.15593975333090 (code B ref 35770); Sat, 01 Jun 2019 13:59:02 +0000 Original-Received: (at 35770) by debbugs.gnu.org; 1 Jun 2019 13:58:53 +0000 Original-Received: from localhost ([127.0.0.1]:38355 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hX4X6-0000nm-Vk for submit@debbugs.gnu.org; Sat, 01 Jun 2019 09:58:53 -0400 Original-Received: from mail-it1-f182.google.com ([209.85.166.182]:33550) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hX4X4-0000nY-TX for 35770@debbugs.gnu.org; Sat, 01 Jun 2019 09:58:51 -0400 Original-Received: by mail-it1-f182.google.com with SMTP id j17so13288986itk.0 for <35770@debbugs.gnu.org>; Sat, 01 Jun 2019 06:58:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=4Xuocrt+F+QNUwtfxx3592sErM3HFU37TUE8n7VbgIw=; b=kJlga8La0ztOKhFsMGB0ZFXt8FGbWOng1HPPd0CoG6TwWX9sASJjcHKKpXXYTzPMjA ERLRRue/vgjn+cZw8MJsYAdfiuvXkIl5TjIb3FC/H0Iz6obGRtDvsUdZF37UIJa4i3qZ 0yMSsuufOovu+SY4zYgov+sgjOIXkXJMWOgHgR98115PW4OwlGODmk+zgGQ/q581xQZI IK42pXEP54G6GJOUIHbywSkcRRPn1rLZsb4O4OFwHsnZh9xf/ltGvimCVvBsiDad5Cv/ uEKpz+4aCi45qHqSO9xwL4JchnJ0OUWsAsZN7FQoL1bbcFcdCLKtp7+A7VnA3X7lHBMH kxjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=4Xuocrt+F+QNUwtfxx3592sErM3HFU37TUE8n7VbgIw=; b=FgANG2OY1i47o9xejtJSSxVOV8SXCtUJJQCaYbZMmC2g8hyNu84VatOA09Kx8TRcpI A9t84jdKB2vxR8u+mWZ+x5rKmM00PMIZSMjFW0oh4q9qaD662lmk0xrJimPX3Psc+X3h RLHB2JsAFhDUUgDC46GYTrrKJnrd6SlOfatn/rusWe0S3fHQj+SNcs5EyZvRutwQKMDV BxpyFitNtOkgrreUokSA4bc9ZiM+Qnhb+6/G/SiA1kdxw/0fHEu0b5hxzcwYjqsRbiFS SnF1/A1uIcA2C168IBifBL+VT2AL7yp11vmWB1/72ONrbyuZ+pEs9No0LFDd01+5PPkF a1xQ== X-Gm-Message-State: APjAAAWv0t92Qglemn7PrBNfePeAQAAQQLilrl1hv5jHK9gLYFO4sSN1 8nE1XLH2L3Qim2qJWORx5smdkaDR X-Google-Smtp-Source: APXvYqwYBuG7G17q4DjWWYKrgck4fOSsNJssFCdOpmh4ea48jc/7va8TOyb4O1JHsujS+mgmQNBGTw== X-Received: by 2002:a24:2201:: with SMTP id o1mr10039495ito.90.1559397524815; Sat, 01 Jun 2019 06:58:44 -0700 (PDT) Original-Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id a206sm1347803itb.8.2019.06.01.06.58.43 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 01 Jun 2019 06:58:43 -0700 (PDT) In-Reply-To: <93E5062E-4D87-4C36-A44E-2F17D665080B@acm.org> ("Mattias \=\?utf-8\?Q\?Engdeg\=C3\=A5rd\=22's\?\= message of "Mon, 27 May 2019 13:27:38 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:160001 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mattias Engdeg=C3=A5rd writes: > Trying to revert 'the rest' (the switch code generation) while keeping > the switch op itself seems indeed to be risky and a lot of work > compared to just turning off the generation. It is not a matter of > finding a few commits to revert; there are fixes upon fixes, and > changes that need to be untangled. It does not sound very practical. So, is this patch okay for emacs-26? --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Disable-byte-compile-cond-use-jump-table-Bug-35770.patch Content-Description: patch >From 257a750a10ebb77277a5d7d771c01d66a69a66e4 Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Sat, 1 Jun 2019 09:53:35 -0400 Subject: [PATCH] Disable byte-compile-cond-use-jump-table (Bug#35770) * lisp/emacs-lisp/bytecomp.el (byte-compile-cond-use-jump-table): Set to nil by default. Don't merge to master, the bug is already fixed there. --- lisp/emacs-lisp/bytecomp.el | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el index e3b34c189f..9273626c80 100644 --- a/lisp/emacs-lisp/bytecomp.el +++ b/lisp/emacs-lisp/bytecomp.el @@ -234,9 +234,9 @@ (defcustom byte-compile-delete-errors nil :group 'bytecomp :type 'boolean) -(defcustom byte-compile-cond-use-jump-table t +(defcustom byte-compile-cond-use-jump-table nil "Compile `cond' clauses to a jump table implementation (using a hash-table)." - :version "26.1" + :version "26.3" ;; Disabled due to Bug#35770. :group 'bytecomp :type 'boolean) -- 2.11.0 --=-=-=--