From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.devel Subject: Re: send new reply from gnus hangs Date: Fri, 14 Jun 2019 07:58:34 -0700 Message-ID: <87muikdxid.fsf@ericabrahamsen.net> References: <87r285nhxb.fsf@telefonica.net> <87k1duml43.fsf@telefonica.net> <87sgsiwehh.fsf@telefonica.net> <87k1du744k.fsf@telefonica.net> <87h88y8ibl.fsf@telefonica.net> <878suas5wv.fsf@telefonica.net> <87d0jmuyrj.fsf@telefonica.net> <87imtetju1.fsf@telefonica.net> <87sgscgab4.fsf@ericabrahamsen.net> <87sgscqo4r.fsf@telefonica.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="22254"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jun 14 16:58:54 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hbnfJ-0005fd-Ka for ged-emacs-devel@m.gmane.org; Fri, 14 Jun 2019 16:58:53 +0200 Original-Received: from localhost ([::1]:52374 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hbnfI-0000Fk-HV for ged-emacs-devel@m.gmane.org; Fri, 14 Jun 2019 10:58:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42418) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hbnfA-0000B2-A8 for emacs-devel@gnu.org; Fri, 14 Jun 2019 10:58:45 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hbnf9-0004Hf-4D for emacs-devel@gnu.org; Fri, 14 Jun 2019 10:58:44 -0400 Original-Received: from [195.159.176.226] (port=35570 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hbnf8-0004Fe-Pt for emacs-devel@gnu.org; Fri, 14 Jun 2019 10:58:43 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.89) (envelope-from ) id 1hbnf6-0005Nq-0u for emacs-devel@gnu.org; Fri, 14 Jun 2019 16:58:40 +0200 X-Injected-Via-Gmane: http://gmane.org/ Cancel-Lock: sha1:ez8Qa5bwuuNfHu/rZWCRI988gW8= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:237617 Archived-At: Óscar Fuentes writes: > Eric Abrahamsen writes: > >> Okay, that worked! >> >> What does everyone think of the attached diff? It moves the >> `message-check' call out of the internal function (that seems like work >> that should be done by the caller, not the internal function, and helps >> the call fit in visually), and either returns nil or errors depending on >> an optional arg. > > I have no time now to review the code (and I'm not familiar with Gnus' > code base) but I was going to propose reverting the problematic commit. > If your patch solves the problem, great. If there are doubts, the right > thing is reverting. > > There is no justification for having master in an unusable state (if you > are a Gnus user) for more than a week due to a cosmetic change like > this. Stefan's already fixed this with a different patch, it should be working again now.